[Bug 2327938] New: Review Request: python-cmdkit - library for developing command-line applications in Python
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Bug ID: 2327938 Summary: Review Request: python-cmdkit - library for developing command-line applications in Python Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jonathan@almalinux.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/python-cmdkit... SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/python-cmdkit... Description: library for developing command-line applications in Python
Fedora Account System Username: jonathanspw
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://cmdkit.readthedocs. | |io/
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8299938 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- python3-toml is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag... - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Jonathan Wright jonathan@almalinux.org --- I've made upstream aware of the python-toml deprecation and they'll be shifting to a different library. Let's not hold up this package over that please.
SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/python-cmdkit... Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/python-cmdkit...
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2059223 --> https://bugzilla.redhat.com/attachment.cgi?id=2059223&action=edit The .spec file difference from Copr build 8299938 to 8299955
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8299955 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- python3-toml is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review? CC| |ngompa13@gmail.com Status|NEW |ASSIGNED
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- (In reply to Jonathan Wright from comment #2)
I've made upstream aware of the python-toml deprecation and they'll be shifting to a different library. Let's not hold up this package over that please.
I don't see any indication in the upstream GitHub project that this is being tracked.
https://github.com/glentner/CmdKit/issues
Without that and some acknowledgement they are working on switching, I don't think we can ignore the deprecated dependency.
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #7 from Jonathan Wright jonathan@almalinux.org ---
I don't see any indication in the upstream GitHub project that this is being tracked.
I spoke with the dev in-person today at SC24 and also in discord a few minutes ago.
I'll get an issue opened on GH and have him acknowledge it there to satisfy this.
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
--- Comment #8 from Jonathan Wright jonathan@almalinux.org --- Here ya go @ngompa13@gmail.com
https://github.com/glentner/hypershell/issues/33
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co | |m) |
--- Comment #9 from Neal Gompa ngompa13@gmail.com --- Is it possible for you to vendor the module in the package until it's replaced?
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #10 from Jonathan Wright jonathan@almalinux.org --- Why? python-toml, while deprecated, is still present in Fedora.
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@emailplus.org
--- Comment #11 from Benson Muite benson_muite@emailplus.org --- Possibly a patch could be applied - have not tested, but it seems a few lines need to be changed: https://github.com/glentner/CmdKit/pull/24
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #12 from Benson Muite benson_muite@emailplus.org --- Upstream has released a new version that does not use python-toml: https://github.com/glentner/CmdKit/releases
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #13 from Jonathan Wright jonathan@almalinux.org --- SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fe... Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fe...
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #14 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2061996 --> https://bugzilla.redhat.com/attachment.cgi?id=2061996&action=edit The .spec file difference from Copr build 8299955 to 8374275
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #15 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8374275 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #16 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows packaging guidelines * Package builds and installs * Package licensing is correct and license data is installed correctly * No serious issues from rpmlint
Things to fix on import:
#%%tox / %%pytest / %%pyproject_check_import ...
This should just be deleted
- Tue Dec 10 2024 Jonathan Wright jonathan@almalinux.org - 2.7.6
This should use "2.7.6-1" to be compliant with our changelog format rules.
Other than that, this looks good, so...
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #17 from Neal Gompa ngompa13@gmail.com --- (In reply to Fedora Review Service from comment #15)
Found issues:
- python3-pytest7 is deprecated, you must not depend on it. Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating- packages/
Please know that there can be false-positives.
Oof, okay, can this be moved to a newer pytest?
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #18 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cmdkit
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #19 from Jonathan Wright jonathan@almalinux.org --- I'm not sure why but python-pytest is pointing to pytest7 here which is what CI is complaining about. Will look into that.
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
--- Comment #20 from Benson Muite benson_muite@emailplus.org --- pytest7 is a false positive
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4ad9f50e6e (python-cmdkit-2.7.6-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4ad9f50e6e
https://bugzilla.redhat.com/show_bug.cgi?id=2327938
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-12-12 01:04:45
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4ad9f50e6e (python-cmdkit-2.7.6-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com