https://bugzilla.redhat.com/show_bug.cgi?id=2150509
Bug ID: 2150509 Summary: Review Request: rust-mutate_once - Interior mutability, write-once and borrowable as plain &T Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: klember@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://kalev.fedorapeople.org/rust-mutate_once.spec SRPM URL: https://kalev.fedorapeople.org/rust-mutate_once-0.1.1-1.fc38.src.rpm Description: Interior mutability, write-once and borrowable as plain &T.
Fedora Account System Username: kalev
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=94882531
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2150511
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2150511 [Bug 2150511] Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED CC| |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- I think you'll need to include a license file. It's literally clause 1 of the BSD-2-Clause license:
- Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- As an alternative, it might be possible to migrate the code that uses this crate to use the once_cell crate, instead? https://crates.io/crates/once_cell
It's pretty much the standard solution for the "set once, read many" problem nowadays, it's actively maintained, and its functionality is probably going to be merged into the Rust standard library at some point: https://github.com/rust-lang/rfcs/pull/2788
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(klember@redhat.co | |m)
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(klember@redhat.co | |m) |
--- Comment #3 from Kalev Lember klember@redhat.com --- Sorry for the slow reply!
I filed https://github.com/kamadak/mutate_once-rs/issues/1 together with the package review request and upstream just added a LICENSE file in the repository. Let me add that to the downstream packaging now.
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Yes, you can include the upstream license text as a separate source and include it in the package manually until upstream publishes a new release, i.e. something like
Source1: https://github.com/kamadak/mutate_once-rs/raw/0dc8ba7/LICENSE
%prep (...) cp -pav %{SOURCE1} .
%files %license %{crate_instdir}/LICENSE (...)
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
--- Comment #5 from Kalev Lember klember@redhat.com --- * Thu Mar 23 2023 Kalev Lember klember@redhat.com - 0.1.1-2 - Add missing LICENSE file from upstream
Spec URL: https://kalev.fedorapeople.org/rust-mutate_once.spec SRPM URL: https://kalev.fedorapeople.org/rust-mutate_once-0.1.1-2.fc39.src.rpm
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99062739
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/mu | |tate_once
--- Comment #6 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5701570 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Thanks for the update! Looks good to me now.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (BSD-2-Clause) and is acceptable for Fedora - license file is included with %license in %files (manually included until next release) - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-mutate_once
https://bugzilla.redhat.com/show_bug.cgi?id=2150509
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Fixed In Version| |rust-mutate_once-0.1.1-2.fc | |39 Last Closed| |2023-03-23 21:41:01
--- Comment #9 from Kalev Lember klember@redhat.com --- Thank you! Package imported and build is under way.
package-review@lists.fedoraproject.org