[Bug 1700559] New: Review Request: igt-gpu-tools - Up to date replacement for intel-gpu-tools
https://bugzilla.redhat.com/show_bug.cgi?id=1700559
Bug ID: 1700559 Summary: Review Request: igt-gpu-tools - Up to date replacement for intel-gpu-tools Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lyude@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://people.freedesktop.org/~lyudess/archive/04-16-2019/fedora-igt-gpu-to... SRPM URL: https://people.freedesktop.org/~lyudess/archive/04-16-2019/fedora-igt-gpu-to... URL for everything else: https://people.freedesktop.org/~lyudess/archive/04-16-2019/fedora-igt-gpu-to... Description: igt-gpu-tools (formally known as intel-gpu-tools) is the standard for writing test cases for DRM drivers. It also includes a handful of useful tools for various drivers, such as Intel's GPU tools for i915. Fedora Account System Username: lyudess
Once this package is added into Fedora, I will be removing the intel-gpu-tools and xorg-x11-drv-intel-devel packages from fedora's xorg-x11-drv-intel package.
https://bugzilla.redhat.com/show_bug.cgi?id=1700559
Adam Jackson ajax@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ajax@redhat.com
--- Comment #1 from Adam Jackson ajax@redhat.com ---
Provides: xorg-x11-drv-intel-devel intel-gpu-tools Obsoletes: xorg-x11-drv-intel-devel intel-gpu-tools
These should be versioned, in the unlikely event we ever reintroduce packages with those names. Something like:
%define provobs_version 2.99.917-42 Provides: xorg-x11-drv-intel-devel = %{provobs_version} Obsoletes: xorg-x11-drv-intel-devel < %{provobs_version} # same for intel-gpu-tools
I picked -42 here to be newer than the current intel driver version.
%description igt-gpu-tools (formally known as intel-gpu-tools) is the standard for writing test cases for DRM drivers. It also includes a handful of useful tools for various drivers, such as Intel's GPU tools for i915.
"formally" should probably be "formerly" here.
%{_libdir}/intel_aubdump.so %{_libdir}/libigt.so %{_libdir}/pkgconfig/intel-gen4asm.pc
It's probably overkill to split these out to a devel subpackage since I don't really expect any external projects to use them. However, Fedora really prefers that real DSOs (not -devel symlinks, and not dlopen-only things like DRI drivers) be versioned, even if it's libblah.so.0. Would be good to push that upstream if you can. Debian has a similar policy so this isn't just Fedora being weird.
https://bugzilla.redhat.com/show_bug.cgi?id=1700559
--- Comment #2 from Lyude lyude@redhat.com --- (In reply to Adam Jackson from comment #1)
Provides: xorg-x11-drv-intel-devel intel-gpu-tools Obsoletes: xorg-x11-drv-intel-devel intel-gpu-tools
These should be versioned, in the unlikely event we ever reintroduce packages with those names. Something like:
%define provobs_version 2.99.917-42 Provides: xorg-x11-drv-intel-devel = %{provobs_version} Obsoletes: xorg-x11-drv-intel-devel < %{provobs_version} # same for intel-gpu-tools
I picked -42 here to be newer than the current intel driver version.
%description igt-gpu-tools (formally known as intel-gpu-tools) is the standard for writing test cases for DRM drivers. It also includes a handful of useful tools for various drivers, such as Intel's GPU tools for i915.
"formally" should probably be "formerly" here.
%{_libdir}/intel_aubdump.so %{_libdir}/libigt.so %{_libdir}/pkgconfig/intel-gen4asm.pc
It's probably overkill to split these out to a devel subpackage since I don't really expect any external projects to use them. However, Fedora really prefers that real DSOs (not -devel symlinks, and not dlopen-only things like DRI drivers) be versioned, even if it's libblah.so.0. Would be good to push that upstream if you can. Debian has a similar policy so this isn't just Fedora being weird.
All changes made and relevant patches submitted upstream - just check the URLs I posted before again
https://bugzilla.redhat.com/show_bug.cgi?id=1700559
--- Comment #3 from Adam Jackson ajax@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Expat License", "GPL (v2 or later)", "Unknown or generated", "ISC License", "Expat License", "GPL (v2)", "NTP License (legal disclaimer)". 1036 files have unknown license. Detailed output of licensecheck in /tmp/r/review-igt-gpu-tools/licensecheck.txt [!]: License file installed when any subpackage combination is installed.
Not included in -docs subpackage. Meh.
[!]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/igt-gpu-tools, /usr/share/gtk- doc/html/igt-gpu-tools, /usr/share/igt-gpu-tools [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/igt-gpu-tools, /usr/share/gtk-doc/html, /usr/libexec/igt-gpu-tools, /usr/share/gtk- doc/html/igt-gpu-tools, /usr/share/gtk-doc [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package
Should probably just delete the .so symlinks and intel-gen4asm.pc from %install.
[x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in igt-gpu- tools-docs , igt-gpu-tools-debuginfo , igt-gpu-tools-debugsource [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. Note: igt-gpu-tools : /usr/lib64/pkgconfig/intel-gen4asm.pc [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define gitcommit e03d0030391689cfd0fbca293d44d83dd7d9e356, %define gitdate 20190416, %define gitrev .%{gitdate}git%(c=%{gitcommit}; echo ${c:0:7}), %define obsolete_version 2.99.917-42.20180618 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL.
===== EXTRA items =====
Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2211840 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: igt-gpu-tools-1.23-1.20190416gite03d003.fc29.x86_64.rpm igt-gpu-tools-docs-1.23-1.20190416gite03d003.fc29.x86_64.rpm igt-gpu-tools-debuginfo-1.23-1.20190416gite03d003.fc29.x86_64.rpm igt-gpu-tools-debugsource-1.23-1.20190416gite03d003.fc29.x86_64.rpm igt-gpu-tools-1.23-1.20190416gite03d003.fc29.src.rpm igt-gpu-tools.x86_64: W: spelling-error %description -l en_US intel -> inlet, Intel, lintel igt-gpu-tools.x86_64: E: no-changelogname-tag igt-gpu-tools.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib64/libigt.so.0 igt-gpu-tools.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libigt.so igt-gpu-tools.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/intel-gen4asm.pc igt-gpu-tools.x86_64: W: no-manual-page-for-binary dpcd_reg igt-gpu-tools.x86_64: W: no-manual-page-for-binary igt_results igt-gpu-tools.x86_64: W: no-manual-page-for-binary igt_resume igt-gpu-tools.x86_64: W: no-manual-page-for-binary igt_runner igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel-gen4asm igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel-gen4disasm igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_backlight igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_display_crc igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_display_poller igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_dp_compliance igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_dump_decode igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_firmware_decode igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_forcewaked igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_framebuffer_dump igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_gem_info igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_gpu_abrt igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_gpu_time igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_guc_logger igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_gvtg_test igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_l3_parity igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_opregion_decode igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_perf_counters igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_reg_checker igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_residency igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_watermark igt-gpu-tools-docs.x86_64: W: spelling-error %description -l en_US gtk -> gt, gt k igt-gpu-tools-docs.x86_64: E: no-changelogname-tag igt-gpu-tools-debuginfo.x86_64: E: no-changelogname-tag igt-gpu-tools-debugsource.x86_64: E: no-changelogname-tag igt-gpu-tools.src: W: spelling-error %description -l en_US intel -> inlet, Intel, lintel igt-gpu-tools.src: E: no-changelogname-tag igt-gpu-tools.src: W: strange-permission make-git-snapshot.sh 775 igt-gpu-tools.src: W: invalid-url Source0: igt-gpu-tools-20190416.tar.bz2 5 packages and 0 specfiles checked; 6 errors, 32 warnings.
Rpmlint (debuginfo) ------------------- Checking: igt-gpu-tools-debuginfo-1.23-1.20190416gite03d003.fc29.x86_64.rpm igt-gpu-tools-debuginfo.x86_64: E: no-changelogname-tag 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory igt-gpu-tools-debugsource.x86_64: E: no-changelogname-tag igt-gpu-tools-debugsource.x86_64: W: invalid-url URL: https://gitlab.freedesktop.org/drm/igt-gpu-tools <urlopen error [Errno -2] Name or service not known> igt-gpu-tools-debuginfo.x86_64: E: no-changelogname-tag igt-gpu-tools-debuginfo.x86_64: W: invalid-url URL: https://gitlab.freedesktop.org/drm/igt-gpu-tools <urlopen error [Errno -2] Name or service not known> igt-gpu-tools-docs.x86_64: W: spelling-error %description -l en_US gtk -> gt, gt k igt-gpu-tools-docs.x86_64: E: no-changelogname-tag igt-gpu-tools-docs.x86_64: W: invalid-url URL: https://gitlab.freedesktop.org/drm/igt-gpu-tools <urlopen error [Errno -2] Name or service not known> igt-gpu-tools.x86_64: W: spelling-error %description -l en_US intel -> inlet, Intel, lintel igt-gpu-tools.x86_64: E: no-changelogname-tag igt-gpu-tools.x86_64: W: invalid-url URL: https://gitlab.freedesktop.org/drm/igt-gpu-tools <urlopen error [Errno -2] Name or service not known> igt-gpu-tools.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libigt.so.0 /lib64/libgslcblas.so.0 igt-gpu-tools.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib64/libigt.so.0 igt-gpu-tools.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libigt.so igt-gpu-tools.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/intel-gen4asm.pc igt-gpu-tools.x86_64: W: no-manual-page-for-binary dpcd_reg igt-gpu-tools.x86_64: W: no-manual-page-for-binary igt_results igt-gpu-tools.x86_64: W: no-manual-page-for-binary igt_resume igt-gpu-tools.x86_64: W: no-manual-page-for-binary igt_runner igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel-gen4asm igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel-gen4disasm igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_backlight igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_display_crc igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_display_poller igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_dp_compliance igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_dump_decode igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_firmware_decode igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_forcewaked igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_framebuffer_dump igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_gem_info igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_gpu_abrt igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_gpu_time igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_guc_logger igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_gvtg_test igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_l3_parity igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_opregion_decode igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_perf_counters igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_reg_checker igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_residency igt-gpu-tools.x86_64: W: no-manual-page-for-binary intel_watermark 4 packages and 0 specfiles checked; 5 errors, 34 warnings.
Requires -------- igt-gpu-tools-debugsource (rpmlib, GLIBC filtered):
igt-gpu-tools-debuginfo (rpmlib, GLIBC filtered):
igt-gpu-tools-docs (rpmlib, GLIBC filtered):
igt-gpu-tools (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/pkg-config /usr/bin/sh libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libdrm.so.2()(64bit) libdrm_amdgpu.so.1()(64bit) libdrm_intel.so.1()(64bit) libdrm_nouveau.so.2()(64bit) libdw.so.1()(64bit) libdw.so.1(ELFUTILS_0.122)(64bit) libdw.so.1(ELFUTILS_0.127)(64bit) libglib-2.0.so.0()(64bit) libgsl.so.23()(64bit) libgslcblas.so.0()(64bit) libigt.so.0()(64bit) libjson-c.so.4()(64bit) libkmod.so.2()(64bit) libkmod.so.2(LIBKMOD_5)(64bit) libm.so.6()(64bit) libpciaccess.so.0()(64bit) libpixman-1.so.0()(64bit) libprocps.so.7()(64bit) libprocps.so.7(LIBPROCPS_0)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libunwind.so.8()(64bit) libxmlrpc.so.3()(64bit) libxmlrpc_client.so.3()(64bit) libxmlrpc_util.so.4()(64bit) libz.so.1()(64bit) rtld(GNU_HASH)
Provides -------- igt-gpu-tools-debugsource: igt-gpu-tools-debugsource igt-gpu-tools-debugsource(x86-64)
igt-gpu-tools-debuginfo: debuginfo(build-id) igt-gpu-tools-debuginfo igt-gpu-tools-debuginfo(x86-64)
igt-gpu-tools-docs: igt-gpu-tools-docs igt-gpu-tools-docs(x86-64)
igt-gpu-tools: igt-gpu-tools igt-gpu-tools(x86-64) intel-gpu-tools libigt.so.0()(64bit) pkgconfig(intel-gen4asm) xorg-x11-drv-intel-devel
Unversioned so-files -------------------- igt-gpu-tools: /usr/lib64/intel_aubdump.so igt-gpu-tools: /usr/lib64/libigt.so
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-29-x86_64 -n igt-gpu-tools Buildroot used: fedora-29-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
---
The rpmlint warnings are either addressed by comments near [!] items above, or can be ignored.
https://bugzilla.redhat.com/show_bug.cgi?id=1700559
--- Comment #4 from Lyude lyude@redhat.com --- Changes made: * Address comments from fedora-review * Remove pkgconfig files during install * Remove unversioned solinks during install * Provide licenses with both subpackages * Fix s390x building by disabling libunwind (apparently we don't currently ship this with Fedora) * Fix some build breakages that got introduced when upstream igt-gpu-tools added some runtime symbol resolver functions (-Dc_link_args="-z lazy") * Prefer %global vs. %define * Update git snapshot, remove patches that got pushed upstream and add some new ones that haven't been yet
Files at https://people.freedesktop.org/~lyudess/archive/05-08-2019/
https://bugzilla.redhat.com/show_bug.cgi?id=1700559
Adam Jackson ajax@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #5 from Adam Jackson ajax@redhat.com --- lgtm, setting fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1700559
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/igt-gpu-tools
https://bugzilla.redhat.com/show_bug.cgi?id=1700559
Lyude lyude@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-05-16 18:37:26
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com