https://bugzilla.redhat.com/show_bug.cgi?id=2293883
Bug ID: 2293883 Summary: Review Request: golang-github-substrait-io - Experimental Go bindings for substrait Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-substrait-io.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-substrait-io-0.4....
Description: Experimental Go bindings for substrait.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=2293883
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Copr build: https://copr.fedorainfracloud.org/coprs/eclipseo/gotests/build/7657108/ (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/eclipseo/gotests/fedora-r...
Please take a look if any issues were found.
https://bugzilla.redhat.com/show_bug.cgi?id=2293883
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7657428 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2293883
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mikel@olasagasti.info Flags| |fedora-review+ CC| |mikel@olasagasti.info Status|NEW |ASSIGNED
--- Comment #3 from Mikel Olasagasti Uranga mikel@olasagasti.info --- In https://discussion.fedoraproject.org/t/4-go-packages-to-review/123119 you mention this package needs to be boostrapped, but it built just fine for me.
This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2293883
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-substrait-io
package-review@lists.fedoraproject.org