[Bug 719324] New: Review Request: libkdcraw - A C++ interface around LibRaw library - package-review

List overview All Threads
Download

newer

[Bug 719324] New: Review Request: libkdcraw - A C++ interface around LibRaw library

older

[Bug 719325] New: Review Request:...

[Bug 674738] New: Review Request:...

Red Hat Bugzilla

6 Jul 2011 6 Jul '11

3:50 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: libkdcraw - A C++ interface around LibRaw library

https://bugzilla.redhat.com/show_bug.cgi?id=719324

Summary: Review Request: libkdcraw - A C++ interface around LibRaw library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: ---

Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw-4.6.90-1.fc15.src... Description: A C++ interface around LibRaw library

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

6 Jul 6 Jul

3:50 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

Rex Dieter rdieter@math.unl.edu changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10 Jul 10 Jul

4:48 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #1 from Rex Dieter rdieter@math.unl.edu 2011-07-10 10:48:50 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw-4.6.90-3.fc15.src...

%changelog * Sun Jul 10 2011 Rex Dieter rdieter@fedoraproject.org 4.6.90-3 - License: GPLv2+ - %%doc: +ChangeLog NEWS - add %%check section

* Wed Jul 06 2011 Rex Dieter rdieter@fedoraproject.org 4.6.90-2 - fix URL - Conflicts: kdegraphics < 7:4.6.90-10

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:08 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

nucleo alekcejk@googlemail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |alekcejk@googlemail.com

--- Comment #2 from nucleo alekcejk@googlemail.com 2011-07-10 15:08:08 EDT --- rpmlint output for libkdcraw-4.6.90-3 rpms:

libkdcraw.i686: E: description-line-too-long C picture files. More information about LibRaw can be found at http://www.libraw.org. libkdcraw.src: E: description-line-too-long C picture files. More information about LibRaw can be found at http://www.libraw.org. libkdcraw.x86_64: E: description-line-too-long C picture files. More information about LibRaw can be found at http://www.libraw.org. libkdcraw-devel.i686: W: no-documentation libkdcraw-devel.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 3 errors, 2 warnings.

So description-line-too-long should be fixed.

update-desktop-database in %posttrans not needed because no desktop files installed.

libkdcraw license is GPLv2+ but it built using libRaw sources which have different licenses. libRaw have license LGPLv2 or CDDL. It uses demosaic-pack-GPL2 and demosaic-pack-GPL3 sources. There is notes about demosaic-packs license in README.demosaic-packs:

Unfortunately, some of these methods are distributed under the terms of different versions of GNU General Public License (GPL). So it is not possible to include implementation of these demosaics into the LibRaw distribution because LibRaw is distributed under more liberal licenses (LGPL and CDDL).

Of course, it is possible to distribute these demosaic methods in separate packages and use within LibRaw under following conditions:

* LibRaw is used under the terms of LGPL license which is GPL-compatible * Resulting product (which uses LibRaw AND LibRaw-demosaic-pack) is licensed under GPL2+ (for GPL2 demosaic-pack) or GPL3+ (if demosaic-pack-GPL3 is used).

So I guess that resulting License tag for libkdkraw should be GPLv2+ and GPLv3+?

This README also can be added in %doc.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:26 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #3 from nucleo alekcejk@googlemail.com 2011-07-10 15:26:25 EDT --- Or maybe should be License: GPLv3+?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11 Jul 11 Jul

12:49 a.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2011-07-10 18:49:36 EDT --- A bit of a mess, wrt licening and bundled code, I'll look into using system-libraw.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:01 a.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #5 from nucleo alekcejk@googlemail.com 2011-07-10 19:01:28 EDT --- There is no system-wide shared libRaw library if you mean this package http://koji.fedoraproject.org/koji/packageinfo?packageID=10605

Only static lib available there libraw.a which version older than in libkdcraw tarball. So using libRaw-devel not makes sense because even if libRaw-devel will be updated libkdcraw will use previous version.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:41 a.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #6 from nucleo alekcejk@googlemail.com 2011-07-10 19:41:20 EDT --- Here explanation why libraw included in libkdcraw http://mail.kde.org/pipermail/digikam-devel/2010-March/041682.html

...

So, due the experimental stage of libraw for the moment, and until the implementation and the API will be stabilized, i think that including libraw as well is better.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:49 a.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #7 from Rex Dieter rdieter@math.unl.edu 2011-07-10 20:49:11 EDT --- Ah thanks!

ok, I'll rework this assuming bundling then.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:17 a.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #8 from nucleo alekcejk@googlemail.com 2011-07-10 21:17:34 EDT --- It is will be better to change URL to https://projects.kde.org/projects/kde/kdegraphics/libs/libkdcraw

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:48 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #9 from Rex Dieter rdieter@math.unl.edu 2011-07-11 09:48:43 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw-4.6.90-5.fc15.src...

%changelog * Mon Jul 11 2011 Rex Dieter rdieter@fedoraproject.org 4.6.90-5 - License: GPLv2+ and LGPLv2 and GPLv3+ - Provides: bundled(LibRaw)

* Sun Jul 10 2011 Rex Dieter rdieter@fedoraproject.org 4.6.90-4 - fix URL - fix scriptlets

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:29 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

nucleo alekcejk@googlemail.com changed:

--- Comment #10 from nucleo alekcejk@googlemail.com 2011-07-11 10:29:40 EDT --- rpmlint output for ibkdcraw-4.6.90-5 rpms:

libkdcraw.i686: W: spurious-executable-perm /usr/share/doc/libkdcraw-4.6.90/LICENSE.LGPL libkdcraw.i686: E: incorrect-fsf-address /usr/share/doc/libkdcraw-4.6.90/LICENSE.LGPL libkdcraw.src:25: W: unversioned-explicit-provides bundled(LibRaw) libkdcraw.src:27: W: unversioned-explicit-provides bundled(LibRaw-demosaic-pack-GPL2) libkdcraw.src:28: W: unversioned-explicit-provides bundled(LibRaw-demosaic-pack-GPL3) libkdcraw.x86_64: W: spurious-executable-perm /usr/share/doc/libkdcraw-4.6.90/LICENSE.LGPL libkdcraw.x86_64: E: incorrect-fsf-address /usr/share/doc/libkdcraw-4.6.90/LICENSE.LGPL libkdcraw-devel.i686: W: no-documentation libkdcraw-devel.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 2 errors, 7 warnings.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:35 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

nucleo alekcejk@googlemail.com changed:

--- Comment #11 from nucleo alekcejk@googlemail.com 2011-07-11 10:35:25 EDT --- rpmlint errors not serious and can be fixed later.

Package and spec names are fine, description is fine now, license GPLv2+ and LGPLv2 and GPLv3+ is actual license used in libkdcraw and bundled libraw sources, Requires in devel package fine, scriptlets are fine, package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=3190903

Package APPROVED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:45 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

Rex Dieter rdieter@math.unl.edu changed:

--- Comment #12 from Rex Dieter rdieter@math.unl.edu 2011-07-11 10:45:21 EDT --- Thanks. What's the purpose of marking fedora_requires_release_note flag?

New Package SCM Request ======================= Package Name: libkdcraw Short Description: A C++ interface around LibRaw library Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:55 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |alekcejk@googlemail.com

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:59 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

nucleo alekcejk@googlemail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:15 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #13 from Jon Ciesla limb@jcomserv.net 2011-07-11 11:15:34 EDT --- pkgdb says it already exists.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:56 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #14 from Rex Dieter rdieter@math.unl.edu 2011-07-11 12:56:25 EDT --- doh, forgot about that, let's try change request instead then. fyi, this needs also to be marked not deprecated.

Package Change Request ====================== Package Name: libkdcraw Short Description: A C++ interface around LibRaw library Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:13 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

--- Comment #15 from Jon Ciesla limb@jcomserv.net 2011-07-11 13:13:44 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:14 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

Jon Ciesla limb@jcomserv.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |limb@jcomserv.net

--- Comment #16 from Jon Ciesla limb@jcomserv.net 2011-07-11 13:14:50 EDT --- Did f15 branch, can't do 1 or 3, you'll need to file a rel-eng trac.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12 Jul 12 Jul

7:07 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

Rex Dieter rdieter@math.unl.edu changed:

--- Comment #17 from Rex Dieter rdieter@math.unl.edu 2011-07-12 13:07:54 EDT --- imported.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8 Dec 8 Dec

7:19 p.m.

New subject: [Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719324

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|656997(kde-reviews) |

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4975

Age (days ago)

5130

Last active (days ago)

package-review@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla