Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Bug ID: 947861 Summary: Review Request: igor - Automated distribution life-cycle testing Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fdeutsch@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Category: ---
Spec URL: http://fabiand.fedorapeople.org/igor/0/igor.spec SRPM URL: http://fabiand.fedorapeople.org/igor/0/igor-0.3.0-1.fc18.src.rpm Description: Igor is a small daemon to continuous automated testing of PXE based Linux distributions with cobbler, libvirt and real hardware. It is intended to be combined with Jenkins and to test oVirt Node.
Fedora Account System Username: fabiand
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
--- Comment #1 from Fabian Deutsch fdeutsch@redhat.com --- http://koji.fedoraproject.org/koji/taskinfo?taskID=5203502
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
--- Comment #2 from Fabian Deutsch fdeutsch@redhat.com --- Updated to run the systemd macros.
Spec URL: http://fabiand.fedorapeople.org/igor/2/igor.spec SRPM URL: http://fabiand.fedorapeople.org/igor/2/igor-0.3.0-2.fc18.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
--- Comment #3 from Fabian Deutsch fdeutsch@redhat.com --- With changes suggested by mrunge
Spec URL: http://fabiand.fedorapeople.org/igor/3/igor.spec SRPM URL: http://fabiand.fedorapeople.org/igor/3/igor-0.3.0-3.fc18.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@redhat.com Assignee|nobody@fedoraproject.org |mrunge@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? | Flags| |fedora-review+
--- Comment #4 from Matthias Runge mrunge@redhat.com --- Package Review ==============
Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/947861-igor/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 1 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment).
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [!]: Spec use %global instead of %define. Note: %define gitorious_name ovirt-igord [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: igor-0.3.0-3.fc20.noarch.rpm igor.noarch: W: spelling-error %description -l en_US libvirt -> liberty igor.noarch: W: spelling-error %description -l en_US oVirt -> overt igor.noarch: W: no-manual-page-for-binary igord 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint igor igor.noarch: W: spelling-error %description -l en_US libvirt -> liberty igor.noarch: W: spelling-error %description -l en_US oVirt -> overt igor.noarch: W: no-manual-page-for-binary igord 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:'
Requires -------- igor (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/python config(igor) python(abi) systemd
Provides -------- igor: config(igor) igor
Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64
Issues: - please use %global instead of %define - please submit a (non-empty) license file
Both can be included during initial import, so
PACKAGE APPROVED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Fabian Deutsch fdeutsch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ | Flags| |fedora-review?
--- Comment #5 from Fabian Deutsch fdeutsch@redhat.com --- New Package SCM Request ======================= Package Name: igor Short Description: Automated distribution life-cycle testing Owners: fabiand Branches: f17 f18 f19 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Fabian Deutsch fabian.deutsch@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian.deutsch@gmx.de Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Fabian Deutsch fabian.deutsch@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Fabian Deutsch fabian.deutsch@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-cvs+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947861
Fabian Deutsch fdeutsch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-04-05 03:11:50
--- Comment #7 from Fabian Deutsch fdeutsch@redhat.com --- Thanks Matthias an Jon. Bugzilla component is added and package is imported, so closing this now.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla