[Bug 476483] New: Review Request: ghc-paths - library for information about ghc paths - package-review

List overview All Threads
Download

newer

[Bug 476483] New: Review Request: ghc-paths - library for information about ghc paths

older

[Bug 474391] New: Review Request:...

[Bug 466147] New: Review...

Red Hat Bugzilla

14 Dec 2008 14 Dec '08

10:31 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: ghc-paths - library for information about ghc paths

https://bugzilla.redhat.com/show_bug.cgi?id=476483

Summary: Review Request: ghc-paths - library for information about ghc paths Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: petersen@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

Spec URL: http://petersen.fedorapeople.org/ghc-paths/ghc-paths.spec SRPM URL: http://petersen.fedorapeople.org/ghc-paths/ghc-paths-0.1.0.5-1.fc10.src.rpm Description: Knowledge of GHC's installation directories.

Needed by recent haddock to build.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

14 Dec 14 Dec

10:32 p.m.

New subject: [Bug 476483] Review Request: ghc-paths - library for information about ghc paths

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476483

Jens Petersen petersen@redhat.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:32 p.m.

New subject: [Bug 476483] Review Request: ghc-paths - library for information about ghc paths

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476483

Jens Petersen petersen@redhat.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Dec 15 Dec

6:02 p.m.

New subject: [Bug 476483] Review Request: ghc-paths - library for information about ghc paths

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476483

Jason Tibbitts tibbs@math.uh.edu changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

16 Dec 16 Dec

5:42 p.m.

New subject: [Bug 476483] Review Request: ghc-paths - library for information about ghc paths

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476483

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #1 from Jason Tibbitts tibbs@math.uh.edu 2008-12-16 20:42:23 EDT --- Builds fine; rpmlint says: ghc-paths-prof.x86_64: W: no-documentation which is true, and not a problem.

ghc-paths.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.10.1/ghc-paths-0.1.0.5/libHSghc-paths-0.1.0.5.a ghc-paths-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.10.1/ghc-paths-0.1.0.5/libHSghc-paths-0.1.0.5_p.a which are normal for Haskell packages.

The only real complaint I have is that the module description doesn't make a whole lot of sense. I guess it must make sense if you understand Haskell (which I don't); that's not really unheard of when it comes to specialized modules for various languages, so I'm not going to worry about it. Maybe you can think of something more sensible.

* source files match upstream. sha256sum: ea9e97425894e3dbd7915e00e107e2e7fc07b6e8293fd2dd66a813f0673cba10 ghc-paths-0.1.0.5.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: ghc-paths-0.1.0.5-1.fc11.x86_64.rpm ghc-paths-devel = 0.1.0.5-1.fc11 ghc-paths = 0.1.0.5-1.fc11 ghc-paths(x86-64) = 0.1.0.5-1.fc11 = /bin/sh ghc = 6.10.1

ghc-paths-prof-0.1.0.5-1.fc11.x86_64.rpm ghc-paths-prof = 0.1.0.5-1.fc11 ghc-paths-prof(x86-64) = 0.1.0.5-1.fc11 = ghc-paths = 0.1.0.5-1.fc11 ghc-prof = 6.10.1

* owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * scriptlets OK (ghc package registration and documentation indexing) * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

21 Dec 21 Dec

9:38 p.m.

New subject: [Bug 476483] Review Request: ghc-paths - library for information about ghc paths

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476483

Jens Petersen petersen@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #2 from Jens Petersen petersen@redhat.com 2008-12-22 00:38:48 EDT --- Thanks for the review. :) I will improvement the description of the package when importing.

New Package CVS Request ======================= Package Name: ghc-paths Short Description: Interface to ghc's install directories Owners: petersen Branches: F-10 InitialCC: haskell-sig

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Dec 22 Dec

5:33 p.m.

New subject: [Bug 476483] Review Request: ghc-paths - library for information about ghc paths

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476483

Jens Petersen petersen@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #3 from Jens Petersen petersen@redhat.com 2008-12-22 20:33:40 EDT --- cvs admin done

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:55 p.m.

New subject: [Bug 476483] Review Request: ghc-paths - library for information about ghc paths

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476483

Jens Petersen petersen@redhat.com changed:

--- Comment #4 from Jens Petersen petersen@redhat.com 2008-12-22 20:55:17 EDT --- Package imported and built ghc-paths-0.1.0.5-2.fc11.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8 Mar 8 Mar

7:59 p.m.

New subject: [Bug 476483] Review Request: ghc-paths - library for information about ghc paths (renamed to ghc-ghc-paths)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476483

Jens Petersen petersen@redhat.com changed:

--- Comment #5 from Jens Petersen petersen@redhat.com 2009-03-08 22:59:28 EDT --- My "bad" but this package should be renamed to ghc-ghc-paths since the Haskell library itself is called ghc-paths. Renaming will keep cabal2spec-diff happy and make it easier to keep the package in sync with the templates.

New Package CVS Request ======================= Package Name: ghc-ghc-paths Short Description: Interface to ghc's install directories Owners: petersen Branches: F-10 InitialCC: haskell-sig

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:12 p.m.

New subject: [Bug 476483] Review Request: ghc-paths - library for information about ghc paths (renamed to ghc-ghc-paths)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476483

--- Comment #6 from Jens Petersen petersen@redhat.com 2009-03-08 23:12:47 EDT --- cvs done

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5590

Age (days ago)

5674

Last active (days ago)

package-review@lists.fedoraproject.org

9 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla