[Bug 251825] New: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251825
Summary: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/maniadrive-data.spec SRPM URL: http://people.atrpms.net/~hdegoede/maniadrive-data-1.2-1.fc8.src.rpm Description: Data files for maniadrive, a 3D stunt driving game. Notice this package does not include the original ManiaDrive soundtrack as the original soundtrack is licensed under a CC BY-NC-SA license, which is not acceptable to Fedora.
---
maniadrive's review is bug 251824
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game
https://bugzilla.redhat.com/show_bug.cgi?id=251825
packages@amiga-hardware.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |packages@amiga-hardware.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game
https://bugzilla.redhat.com/show_bug.cgi?id=251825
------- Additional Comments From packages@amiga-hardware.com 2007-08-28 15:41 EST ------- * rpmlint: Ok
W: maniadrive-data dangling-relative-symlink /usr/share/maniadrive/rayphp ../raydium/rayphp The relative symbolic link points nowhere.
I believe this is OK and points to a file in the main maniadrive package but will check when I review that also.
* Package named correctly: Yes * Patches named correctly: Yes * Spec file named correctly: Yes * Licence(s) acceptable: Yes * Licence field matches: No (!!!!) see below * Licence file installed: Yes and included upstream * Spec file in American English: Yes * Source matches upstream: N/A (upstream sources are repackaged by necessity) * Locales use %find_lang: N/A * Contains %clean: Yes * %install contain rm -rf %{buildroot} or similar: Yes * Specfile legible: Yes * Compiles and builds ok: Yes (mock devel/i386) * Calls ldconfig in %post/%postun for shlibs: N/A * Owns directories it creates: Yes * Duplicate files: No * Permissions set correctly: Yes * Consistent macro use: Yes * Separate -doc needed (for large docs): N/A * %doc affects runtime: No * Headers and static libs in -devel: N/A * .pc files in -devel: N/A * .so in -devel: N/A * -devel requires base: N/A * Contains .la files: N/A * Owns files it didn't create: No * .desktop files included and installed correctly: N/A * Filenames valid UTF8: Yes
1. The license field says GPLv2+, but I believe it should be GPL+
The README states GPL and the version (as I understand it) stated in COPYING is not sufficient. Unless the GPL version is specified in the source or accompanying documentation then it is GPL+, I couldn't find a reference to that specific version but if there is one, let me know.
2. Not a blocker but I suggest converting README from iso-8859-1 to UTF8.
Otherwise the package seems fine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game
https://bugzilla.redhat.com/show_bug.cgi?id=251825
packages@amiga-hardware.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game
https://bugzilla.redhat.com/show_bug.cgi?id=251825
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-09-01 08:41 EST ------- (In reply to comment #1)
The license field says GPLv2+, but I believe it should be GPL+
Not a blocker but I suggest converting README from iso-8859-1 to UTF8.
Both fixed: Spec URL: http://people.atrpms.net/~hdegoede/maniadrive-data.spec SRPM URL: http://people.atrpms.net/~hdegoede/maniadrive-data-1.2-2.fc8.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game
https://bugzilla.redhat.com/show_bug.cgi?id=251825
packages@amiga-hardware.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From packages@amiga-hardware.com 2007-09-02 12:10 EST ------- Looks good, package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game
https://bugzilla.redhat.com/show_bug.cgi?id=251825
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-09-02 13:11 EST ------- New Package CVS Request ======================= Package Name: maniadrive-data Short Description: Data files for maniadrive, a 3D stunt driving game Owners: jwrdegoede Branches: devel only! InitialCC: <empty> Cvsextras Commits: yes
Yes, really devel only, this depends on other packages only in rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game
https://bugzilla.redhat.com/show_bug.cgi?id=251825
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-09-03 14:26 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: maniadrive-data - Data files for maniadrive, a 3D stunt driving game
https://bugzilla.redhat.com/show_bug.cgi?id=251825
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-09-03 15:34 EST ------- Imported and build, closing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla