https://bugzilla.redhat.com/show_bug.cgi?id=1539189
Bug ID: 1539189 Summary: Review Request: golang-github-zyedidia-pty - PTY interface for Go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/c26bae0/golang-github-z... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/micro/fedora-rawhid...
Description: Pty is a Go package for using unix pseudo-terminals.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1539190
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 [Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- So how is this different from the existing golang-github-kr-pty, which appears to still be under development and not dead?
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Sadly it's a fork with custom modifications. Dev did that for a handful of packages without upstreaming their changes.
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
--- Comment #3 from Elliott Sales de Andrade quantum.analyst@gmail.com --- There's only really one significant commit; maybe you can try to convince the dev to send the changes upstream?
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- I already asked for two previous packages, the dev doesn't want to upstream is custom mod, says it would slow done the dev of his app.
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jsmith.fedora@gmail.com Assignee|nobody@fedoraproject.org |jsmith.fedora@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Assignee|jsmith.fedora@gmail.com |zebob.m@gmail.com Flags|fedora-review? |fedora-review+
--- Comment #5 from Jared Smith jsmith.fedora@gmail.com --- Package is APPROVED.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 31 files have unknown license. Detailed output of licensecheck in /home/jsmith/Documents/Fedora/Reviews/1539189-golang-github-zyedidia- pty/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com/zyedidia(golang-github-zyedidia- tcell-devel, golang-github-zyedidia-poller-devel, golang-github- zyedidia-clipboard-devel, golang-github-zyedidia-glob-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-zyedidia-pty-devel-0-0.1.20180126git3036466.fc28.noarch.rpm golang-github-zyedidia-pty-0-0.1.20180126git3036466.fc28.src.rpm golang-github-zyedidia-pty.src: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory golang-github-zyedidia-pty-devel.noarch: W: invalid-url URL: https://github.com/zyedidia/pty <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires -------- golang-github-zyedidia-pty-devel (rpmlib, GLIBC filtered):
Provides -------- golang-github-zyedidia-pty-devel: golang(github.com/zyedidia/pty) golang-github-zyedidia-pty-devel
Source checksums ---------------- https://github.com/zyedidia/pty/archive/30364665a2445782b12bcb2db75f16ce684d... : CHECKSUM(SHA256) this package : b7f03f507b87aa9bf3503640c52313e3c9569e26531291ec45ba1feecfabe9f2 CHECKSUM(SHA256) upstream package : b7f03f507b87aa9bf3503640c52313e3c9569e26531291ec45ba1feecfabe9f2
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1539189 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|zebob.m@gmail.com |jsmith.fedora@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-zyedidia-pty
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-zyedidia-pty-0-0.1.20180126git3036466.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9bd59bc220
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-zyedidia-pty-0-0.1.20180126git3036466.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9bd59bc220
https://bugzilla.redhat.com/show_bug.cgi?id=1539189
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-03-06 12:20:31
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-zyedidia-pty-0-0.1.20180126git3036466.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com