https://bugzilla.redhat.com/show_bug.cgi?id=1807981
Bug ID: 1807981 Summary: Review Request: dnstwist - domain name permutation engine Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@svgames.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://svgames.pl/fedora/dnstwist-20190706-1.spec srpm: https://svgames.pl/fedora/dnstwist-20190706-1.src.rpm
Description: A tool for finding similar-looking domains that adversaries can use to attack you.
Fedora Account System Username: suve
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
Artur Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1807979, 1807967 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1807967 [Bug 1807967] Review Request: python-ssdeep - Python bindings for the ssdeep library https://bugzilla.redhat.com/show_bug.cgi?id=1807979 [Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807981 Bug 1807981 depends on bug 1807979, which changed state.
Bug 1807979 Summary: Review Request: python-whois - Python package for retrieving WHOIS information https://bugzilla.redhat.com/show_bug.cgi?id=1807979
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - You're missing the URL: field
- Use install -p to keep timestamps
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Mozilla Public License 2.0". 12 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/dnstwist/review-dnstwist/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: dnstwist-20190706-1.fc33.noarch.rpm dnstwist-20190706-1.fc33.src.rpm dnstwist.noarch: W: spelling-error %description -l en_US typosquatters -> typo squatters, typo-squatters, typesetters dnstwist.noarch: W: no-url-tag dnstwist.noarch: W: no-manual-page-for-binary dnstwist dnstwist.src: W: spelling-error %description -l en_US typosquatters -> typo squatters, typo-squatters, typesetters dnstwist.src: W: no-url-tag 2 packages and 0 specfiles checked; 0 errors, 5 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
--- Comment #2 from Artur Iwicki fedora@svgames.pl --- Ha, I've spotted both of those myself, but since I had to wait for the dependencies to get approved, I decided to wait.
Either way, python-ssdeep got approved yesterday, so here's the updated spec and a scratch koji rawhide build: spec: https://svgames.pl/fedora/dnstwist-20190706-2.spec srpm: https://svgames.pl/fedora/dnstwist-20190706-2.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=42665292
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@fabian-affolter.ch Blocks| |563471 (FE-SECLAB)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
--- Comment #4 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dnstwist
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-f84bece2f8 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f84bece2f8
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-7dd206f3a6 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7dd206f3a6
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-7dd206f3a6 has been pushed to the Fedora 30 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-7dd206f3a6 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7dd206f3a6
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-f84bece2f8 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f84bece2f8 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f84bece2f8
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-87f92246ff has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-87f92246ff *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-87f92246ff
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1807981 Bug 1807981 depends on bug 1807967, which changed state.
Bug 1807967 Summary: Review Request: python-ssdeep - Python bindings for the ssdeep library https://bugzilla.redhat.com/show_bug.cgi?id=1807967
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-04-04 00:45:03
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-f84bece2f8 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-87f92246ff has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-7dd206f3a6 has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1807981
--- Comment #13 from Artur Frenszek-Iwicki fedora@svgames.pl --- *** Bug 1910983 has been marked as a duplicate of this bug. ***
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com