[Bug 1775859] New: Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Bug ID: 1775859
           Summary: Review Request: kakoune - Code editor heavily inspired
                    by Vim
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/atim/kakoune/fedora-31-x86_6...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/atim/kakoune/fedora-31-x86_6...

Description:
- Modal editor
- Faster as in fewer keystrokes 
- Multiple selections
- Orthogonal design

Kakoune is a code editor that implements Vi’s "keystrokes as a text editing
language" model. As it’s also a modal editor, it is somewhat similar to the Vim
editor (after which Kakoune was originally inspired).

Fedora Account System Username: atim

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Artem  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Artem  ---
https://copr-be.cloud.fedoraproject.org/results/atim/kakoune/fedora-31-x86_6...

https://copr-be.cloud.fedoraproject.org/results/atim/kakoune/fedora-31-x86_6...

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

--- Comment #2 from Artem  ---
https://copr-be.cloud.fedoraproject.org/results/atim/kakoune/fedora-31-x86_6...

https://copr-be.cloud.fedoraproject.org/results/atim/kakoune/fedora-31-x86_6...

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

--- Comment #3 from Artem  ---
https://copr-be.cloud.fedoraproject.org/results/atim/kakoune/fedora-31-x86_6...

https://copr-be.cloud.fedoraproject.org/results/atim/kakoune/fedora-31-x86_6...

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Vasiliy Glazov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

--- Comment #4 from Vasiliy Glazov  ---
You should enable default build flags. And found flags that cause tests to
fail. Only they should be disabled if it is possible (not secure breach).

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Vasiliy Glazov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #5 from Vasiliy Glazov  ---
Approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Unknown or generated". 1 files have
     unknown license. Detailed output of licensecheck in
     /home/vascom/1775859-kakoune/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: kakoune-2019.07.01-4.fc32.x86_64.rpm
          kakoune-debuginfo-2019.07.01-4.fc32.x86_64.rpm
          kakoune-debugsource-2019.07.01-4.fc32.x86_64.rpm
          kakoune-2019.07.01-4.fc32.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (debuginfo)
-------------------
Checking: kakoune-debuginfo-2019.07.01-4.fc32.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
----------------------------
kakoune-debuginfo.x86_64: W: invalid-url URL: https://kakoune.org/ <urlopen
error [Errno -2] Name or service not known>
kakoune-debugsource.x86_64: W: invalid-url URL: https://kakoune.org/ <urlopen
error [Errno -2] Name or service not known>
kakoune.x86_64: W: invalid-url URL: https://kakoune.org/ <urlopen error [Errno
-2] Name or service not known>
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Source checksums
----------------
https://github.com/mawww/kakoune/archive/v2019.07.01/kakoune-2019.07.01.tar....
:
  CHECKSUM(SHA256) this package     :
af4a165b329e0138e0e258f47cf1598fc2f6c63f8fe3f8dc7827f2196a02f9b5
  CHECKSUM(SHA256) upstream package :
af4a165b329e0138e0e258f47cf1598fc2f6c63f8fe3f8dc7827f2196a02f9b5

Requires
--------
kakoune (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libncursesw.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libtinfo.so.6()(64bit)
    rtld(GNU_HASH)

kakoune-debuginfo (rpmlib, GLIBC filtered):

kakoune-debugsource (rpmlib, GLIBC filtered):

Provides
--------
kakoune:
    kakoune
    kakoune(x86-64)

kakoune-debuginfo:
    debuginfo(build-id)
    kakoune-debuginfo
    kakoune-debuginfo(x86-64)

kakoune-debugsource:
    kakoune-debugsource
    kakoune-debugsource(x86-64)

Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18
Command line :/usr/bin/fedora-review -b 1775859
Buildroot used: fedora-rawhide-{{ target_arch }}
Active plugins: Generic, Shell-api
Disabled plugins: Java, R, Ocaml, PHP, Python, SugarActivity, C/C++, fonts,
Perl, Haskell
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/kakoune

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Ben Cotton  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |EOL
        Last Closed|                            |2019-11-27 14:16:56

--- Comment #7 from Ben Cotton  ---
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Artem  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |POST
                 CC|                            |[e-mail]
         Resolution|EOL                         |---
              Flags|                            |needinfo?([e-mail]
                   |                            |m)
           Keywords|                            |Reopened

--- Comment #8 from Artem  ---
This is a bug. This is new package and review package. I didn't request repo
for F29.

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Ben Cotton  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Reopened                    |
                 CC|[e-mail]          |
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #9 from Ben Cotton  ---
This bug was accidentally closed due to a query error. Reopening.

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #10 from Fedora Update System  ---
FEDORA-2019-8836948189 has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-8836948189

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

--- Comment #11 from Fedora Update System  ---
FEDORA-2019-e0134fff7d has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-e0134fff7d

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #12 from Fedora Update System  ---
kakoune-2019.07.01-4.fc30 has been pushed to the Fedora 30 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-e0134fff7d

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

--- Comment #13 from Fedora Update System  ---
kakoune-2019.07.01-4.fc31 has been pushed to the Fedora 31 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-8836948189

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|2019-11-27 14:16:56         |2019-11-30 00:56:37

--- Comment #14 from Fedora Update System  ---
kakoune-2019.07.01-4.fc31 has been pushed to the Fedora 31 stable repository.
If problems still persist, please make note of it in this bug report.

[Bug 1775859] Review Request: kakoune - Code editor heavily inspired by Vim

https://bugzilla.redhat.com/show_bug.cgi?id=1775859

--- Comment #15 from Fedora Update System  ---
kakoune-2019.07.01-4.fc30 has been pushed to the Fedora 30 stable repository.
If problems still persist, please make note of it in this bug report.