[Bug 1766771] New: Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

Bug ID: 1766771
           Summary: Review Request: libicu64 - ICU Library version 64
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://sgallagh.fedorapeople.org/packagereview/libicu64/libicu64.spec
SRPM URL:
https://sgallagh.fedorapeople.org/packagereview/libicu64/libicu64-64.2-0.fc3...
Description: ICU Library version 64 
Fedora Account System Username: sgallagh

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
             Blocks|                            |1755114

--- Comment #1 from Stephen Gallagher  ---
Needed to have i18n support in Node.js 12.x

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1755114
[Bug 1755114] nodejs is built without internationalization support

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

--- Comment #2 from Stephen Gallagher  ---
Scratch build at https://koji.fedoraproject.org/koji/taskinfo?taskID=38650383
is failing on s390x (big endian problems, it seems). I'll see if I can debug
that. It's building fine on little-endian platforms.

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Stephen Gallagher  ---
Spec URL:
https://sgallagh.fedorapeople.org/packagereview/libicu64/libicu64.spec
SRPM URL:
https://sgallagh.fedorapeople.org/packagereview/libicu64/libicu64-64.2-0.fc3...
Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38661704

Turns out that it wasn't an endianness issue. The s390x build for some reason
didn't create a source/data/out directory before trying to write files into it.
I couldn't figure out the origin of the problem in the complicated Makefile
environment, so I just pre-created the missing directories in the specfile to
work around it. Seems to be building successfully now.

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Miro Hrončok  ---
BuildRequires: python2

:scream:

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

--- Comment #5 from Stephen Gallagher  ---
(In reply to Miro Hrončok from comment #4)
> BuildRequires: python2
>
> :scream:

Oops, I actually didn't notice that. I copied the spec originally from
https://src.fedoraproject.org/rpms/compat-libicu62/blob/f30/f/compat-libicu6...
and didn't notice the python2 BR.

I'm checking to see whether it's actually required or if it can work with py3
right now.

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

--- Comment #6 from Stephen Gallagher  ---
Spec URL:
https://sgallagh.fedorapeople.org/packagereview/libicu64/libicu64.spec
SRPM URL:
https://sgallagh.fedorapeople.org/packagereview/libicu64/libicu64-64.2-0.fc3...

OK, good news. It does not in fact actually need Python 2. The build tools work
with python3 just fine.

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

--- Comment #8 from Pete Walter  ---
Hi Stephen,

Does nodejs need exactly libicu 64, or does it work with newer libicu 65 that
just landed in rawhide?

If it needs exactly libicu 64, maybe a better solution would be to bundle it in
nodejs?

Thanks,
Pete

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

--- Comment #9 from Stephen Gallagher  ---
(In reply to Pete Walter from comment #8)
> Hi Stephen,
>
> Does nodejs need exactly libicu 64, or does it work with newer libicu 65
> that just landed in rawhide?
>
> If it needs exactly libicu 64, maybe a better solution would be to bundle it
> in nodejs?
>
> Thanks,
> Pete

It might work with libicu 65, but I still need to have i18n support for F30 and
F31, so I'd still like to carry this package on at least those releases.

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

Pete Walter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Pete Walter  ---
OK, but can you bundle libicu 64 in nodejs and install it to a private dir
under /usr/lib64 that is only available for nodejs? This seems like a perfect
opportunity for bundling.

I'd rather not have two libicu versions available in Fedora that packages can
link to (there is no symbol versioning in libicu so you can't load two
different versions at runtime into the same process afaik).

Adding Eike to CC as well.

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

--- Comment #11 from Stephen Gallagher  ---
I *can* bundle it privately (fairly easily, in fact; the Node.js build-system
can statically link it in). However, libicu is *large*. I figured it made more
sense to provide the compat library on the system in case there are any other
packages out there that need something newer that 62 to run and were therefore
unavailable on Fedora.

Having each package that needs it bundle an extra 70MiB of unicode data seems
pretty excessive.

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

--- Comment #12 from Pete Walter  ---
Right, but that's exactly what I want to avoid -- I do not want to provide
another version of libicu for other packages to link against as that can lead
to symbol conflicts. Please just do the private bundling here.

[Bug 1766771] Review Request: libicu64 - ICU Library version 64

https://bugzilla.redhat.com/show_bug.cgi?id=1766771

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|                            |2019-11-06 20:06:05

--- Comment #13 from Stephen Gallagher  ---
Abandoning this package.