https://bugzilla.redhat.com/show_bug.cgi?id=1444819
Bug ID: 1444819 Summary: Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: morphis@gravedo.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1.spec SRPM URL: https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1-1-1.2.15.git4654...
Description:
This packages the golang package gopkg.in/retry.v1 which enables graceful shutdown of http.Handler servers.
Fedora Account System Username: mrmorph
https://bugzilla.redhat.com/show_bug.cgi?id=1444819
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1444819
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- This package looks like it has remnants of gopkg.in/retry.v1 in it, please clean up and make sure that everything is sane.
https://bugzilla.redhat.com/show_bug.cgi?id=1444819
--- Comment #3 from Simon Fels morphis@gravedo.de --- @Neil: Fixed those.
https://bugzilla.redhat.com/show_bug.cgi?id=1444819
--- Comment #4 from Neal Gompa ngompa13@gmail.com ---
Summary: Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers
This is too long. Shorten it to < 75 chars wide.
%description %{summary}
Add a period after %{summary}.
Provides: golang(%{import_path}) = %{version}-%{release} Provides: golang(%{import_path_sec}) = %{version}-%{release} Provides: golang(%{mimport_path}) = %{version}-%{release} Provides: golang(%{gimport_path}) = %{version}-%{release}
Some of these import paths are undefined, and the install steps where these are referenced are broken because of it.
https://bugzilla.redhat.com/show_bug.cgi?id=1444819
--- Comment #5 from Simon Fels morphis@gravedo.de --- @Neil: Updated the .spec and .src.rpm linked above.
package-review@lists.fedoraproject.org