[Bug 1444819] New: Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

https://bugzilla.redhat.com/show_bug.cgi?id=1444819

Bug ID: 1444819
           Summary: Review Request: golang-gopkg-tylerb-graceful-v1 -
                    Graceful is a Go 1.3+ package enabling graceful
                    shutdown of http.Handler servers
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1.spec
SRPM URL:
https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1-1-1.2.15.git4654...

Description:

This packages the golang package gopkg.in/retry.v1 which enables graceful
shutdown of http.Handler servers.

Fedora Account System Username: mrmorph

[Bug 1444819] Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

https://bugzilla.redhat.com/show_bug.cgi?id=1444819

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Neal Gompa  ---
Taking this review.

[Bug 1444819] Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

https://bugzilla.redhat.com/show_bug.cgi?id=1444819

--- Comment #2 from Neal Gompa  ---
This package looks like it has remnants of gopkg.in/retry.v1 in it, please
clean up and make sure that everything is sane.

[Bug 1444819] Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

https://bugzilla.redhat.com/show_bug.cgi?id=1444819

--- Comment #3 from Simon Fels  ---
@Neil: Fixed those.

[Bug 1444819] Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

https://bugzilla.redhat.com/show_bug.cgi?id=1444819

--- Comment #4 from Neal Gompa  ---
> Summary:        Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

This is too long. Shorten it to < 75 chars wide.
> %description
> %{summary}

Add a period after %{summary}.
> Provides:      golang(%{import_path}) = %{version}-%{release}
> Provides:      golang(%{import_path_sec}) = %{version}-%{release}
> Provides:      golang(%{mimport_path}) = %{version}-%{release}
> Provides:      golang(%{gimport_path}) = %{version}-%{release}

Some of these import paths are undefined, and the install steps where these are
referenced are broken because of it.

[Bug 1444819] Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

https://bugzilla.redhat.com/show_bug.cgi?id=1444819

--- Comment #5 from Simon Fels  ---
@Neil: Updated the .spec and .src.rpm linked above.