[Bug 1433658] New: Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

Bug ID: 1433658
           Summary: Review Request: mustache-d - Mustache template engine
                    for D
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://kinginuyasha.enanocms.org/downloads/mustache-d.spec
SRPM URL:
http://kinginuyasha.enanocms.org/downloads/mustache-d-0.1.3-1.fc25.src.rpm

Description:
Mustache is a push-strategy (a.k.a logic-less) template engine.

This package provides the implementation for D.

Fedora Account System Username: ngompa

[Bug 1433658] Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

--- Comment #1 from Neal Gompa  ---
For reviewers: The lack of a license file is known, and I've filed an issue
upstream to have it added: https://github.com/repeatedly/mustache-d/issues/30

[Bug 1433658] Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

--- Comment #2 from Neal Gompa  ---
I've pulled in a copy of the license file as an additional source, due to
license terms, using the exact URL referenced in the mustache.d source file:
https://github.com/repeatedly/mustache-d/blob/master/src/mustache.d#L7

[Bug 1433658] Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

--- Comment #3 from Neal Gompa  ---
As a note, this is temporary and I don't expect to pull in the license file
separately, as I hope upstream will resolve this problem.

[Bug 1433658] Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #4 from Tom "spot" Callaway  ---
Mustfix (before commit):

* Do not "mv" %{SOURCE} files. cp -a. :)
* There is a typo in the devel %description, "teimplate".

Good:

- rpmlint checks return:
mustache-d-devel.x86_64: W: spelling-error %description -l en_US teimplate ->
template, implicate
- package meets naming guidelines
- package meets packaging guidelines
- license (Boost) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(b8cf5fe193b11dece663ad2d7f8acbcc02ef48334f0fdc922a2dde3f8ac64b57)
- package compiles on F26 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- .a files come with proper static provides

Fix your MUSTFIX items before commit. APPROVED.

[Bug 1433658] Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/mustache-d

[Bug 1433658] Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

--- Comment #6 from Fedora Update System  ---
mustache-d-0.1.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-46e8f80d96

[Bug 1433658] Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 1433658] Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #7 from Fedora Update System  ---
mustache-d-0.1.3-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-46e8f80d96

[Bug 1433658] Review Request: mustache-d - Mustache template engine for D

https://bugzilla.redhat.com/show_bug.cgi?id=1433658

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2017-06-09 15:17:04

--- Comment #8 from Fedora Update System  ---
mustache-d-0.1.3-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.