[Bug 992940] New: Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5 - package-review

List overview All Threads
Download

newer

[Bug 992940] New: Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

older

[Bug 983961] Review Request:...

[Bug 970009] New: Review Request:...

Red Hat Bugzilla

5 Aug 2013 5 Aug '13

4:04 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=992940

Bug ID: 992940 Summary: Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ppisar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org

Spec URL: http://ppisar.fedorapeople.org/perl-Syntax-Keyword-Junction/perl-Syntax-Keyw... SRPM URL: http://ppisar.fedorapeople.org/perl-Syntax-Keyword-Junction/perl-Syntax-Keyw... Description: This is a lightweight module which provides 'Junction' operators, the most commonly used being any and all. Inspired by the Perl6 design docs, http://dev.perl.org/perl6/doc/design/exe/E06.html.

Fedora Account System Username: ppisar

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uge3uwiBmj&a=cc_unsubscribe

Show replies by date

Red Hat Bugzilla

5 Aug 5 Aug

5:44 a.m.

New subject: [Bug 992940] Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

https://bugzilla.redhat.com/show_bug.cgi?id=992940

Petr Pisar ppisar@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |991773

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u867avDWC3&a=cc_unsubscribe

Red Hat Bugzilla

7:23 a.m.

New subject: [Bug 992940] Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

https://bugzilla.redhat.com/show_bug.cgi?id=992940

Jitka Plesnikova jplesnik@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tl80sk4gLn&a=cc_unsubscribe

Red Hat Bugzilla

7:33 a.m.

New subject: [Bug 992940] Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

https://bugzilla.redhat.com/show_bug.cgi?id=992940

--- Comment #1 from Paul Howarth paul@city-fan.org --- rpmlint output:

perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US http -> HTTP perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US dev -> deb, derv, div perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US exe -> ex, exes, exec perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US http -> HTTP perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US dev -> deb, derv, div perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US exe -> ex, exes, exec perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml 2 packages and 0 specfiles checked; 0 errors, 8 warnings.

provides:

perl(Syntax::Feature::Junction) = 0.003004 perl(Syntax::Keyword::Junction) = 0.003004 perl(Syntax::Keyword::Junction::All) = 0.003004 perl(Syntax::Keyword::Junction::Any) = 0.003004 perl(Syntax::Keyword::Junction::Base) = 0.003004 perl(Syntax::Keyword::Junction::None) = 0.003004 perl(Syntax::Keyword::Junction::One) = 0.003004 perl-Syntax-Keyword-Junction = 0.003004-1.fc20

requires:

perl(:MODULE_COMPAT_5.18.0) perl(Sub::Exporter::Progressive) >= 0.001006 perl(Syntax::Keyword::Junction) perl(Syntax::Keyword::Junction::All) perl(Syntax::Keyword::Junction::Any) perl(Syntax::Keyword::Junction::Base) perl(Syntax::Keyword::Junction::None) perl(Syntax::Keyword::Junction::One) perl(base) perl(if) perl(overload) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1

review checklist:

- rpmlint ok; the html and http acronyms could be capitalized but it's no blocker - package and spec naming OK - package meets guidelines - license is (GPL+ or Artistic), same as upstream and OK for Fedora - license text is bundled and packaged - spec file written in English and is legible - source matches upstream - package builds fine in Rawhide - build dependencies fully specified - no locale data to worry about - no libraries to worry about - no bundled code present - package is not intended to be relocatable - directory ownership OK - no duplicate files - permissions OK - macro usage is consistent - package is code, not content - no large docs - docs don't affect runtime - no devel bits to worry about - not a GUI app, no desktop file needed - filenames are all ASCII

Nits:

Should BR: at least version 0.88 of Test::More due to use of done_testing in t/syntax.t

APPROVED.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zaBkFm5jOV&a=cc_unsubscribe

Red Hat Bugzilla

7:54 a.m.

New subject: [Bug 992940] Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

https://bugzilla.redhat.com/show_bug.cgi?id=992940

Jitka Plesnikova jplesnik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+

--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- rpmlint ok License ok Build-requires ok Binary requires ok Binary provides ok Package meets guidelines Source matches upstream Source0 is a working URL Package builds fine %check is present and all tests pass

Package is good.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v9apC5ZkWW&a=cc_unsubscribe

Red Hat Bugzilla

7:56 a.m.

New subject: [Bug 992940] Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

https://bugzilla.redhat.com/show_bug.cgi?id=992940

--- Comment #3 from Petr Pisar ppisar@redhat.com ---

...

Should BR: at least version 0.88 of Test::More due to use of done_testing in t/syntax.t

Indeed. I asked upstream to declare the version too https://github.com/frioux/Syntax-Keyword-Junction/issues/6.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6qusTXld1A&a=cc_unsubscribe

Red Hat Bugzilla

7:57 a.m.

New subject: [Bug 992940] Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

https://bugzilla.redhat.com/show_bug.cgi?id=992940

Petr Pisar ppisar@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #4 from Petr Pisar ppisar@redhat.com --- New Package SCM Request ======================= Package Name: perl-Syntax-Keyword-Junction Short Description: Perl6 style Junction operators in Perl5 Owners: ppisar jplesnik psabata Branches: InitialCC: perl-sig

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UNC0lH7YRu&a=cc_unsubscribe

Red Hat Bugzilla

8:04 a.m.

New subject: [Bug 992940] Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

https://bugzilla.redhat.com/show_bug.cgi?id=992940

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZuKekFrqV3&a=cc_unsubscribe

Red Hat Bugzilla

8:04 a.m.

New subject: [Bug 992940] Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

https://bugzilla.redhat.com/show_bug.cgi?id=992940

--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0clcrjQ1yu&a=cc_unsubscribe

Red Hat Bugzilla

8:24 a.m.

New subject: [Bug 992940] Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5

https://bugzilla.redhat.com/show_bug.cgi?id=992940

Petr Pisar ppisar@redhat.com changed:

--- Comment #6 from Petr Pisar ppisar@redhat.com --- Thank you for the reviews and the repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mNrnXcjxZ0&a=cc_unsubscribe

4370

Age (days ago)

4370

Last active (days ago)

package-review@lists.fedoraproject.org

9 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla