[Bug 675726] New: Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: cdm - Very minimalistic display manager

https://bugzilla.redhat.com/show_bug.cgi?id=675726

           Summary: Review Request: cdm - Very minimalistic display
                    manager
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: unspecified
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: mihkulemin(a)gmail.com
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


Spec URL: http://landgraf.fedorapeople.org/cdm.spec

SRPM URL:
https://koji.fedoraproject.org/koji/getfile?taskID=2767054&name=cdm-0...

Description: Small login manager. Written in pure bash, CDM has no other
dependencies, yet supports multiple users/sessions and can start virtually any
DE/WM. CDM can replace slim in ultra small environments.

Koji build ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Mikhail Kulemin <mihkulemin(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Pavel Zhukov <pavel(a)zhukoff.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pavel(a)zhukoff.net

--- Comment #1 from Pavel Zhukov <pavel(a)zhukoff.net&gt; 2011-02-07 09:57:08 EST ---
few comments:

-- you should NOT point bash to Requires:
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

-- if you don't plan package for EPEL you should not point BuildRoot and clean
sections; 

-- you SHOULD point full URL to Source (vendor doen't prohibit it)
http://cdm.ghost1227.com/repo/cdm-latest.tar.gz or
http://cdm.ghost1227.com/repo/cdm-0.5.3.tar.gz

-- you SHOULD include README (create it) and COPYING  (license text 
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text) to
your package. You can include CHANGELOG too. 





-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #2 from Mikhail Kulemin <mihkulemin(a)gmail.com&gt; 2011-02-07 10:24:05 EST
---
Fixed 
Is README file neeeded?

New srpm
https://koji.fedoraproject.org/koji/getfile?taskID=2767219&name=cdm-0...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #3 from Mikhail Kulemin <mihkulemin(a)gmail.com&gt; 2011-02-07 10:25:35 EST
---
Created attachment 477430
  --> https://bugzilla.redhat.com/attachment.cgi?id=477430
New spec file for build 2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Peter Lemenkov <lemenkov(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lemenkov(a)gmail.com
         AssignedTo|nobody(a)fedoraproject.org    |lemenkov(a)gmail.com
               Flag|                            |fedora-review?

--- Comment #4 from Peter Lemenkov <lemenkov(a)gmail.com&gt; 2011-02-08 06:28:50 EST ---
I'll review it

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Peter Lemenkov <lemenkov(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |

--- Comment #5 from Peter Lemenkov <lemenkov(a)gmail.com&gt; 2011-02-08 06:39:55 EST ---
Unblocking FE-NEEDSPONSOR - I just sponsored Mikhail.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #6 from Peter Lemenkov <lemenkov(a)gmail.com&gt; 2011-02-08 07:42:53 EST ---
Few notes before review:

* Please, drop commented out lines in the %install section

* Drop the following line as well

install -Dm644 src/xinitrc.skel
$RPM_BUILD_ROOT/%{_docdir}/%{name}-%{version}/xinitrc.example

this file should be installed just as other docs (mark it as %doc in the %files
section).

* The directory %{_datarootdir}/%{name}/ left unowned. Please apply the
following change:

- %{_datarootdir}/%{name}/*
+ %{_datarootdir}/%{name}/

Note - trailing asterisk was removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #7 from Mikhail Kulemin <mihkulemin(a)gmail.com&gt; 2011-02-08 09:12:15 EST
---
Created attachment 477617
  --> https://bugzilla.redhat.com/attachment.cgi?id=477617
New spec v3

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #8 from Mikhail Kulemin <mihkulemin(a)gmail.com&gt; 2011-02-08 09:13:02 EST
---
Fixed

https://koji.fedoraproject.org/koji/getfile?taskID=2784901&name=cdm-0...

spec in attachments

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #9 from Peter Lemenkov <lemenkov(a)gmail.com&gt; 2011-02-08 10:03:53 EST ---
Ok, few more notes:

* xinitrc must be installed into %{_datarootdir}/%{name}/ .
* Missing requires - dialog, xorg-x11-utils, dbus, xorg-x11-xinit
* cdmrc mentions 'awesome' as one of the window managers. Please change it to
some more Fedora-specific.
* Licensing terms are misleading - the LICENSE file contains GPLv3, but the
main script, ./src/cdm, explicitly menions GPLv2+. Please, contact upstream for
clarification.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #10 from Mikhail Kulemin <mihkulemin(a)gmail.com&gt; 2011-02-22 15:08:11 EST
---
Fixed this issues.
Add ConsoleKit in requires list (it is used with dbus)
After discussion license issue was fixed - right license is GPLv2+ and now
upstream sources have correct license text in tarbal.

SRPM URL:
https://koji.fedoraproject.org/koji/getfile?taskID=2857478&name=cdm-0...

spec file in attachment

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Mikhail Kulemin <mihkulemin(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #477430|0                           |1
        is obsolete|                            |
 Attachment #477617|0                           |1
        is obsolete|                            |

--- Comment #11 from Mikhail Kulemin <mihkulemin(a)gmail.com&gt; 2011-02-22 15:09:51 EST
---
Created attachment 480233
  --> https://bugzilla.redhat.com/attachment.cgi?id=480233
spec file v4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Peter Lemenkov <lemenkov(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #12 from Peter Lemenkov <lemenkov(a)gmail.com&gt; 2011-02-24 05:22:44 EST
---
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is NOT silent but all its messages can be omitted in this case:

sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/noarch/cdm-0.5.3-4.fc15.noarch.rpm 
cdm.noarch: W: spelling-error Summary(en_US) minimalistic -> minimalist,
minimalism, materialistic
cdm.noarch: W: spelling-error Summary(en_US) login -> loin, logic, lo gin
cdm.noarch: W: spelling-error %description -l en_US minimalistic -> minimalist,
minimalism, materialistic
cdm.noarch: W: spelling-error %description -l en_US login -> loin, logic, lo
gin
cdm.noarch: W: spelling-error %description -l en_US kdm -> km, Adm, Kim
cdm.noarch: W: spelling-error %description -l en_US gdm -> gm, gem, gum
cdm.noarch: W: spelling-error %description -l en_US qingy -> dingy, mingy,
zingy

^^^ False positive.

cdm.noarch: W: non-conffile-in-etc /etc/profile.d/zzz-cdm-profile.sh

^^^ That's ok - this file is not intented to be changed by end-=user.

cdm.noarch: W: no-manual-page-for-binary cdm

^^^ Unfortunately this binary doesn't have corresponding man-page. So no luck
for us here too.

1 packages and 0 specfiles checked; 0 errors, 9 warnings.
sulaco ~/rpmbuild/SPECS:

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (GPLv2
or later).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.

sulaco ~/rpmbuild/SOURCES: sha256sum cdm-0.5.3.tar.gz*
fb9ada13d3416305828c99943698fe7df3b0ab91bd6099e7b2707e1d8dd99a23 
cdm-0.5.3.tar.gz
fb9ada13d3416305828c99943698fe7df3b0ab91bd6099e7b2707e1d8dd99a23 
cdm-0.5.3.tar.gz.1
sulaco ~/rpmbuild/SOURCES:

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Apparently, this packages is a GUI application, but we don't need a *.desktop
file for starting it from other desktops.it. It is a desktop itself.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.

Ok, I can't find any other issues, so this package is

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Mikhail Kulemin <mihkulemin(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #13 from Mikhail Kulemin <mihkulemin(a)gmail.com&gt; 2011-02-24 06:13:06 EST
---
New Package SCM Request
=======================
Package Name: cdm
Short Description: Very minimalistic login manager
Owners: mkulemin
Branches: f14 f15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Mikhail Kulemin <mihkulemin(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #14 from Jason Tibbitts <tibbs(a)math.uh.edu&gt; 2011-02-24 13:28:35 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #15 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-02-25
04:54:59 EST ---
cdm-0.5.3-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/cdm-0.5.3-4.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #16 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-02-25
05:03:33 EST ---
cdm-0.5.3-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/cdm-0.5.3-4.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Mikhail Kulemin <mihkulemin(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|                            |NEXTRELEASE
        Last Closed|                            |2011-02-25 07:03:04

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #17 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-03-02
21:54:53 EST ---
cdm-0.5.3-4.fc15 has been pushed to the Fedora 15 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

--- Comment #18 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-03-05
17:59:19 EST ---
cdm-0.5.3-4.fc14 has been pushed to the Fedora 14 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 675726] Review Request: cdm - Very minimalistic display manager

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675726

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |cdm-0.5.3-4.fc14
         Resolution|NEXTRELEASE                 |ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.