[Bug 1178940] New: Review Request: libqhyccd - Library to control QHY CCD devices - package-review

List overview All Threads
Download

newer

[Bug 1178940] New: Review Request: libqhyccd - Library to control QHY CCD devices

older

[Bug 875087] New: Review Request:...

[Bug 1178687] New: Review Request:...

Red Hat Bugzilla

5 Jan 2015 5 Jan '15

11:14 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

Bug ID: 1178940 Summary: Review Request: libqhyccd - Library to control QHY CCD devices Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lupinix@mailbox.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://lupinix.fedorapeople.org/review/libqhyccd/libqhyccd.spec SRPM URL: https://lupinix.fedorapeople.org/review/libqhyccd/libqhyccd-0.1-0.1.20150105... Description: Library to control QHY CCD devices Fedora Account System Username: lupinix

Known issues: * Firmware uses a nonfree license, I will add the review to legal tracker. License looks similar to linux-firmware licenses. We have to wait for legal approvement. * Most source files use wrong FSF address, reported upstream * No copy of GPLv2 in upstream repo, reported upstream

Thanks for review in advance!

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

5 Jan 5 Jan

11:16 a.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

Christian Dersch lupinix@mailbox.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:18 a.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

Christian Dersch lupinix@mailbox.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1159999 (Astronomy-SIG)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1159999 [Bug 1159999] Astronomy SIG - review tracker

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:09 p.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

Tom "spot" Callaway tcallawa@redhat.com changed:

--- Comment #1 from Tom "spot" Callaway tcallawa@redhat.com --- Firmware license is okay. Lifting FE-Legal.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6 Jan 6 Jan

3:49 p.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

--- Comment #2 from Christian Dersch lupinix@mailbox.org --- Thank you for checking the license Tom!

Koji builds: Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8543609 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=8543622 F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=8543616

Patch for library path submitted upstream: http://sourceforge.net/p/indi/bugs/58/

Missing GPLv2 copy and wrong FSF address: http://sourceforge.net/p/indi/bugs/59/

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

23 Jan 23 Jan

11:26 a.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

Wolfgang Ulbrich chat-to-me@raveit.de changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

24 Jan 24 Jan

6:25 a.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

--- Comment #3 from Wolfgang Ulbrich chat-to-me@raveit.de --- there are some rpmlint warning which can be fixed.

libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_videostab.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_ts.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_superres.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_stitching.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_photo.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_ocl.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_legacy.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_contrib.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_calib3d.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_video.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_objdetect.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_ml.so.2.4 libqhyccd.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqhyccd.so.0 /lib64/libopencv_features2d.so.2.4

https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dep...

source macro doesn't match. Source0: %{name}-%{version}.svn%{svn}.tar.xz

libqhyccd.src: W: invalid-url Source0: libqhyccd-0.1.svn1920.tar.xz

If there isn't a valid link to svn source at sourceforge, pls upload it to your fedora people account and mentioned it in spec file.

I'm not shure how we handle the missing COPYING file. The rest looks good.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:39 a.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

--- Comment #4 from Wolfgang Ulbrich chat-to-me@raveit.de --- another one.

qhy-firmware.noarch: W: only-non-binary-in-usr-lib

can you move this to /usr/share ?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:45 a.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

--- Comment #5 from Wolfgang Ulbrich chat-to-me@raveit.de --- Forget about my last comment. Firmware and udev folders are under /usr/share :)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:49 a.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

--- Comment #6 from Wolfgang Ulbrich chat-to-me@raveit.de --- (In reply to Wolfgang Ulbrich from comment #5)

...

Forget about my last comment. Firmware and udev folders are under /usr/share :)

typo, i meant Firmware and udev folders are under /usr/lib

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 Jan 27 Jan

4:43 p.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

Sergio Pascual sergio.pasra@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:43 p.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

Sergio Pascual sergio.pasra@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:45 p.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

--- Comment #7 from Sergio Pascual sergio.pasra@gmail.com --- Ups, sorry for the noise. Wolfgang, could you put fedora-review to "?" ?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

28 Jan 28 Jan

7 a.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

Wolfgang Ulbrich chat-to-me@raveit.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Feb 4 Feb

7:37 a.m.

New subject: [Bug 1178940] Review Request: libqhyccd - Library to control QHY CCD devices

https://bugzilla.redhat.com/show_bug.cgi?id=1178940

Christian Dersch lupinix@mailbox.org changed:

--- Comment #8 from Christian Dersch lupinix@mailbox.org --- Closed for now, I think it is wise to wait some more time due to big changes upstream.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3821

Age (days ago)

3851

Last active (days ago)

package-review@lists.fedoraproject.org

14 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla