[Bug 731000] New: Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: lua-alt-getopt - Argument processing module for Lua

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Summary: Review Request: lua-alt-getopt - Argument processing
                    module for Lua
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---

Spec URL: http://salimma.fedorapeople.org/specs/funpl/lua-alt-getopt.spec
SRPM URL:
http://salimma.fedorapeople.org/specs/funpl/lua-alt-getopt-0.7.0-1.fc15.src....
Description:
alt-getopt is a module for Lua programming language for processing
application's arguments the same way BSD/GNU getopt_long(3) functions
do. The main goal is compatibility with SUS "Utility Syntax
Guidelines" guidelines 3-13.

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Michel Alexandre Salim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |731003

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Pavel Alexeev (aka Pahan-Hubbitus)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Pavel Alexeev (aka Pahan-Hubbitus)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus)  2011-09-04 13:31:40 EDT ---
Legend:
+ - Ok.
- - Error.
+/- - It item acceptable, but I strongly recommend enhancement.
= - N/A.

MUST Items
[+] MUST: rpmlint must be run on every package. The output should be posted in
the review.

$ rpmlint *
lua-alt-getopt.spec: W: invalid-url Source0:
http://luaforge.net/frs/download.php/4260/lua-alt-getopt-0.7.0.tar.gz <urlopen
error timed out>
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

Manually source downloaded.

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+/-] MUST: The package must meet the Packaging Guidelines.

"The main goal is compatibility with SUS "Utility Syntax Guidelines" guidelines
3-13."

I'm completely don't understand what it means. May be it need rephrasing? But
I'm not lua programmer, so, it is on your choose.

[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[=] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

$ md5sum lua-alt-getopt-0.7.0.tar.gz lua-alt-getopt-0.7.0.tar.gz.downloaded
f504578b1287ea02759add231b972812  lua-alt-getopt-0.7.0.tar.gz
f504578b1287ea02759add231b972812  lua-alt-getopt-0.7.0.tar.gz.downloaded

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3323503

[=] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[=] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[=] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[=] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[=] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+/-] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.

Please add it if EPEL5 in targets too.

[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).

Please add it if EPEL5 in targets too.

[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).

Please add it if EPEL5 in targets too.

[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[=] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[=] MUST: Header files must be in a -devel package.
[=] MUST: Static libraries must be in a -static package.
[=] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
[=] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[=] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[=] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[=] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[-] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.

Please ask upstream to add license!

[=] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[=] SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity.
[=] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[=] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb.
[=] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.

Summary: Please ask upstream include license file and check description.
In any case it is not stop issue.

Package APPROVED.

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus)  2011-09-04 13:34:06 EDT ---
Forgot mention - package contains test directory. Consider run it in %check
stage.

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Michel Alexandre Salim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #3 from Michel Alexandre Salim  2011-09-08 06:23:06 EDT ---
Thanks! Will ask upstream for license text. Regarding the test suite, 'bmake
test' basically does what you suggested (I could have ran the test suite
manually and drop the bmake dependency, but I'd rather do it as upstream
intended)

New Package SCM Request
=======================
Package Name: lua-alt-getopt
Short Description: Argument processing module for Lua
Owners: salimma
Branches: f14 f15 f16 el6
InitialCC:

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #4 from Jon Ciesla  2011-09-09 08:24:49 EDT ---
Git done (by process-git-requests).

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #5 from Fedora Update System  2011-09-09 18:11:17 EDT ---
lua-alt-getopt-0.7.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/lua-alt-getopt-0.7.0-1.fc14

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #6 from Fedora Update System  2011-09-09 18:11:25 EDT ---
lua-alt-getopt-0.7.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/lua-alt-getopt-0.7.0-1.fc15

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #7 from Fedora Update System  2011-09-09 18:11:33 EDT ---
lua-alt-getopt-0.7.0-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/lua-alt-getopt-0.7.0-1.fc16

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #8 from Fedora Update System  2011-09-09 18:11:41 EDT ---
lua-alt-getopt-0.7.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/lua-alt-getopt-0.7.0-1.el6

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #9 from Fedora Update System  2011-09-10 13:14:04 EDT ---
Package lua-alt-getopt-0.7.0-1.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing lua-alt-getopt-0.7.0-1.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/lua-alt-getopt-0.7.0-1.el6
then log in and leave karma (feedback).

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #10 from Fedora Update System  2011-09-24 23:43:56 EDT ---
lua-alt-getopt-0.7.0-1.fc15 has been pushed to the Fedora 15 stable repository.
 If problems still persist, please make note of it in this bug report.

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |lua-alt-getopt-0.7.0-1.fc15
         Resolution|                            |ERRATA
        Last Closed|                            |2011-09-24 23:44:04

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #11 from Fedora Update System  2011-09-24 23:45:35 EDT ---
lua-alt-getopt-0.7.0-1.fc14 has been pushed to the Fedora 14 stable repository.
 If problems still persist, please make note of it in this bug report.

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|lua-alt-getopt-0.7.0-1.fc15 |lua-alt-getopt-0.7.0-1.fc14

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #12 from Fedora Update System  2011-09-28 23:22:40 EDT ---
lua-alt-getopt-0.7.0-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|lua-alt-getopt-0.7.0-1.fc14 |lua-alt-getopt-0.7.0-1.el6

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #13 from Fedora Update System  2011-09-30 15:46:40 EDT ---
lua-alt-getopt-0.7.0-1.fc16 has been pushed to the Fedora 16 stable repository.
 If problems still persist, please make note of it in this bug report.

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|lua-alt-getopt-0.7.0-1.el6  |lua-alt-getopt-0.7.0-1.fc16

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Thomas Moschny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
              Flags|                            |needinfo?(michel@michel-slm
                   |                            |.name)

--- Comment #14 from Thomas Moschny  ---
alt-getopt is needed by a lua script (lxc-top) within the lxc package (see bug
1131707).

So, could you please add lua-alt-getopt to EPEL7?

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Michel Alexandre Salim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(michel@michel-slm |fedora-cvs?
                   |.name) fedora-cvs+          |

--- Comment #15 from Michel Alexandre Salim  ---
@ Thomas certainly!

Package Change Request
======================
Package Name: lua-alt-getopt
New Branches: epel7
Owners: salimma

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=731000

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #16 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 731000] Review Request: lua-alt-getopt - Argument processing module for Lua

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=731000

--- Comment #17 from Michel Alexandre Salim  ---
Thanks; build done