https://bugzilla.redhat.com/show_bug.cgi?id=1260313
Bug ID: 1260313 Summary: Review Request: ganv - An interactive GTK Widget for "boxes and lines" Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: briancmonroe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
==Links== Spec File: https://paradoxguitarist.fedorapeople.org/ganv.spec SRPM: https://paradoxguitarist.fedorapeople.org/synthclone-0.3.0-3.fc22.src.rpm Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10967268
==Description== Ganv is an interactive Gtk canvas widget for graph-based interfaces (patch bays, modular synthesizers, finite state automation, interactive graphs, etc). Ganv provides classes for "Modules" (boxes with "Ports"), Circles, and Edges (lines that connect either Ports or Circles). The user can rearrange items, or Ganv can automatically arrange items using GraphViz. Edges can be made by the user one at a time with the mouse, or in groups using the mouse and keyboard.
==Extra Info== My first package hasn't been approved yet, but I'll add it as a blocker. The purpose for packaging this is to ultimately package patchage, a requested package for the Fedora Jam spin. Patchage requires ganv to build/run, so I'm packaging this one first.
https://bugzilla.redhat.com/show_bug.cgi?id=1260313
Brian Monroe briancmonroe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1111433 (synthclone)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1111433 [Bug 1111433] Review Request: synthclone - A tool to create sample-based instruments
https://bugzilla.redhat.com/show_bug.cgi?id=1260313
--- Comment #1 from Kevin Kofler kevin@tigcc.ticalc.org --- The SRPM link is wrong, and it also looks like you have the bug dependencies backwards, if you intended to make this bug depend on your previous one for which you hope to get sponsored.
https://bugzilla.redhat.com/show_bug.cgi?id=1260313
Brian Monroe briancmonroe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1111433 (synthclone) | Depends On| |1111433 (synthclone)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1111433 [Bug 1111433] Review Request: synthclone - A tool to create sample-based instruments
https://bugzilla.redhat.com/show_bug.cgi?id=1260313
--- Comment #2 from Brian Monroe briancmonroe@gmail.com --- Dang it! I thought I had looked over all of this.
The spec file is https://paradoxguitarist.fedorapeople.org/ganv-1.4.2-1.fc22.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1260313
--- Comment #3 from Brian Monroe briancmonroe@gmail.com --- I meant SRPM, that's what was missing.
https://bugzilla.redhat.com/show_bug.cgi?id=1260313
Jens Lody fedora@jenslody.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@jenslody.de
--- Comment #4 from Jens Lody fedora@jenslody.de --- Created attachment 1070858 --> https://bugzilla.redhat.com/attachment.cgi?id=1070858&action=edit Patch that fixes many spec-file issues
You should run fedora-review on your package(s) before asking for review:
<snip> Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Header files in -devel subpackage, if present. Note: ganv-lib : /usr/include/ganv-1/ganv/box.h ganv-lib : /usr/include/ganv-1/ganv/canvas.h ganv-lib : /usr/include/ganv-1/ganv/circle.h ganv-lib : /usr/include/ganv-1/ganv/edge.h ganv-lib : /usr/include/ganv-1/ganv/ganv.h ganv-lib : /usr/include/ganv-1/ganv/group.h ganv-lib : /usr/include/ganv-1/ganv/item.h ganv-lib : /usr/include/ganv-1/ganv/module.h ganv-lib : /usr/include/ganv-1/ganv/node.h ganv-lib : /usr/include/ganv-1/ganv/port.h ganv-lib : /usr/include/ganv-1/ganv/text.h ganv-lib : /usr/include/ganv-1/ganv/types.h ganv-lib : /usr/include/ganv-1/ganv/widget.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text </snip>
<snip> Rpmlint ------- Checking: ganv-1.4.2-1.fc24.x86_64.rpm ganv-lib-1.4.2-1.fc24.x86_64.rpm ganv-1.4.2-1.fc24.src.rpm ganv.x86_64: E: explicit-lib-dependency ganv-lib ganv.x86_64: E: standard-dir-owned-by-package /usr/bin ganv.x86_64: W: no-manual-page-for-binary ganv_bench ganv-lib.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment ganv-lib.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment ganv-lib.x86_64: W: no-documentation ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/module.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/ganv.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libganv-1.so ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/node.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/port.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/types.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/text.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/wrap.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/widget.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/group.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Box.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/item.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/types.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Port.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Canvas.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Node.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/box.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Edge.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/ganv.hpp ganv-lib.x86_64: E: standard-dir-owned-by-package /usr/lib64 ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/edge.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Circle.hpp ganv-lib.x86_64: E: standard-dir-owned-by-package /usr/include ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/circle.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Item.hpp ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/ganv-1.pc ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/canvas.h ganv-lib.x86_64: W: devel-file-in-non-devel-package /usr/include/ganv-1/ganv/Module.hpp 3 packages and 0 specfiles checked; 4 errors, 30 warnings. </snip>
I attach a patch that fixes most of these issues (at least the packaging issues). There are still rpmlint error/warnings: <snip> Rpmlint ------- Checking: ganv-1.4.2-1.fc24.x86_64.rpm ganv-lib-1.4.2-1.fc24.x86_64.rpm ganv-devel-1.4.2-1.fc24.x86_64.rpm ganv-1.4.2-1.fc24.src.rpm ganv.x86_64: W: no-manual-page-for-binary ganv_bench ganv-lib.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment ganv-lib.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment ganv-lib.x86_64: W: no-documentation ganv-devel.x86_64: W: only-non-binary-in-usr-lib ganv-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (debuginfo) ------------------- Checking: ganv-debuginfo-1.4.2-1.fc24.x86_64.rpm ganv-debuginfo.x86_64: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- ganv-debuginfo.x86_64: E: debuginfo-without-sources ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgtkmm-2.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libatkmm-1.6.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgdkmm-2.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgiomm-2.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libpangomm-1.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libglibmm-2.4.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libcairomm-1.0.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libatk-1.0.so.0 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgdk_pixbuf-2.0.so.0 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libgio-2.0.so.0 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libpangoft2-1.0.so.0 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libfontconfig.so.1 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libfreetype.so.6 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libcdt.so.5 ganv-lib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libganv-1.so.1.4.2 /lib64/libpthread.so.0 ganv-lib.x86_64: W: no-documentation ganv.x86_64: W: invalid-url URL: http://drobilla.net/software/ganv '' ganv.x86_64: W: no-manual-page-for-binary ganv_bench ganv-devel.x86_64: W: only-non-binary-in-usr-lib ganv-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 20 warnings. </snip>
I have no time to look into these deeper at the moment (at work currently).
https://bugzilla.redhat.com/show_bug.cgi?id=1260313
--- Comment #5 from Brian Monroe briancmonroe@gmail.com --- Thanks Jens,
I saw those sections on headers and libs files, but didn't fully understand it. I'll go through the fedora-review and fix all the issues.
https://bugzilla.redhat.com/show_bug.cgi?id=1260313
--- Comment #6 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- pbrobinson's scratch build of gtk-sharp-beans?#bbba0aef7a4bd673006df5b9a85a5763d9c026bc for epel7-archbootstrap and git://pkgs.fedoraproject.org/gtk-sharp-beans?#bbba0aef7a4bd673006df5b9a85a5763d9c026bc failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12037959
https://bugzilla.redhat.com/show_bug.cgi?id=1260313
--- Comment #7 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- pbrobinson's scratch build of gtk-murrine-engine?#b4bddbf235c281d671c99e8008f609b6d4e314d0 for epel7-archbootstrap and git://pkgs.fedoraproject.org/gtk-murrine-engine?#b4bddbf235c281d671c99e8008f609b6d4e314d0 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12037955
package-review@lists.fedoraproject.org