[Bug 197298] New: Review Request: perl-Locale-SubCountry

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197298

           Summary: Review Request: perl-Locale-SubCountry
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: bugzilla-sink(a)leemhuis.info
        ReportedBy: cweyl(a)alumni.drew.edu
         QAContact: fedora-package-review(a)redhat.com


Spec URL: http://home.comcast.net/~ckweyl/perl-Locale-SubCountry.spec
SRPM URL: http://home.comcast.net/~ckweyl/perl-Locale-SubCountry-1.37-0.fc5.src.rpm

Description:
This module allows you to convert the full name for a countries administrative
region to the code commonly used for postal addressing. The reverse lookup can
also be done. Sub country codes are defined in "ISO 3166-2:1998, Codes for the
representation of names of countries and their subdivisions".

Sub countries are termed as states in the US and Australia, provinces in
Canada and counties in the UK and Ireland.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 197298] Review Request: perl-Locale-SubCountry

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Locale-SubCountry


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197298


cweyl(a)alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |197304
              nThis|                            |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 197298] Review Request: perl-Locale-SubCountry

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Locale-SubCountry


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197298


tibbs(a)math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink(a)leemhuis.info |tibbs(a)math.uh.edu
OtherBugsDependingO|163776                      |163778
              nThis|                            |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 197298] Review Request: perl-Locale-SubCountry

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Locale-SubCountry


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197298





------- Additional Comments From tibbs(a)math.uh.edu  2006-07-03 16:05 EST -------
BuildRequires: perl is not necessary (not a blocker).
It's not necessary to pass OPTIMIZE for a noarch package (not a blocker).

Please add BR: perl(Test::Pod), perl(Test::Pod::Coverage) for complete test
coverage.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   b6d365e2db967821c2f1fdfcf064cab6  Locale-SubCountry-1.37.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(Locale::SubCountry) = 1.37
   perl(Locale::SubCountry::World)
   perl-Locale-SubCountry = 1.37-0.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Exporter)
   perl(locale)
   perl(strict)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
X %check is present but tests are skipped due to missing BuildRequires:
   All tests successful, 2 tests skipped.
   Files=3, Tests=15,  0 wallclock secs ( 0.10 cusr +  0.03 csys =  0.13 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 197298] Review Request: perl-Locale-SubCountry

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Locale-SubCountry


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197298





------- Additional Comments From cweyl(a)alumni.drew.edu  2006-07-03 19:47 EST -------
Additional buildrequires added.

Spec URL: http://home.comcast.net/~ckweyl/perl-Locale-SubCountry.spec
SRPM URL:
http://home.comcast.net/~ckweyl/perl-Locale-SubCountry-1.37-0.1.fc5.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 197298] Review Request: perl-Locale-SubCountry

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Locale-SubCountry


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197298


tibbs(a)math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs(a)math.uh.edu  2006-07-05 15:16 EST -------
Looks good now; all tests pass with none skipped:
  All tests successful.
  Files=3, Tests=17,  1 wallclock secs ( 0.75 cusr +  0.06 csys =  0.81 CPU)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 197298] Review Request: perl-Locale-SubCountry

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Locale-SubCountry


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197298


cweyl(a)alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE




------- Additional Comments From cweyl(a)alumni.drew.edu  2006-07-05 16:10 EST -------

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching
+Close bug

Thanks for the review!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 197298] Review Request: perl-Locale-SubCountry

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Locale-SubCountry


https://bugzilla.redhat.com/show_bug.cgi?id=197298


bugzilla(a)redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.