[Bug 2188676] New: Review Request: golang-github-azure-ansiterm - Go package for ANSI terminal emulation in Windows

https://bugzilla.redhat.com/show_bug.cgi?id=2188676

Bug ID: 2188676
           Summary: Review Request: golang-github-azure-ansiterm - Go
                    package for ANSI terminal emulation in Windows
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://sergiomb.fedorapeople.org/golang-github-azure-ansiterm/golang-github...
SRPM URL:
https://sergiomb.fedorapeople.org/golang-github-azure-ansiterm/golang-github...

Description:
Go package for ANSI terminal emulation in Windows.

Fedora Account System Username: sergiomb

[Bug 2188676] Review Request: golang-github-azure-ansiterm - Go package for ANSI terminal emulation in Windows

https://bugzilla.redhat.com/show_bug.cgi?id=2188676

--- Comment #1 from Sergio Basto  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=100216993

[Bug 2188676] Review Request: golang-github-azure-ansiterm - Go package for ANSI terminal emulation in Windows

https://bugzilla.redhat.com/show_bug.cgi?id=2188676

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |needinfo?([e-mail]
                   |                            |)

--- Comment #2 from Robert-André Mauchin 🐧  ---
 - Please use autorelease/autochangelog

- Isn't this a Windows only package? Which one of your package is requiring
it? usually it's only a dep in _windows.go file, which are excluded by the
build system and the macros.

The only notable package that requires it is moby/moby, in a test:

https://github.com/moby/moby/blob/v24.0.5/integration/internal/termtest/stri...

And github.com/moby/term, which is packaged but it is not called because in
windows files.

I'd patch it out from moby:
https://github.com/moby/moby/commit/2ec3e14c0ff7f8552c1f9b09ffde743632fa1f8c

From 873a4b6552fcdbf60299e51de3139465da6b2a92 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Robert-Andr=C3=A9=20Mauchin?= 
Date: Mon, 14 Aug 2023 19:11:59 +0200
Subject: [PATCH] Make call to Azure/go-ansiterm Windows-only

---
 integration/internal/termtest/stripansi_default.go     | 10 ++++++++++
 .../{stripansi_test.go => stripansi_test_windows.go}   |  0
 .../termtest/{stripansi.go => stripansi_windows.go}    |  0
 3 files changed, 10 insertions(+)
 create mode 100644 integration/internal/termtest/stripansi_default.go
 rename integration/internal/termtest/{stripansi_test.go =>
stripansi_test_windows.go} (100%)
 rename integration/internal/termtest/{stripansi.go => stripansi_windows.go}
(100%)

diff --git a/integration/internal/termtest/stripansi_default.go
b/integration/internal/termtest/stripansi_default.go
new file mode 100644
index 0000000000..8557c8bf72
--- /dev/null
+++ b/integration/internal/termtest/stripansi_default.go
@@ -0,0 +1,10 @@
+package termtest // import
"github.com/docker/docker/integration/internal/termtest"
+
+import (
+       "errors"
+)
+
+// StripANSICommands provides a dummy implementation for non-Windows
platforms.
+func StripANSICommands(input string) (string, error) {
+       return input, errors.New("StripANSICommands is not implemented for this
platform")
+}
diff --git a/integration/internal/termtest/stripansi_test.go
b/integration/internal/termtest/stripansi_test_windows.go
similarity index 100%
rename from integration/internal/termtest/stripansi_test.go
rename to integration/internal/termtest/stripansi_test_windows.go
diff --git a/integration/internal/termtest/stripansi.go
b/integration/internal/termtest/stripansi_windows.go
similarity index 100%
rename from integration/internal/termtest/stripansi.go
rename to integration/internal/termtest/stripansi_windows.go

[Bug 2188676] Review Request: golang-github-azure-ansiterm - Go package for ANSI terminal emulation in Windows

https://bugzilla.redhat.com/show_bug.cgi?id=2188676

--- Comment #3 from Robert-André Mauchin 🐧  ---
Filename was wrong, take this patch instead
https://patch-diff.githubusercontent.com/raw/moby/moby/pull/46234.patch

[Bug 2188676] Review Request: golang-github-azure-ansiterm - Go package for ANSI terminal emulation in Windows

https://bugzilla.redhat.com/show_bug.cgi?id=2188676

Sergio Basto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOTABUG                     |---
             Status|CLOSED                      |NEW
           Keywords|                            |Reopened