[Bug 772233] New: Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mstflint - Mellanox firmware burning utility

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Summary: Review Request: mstflint - Mellanox firmware burning
                    utility
           Product: Fedora
           Version: rawhide
          Platform: Unspecified
               URL: http://people.redhat.com/dledford/Package%20Review/
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---
        Regression: ---
        Mount Type: ---
     Documentation: ---

The mstflint package is used to burn new firmware to Mellanox based InfiniBand
or 10GigE network adapters.  As the Mellanox cards are highly intelligent, the
firmware is used to enable various advanced features.  Frequently, bugs are
fixed via new firmware versions.  The ability to update the firmware is
consequently very important on Mellanox cards.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Albert Strasheim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Albert Strasheim  2012-01-09 08:18:58 EST ---
$ rpmlint mstflint.spec mstflint-1.4-6.fc15.x86_64.rpm
mstflint.x86_64: W: spelling-error Summary(en_US) Mellanox -> Melanoma
mstflint.x86_64: W: obsolete-not-provided openib-mstflint
mstflint.x86_64: W: obsolete-not-provided openib-tvflash
mstflint.x86_64: W: obsolete-not-provided tvflash
mstflint.x86_64: W: no-manual-page-for-binary mstmread
mstflint.x86_64: W: no-manual-page-for-binary mstflint
mstflint.x86_64: W: no-manual-page-for-binary mstvpd
mstflint.x86_64: W: no-manual-page-for-binary mstregdump
mstflint.x86_64: W: no-manual-page-for-binary mstmwrite
1 packages and 1 specfiles checked; 0 errors, 9 warnings.

How does mstflint relate to the mft packages provided by Mellanox?

http://www.mellanox.com/content/pages.php?pg=management_tools&menu_secti...

For some reason I got the idea that mstflint is older software, but I could
easily be mistaken.

Is it worth packaging this for Fedora?

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #2 from Doug Ledford  2012-01-09 14:22:25 EST ---
I believe they are the same thing or at least as close as they can be given
that the mft packages are Windows/Linux capable while mstflint is linux
specific.

The older software you are referring to is tvflash.  Both mstflint and mft
tools supersede the old tvflash software.  I'm not bothering to submit that for
Fedora although it exists in both EL4 and EL5.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Jay Fenlason  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|                            |fedora-review+

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Doug Ledford  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Doug Ledford  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #3 from Doug Ledford  2012-01-10 16:23:51 EST ---
New Package SCM Request
=======================
Package Name: mstflint
Short Description: Utility to burn firmware images on Mellanox hardware
Owners: dledford
Branches: f15 f16
InitialCC:

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Doug Ledford  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #4 from Jon Ciesla  2012-01-10 19:56:47 EST ---
Git done (by process-git-requests).

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #5 from Fedora Update System  2012-01-11 13:40:59 EST ---
mstflint-1.4-6.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/mstflint-1.4-6.fc16

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #6 from Fedora Update System  2012-01-11 13:41:07 EST ---
mstflint-1.4-6.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/mstflint-1.4-6.fc15

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Ville Skyttä  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ASSIGNED
                 CC|                            |[e-mail],
                   |                            |[e-mail]
               Flag|fedora-review+              |fedora-review-

--- Comment #7 from Ville Skyttä  2012-01-13 13:27:14 EST ---
Was this package actually reviewed at all?  According to the bug history, the
fedora-review+ flag was set by [e-mail] but there's not a single
comment from him and this bug is still assigned to someone else.

The package doesn't seem to be actually building anything at all from sources
but ships prebuilt executables included in the source tarball (which are built
for x86_64; meaning the i686 package contains x86_64 binaries too).  This is
something that should be fixed quickly.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #8 from Jon Ciesla  2012-01-13 13:40:26 EST ---
Indeed.  I'm also curious exactly what has been done.  If this can't be built
from source it needs to be removed.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #9 from Jon Ciesla  2012-01-13 13:45:29 EST ---
On 2 minutes glance, a make clean before make might be all it needs, but that
doesn't answer the Ville's concerns about the review.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #10 from Doug Ledford  2012-01-13 14:37:04 EST ---
My apologies for this guys.  The upstream people gave me a tarball to include a
fix and it was a simple update so I put the tarball in the sources and rebuilt
without inspecting the new tarball (that was the last update prior to
submitting to Fedora).  That tarball is just broken though.  I'm going to have
upstream get me a new tarball.  In the meantime I've created a cleaned up
tarball of my own and submitted a build to resolve the issue.

In regards to the question of the review, there was one, Albert did it, but
he's new to the process (and fairly new to Fedora) and so Jay backed him up and
set the review complete flag.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #11 from Jon Ciesla  2012-01-13 15:05:39 EST ---
Noted, thanks.  Make sure Albert is aware that it's customary to provide
details of the review in the BZ, often using a template or a list from the
Review Guidelines.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #12 from Doug Ledford  2012-01-13 15:13:35 EST ---
Unfortunately, I do so few reviews I'm just as bad.  Another user pointed me at
the normal process page and I started making my submissions better.  For
example the ones I current have that are still open do a better job of
following the normal procedures.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

--- Comment #13 from Jon Ciesla  2012-01-13 15:36:05 EST ---
Onward and upward!

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #14 from Fedora Update System  2012-01-13 22:58:58 EST ---
mstflint-1.4-7.fc15 has been pushed to the Fedora 15 testing repository.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |mstflint-1.4-7.fc16
         Resolution|                            |ERRATA
        Last Closed|                            |2012-02-01 14:22:17

--- Comment #15 from Fedora Update System  2012-02-01 14:22:17 EST ---
mstflint-1.4-7.fc16 has been pushed to the Fedora 16 stable repository.

[Bug 772233] Review Request: mstflint - Mellanox firmware burning utility

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=772233

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|mstflint-1.4-7.fc16         |mstflint-1.4-7.fc15

--- Comment #16 from Fedora Update System  2012-02-01 14:24:08 EST ---
mstflint-1.4-7.fc15 has been pushed to the Fedora 15 stable repository.