[Bug 1924959] New: Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Bug ID: 1924959
           Summary: Review Request: f34-backgrounds - Fedora 34 default
                    desktop background
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/luya/fxx-backgrounds/fedo...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/luya/fxx-backgrounds/fedo...
Description: This package contains desktop backgrounds for the Fedora 34
default
theme.  Pulls in themes for GNOME, KDE, Mate and Xfce desktops.
Fedora Account System Username:luya

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Luya Tshimbalanga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1829022
                   |                            |(BetaBlocker,F34BetaBlocker
                   |                            |)
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Luya Tshimbalanga  ---
Adding blocker for Fedora 34 Beta.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1829022
[Bug 1829022] Fedora 34 Beta blocker bug tracker

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Lukas Ruzicka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Lukas Ruzicka  ---
I built and installed the packages on my Rawhide machine. Is the new background
a bluish forest lake (or river)? If so, the backgrounds installed without
issues, but they weren't automatically selected after I rebooted the system.

I am not sure whether this is a supposed behaviour, but I sort of expected the
background to be replaced automatically.

Otherwise, looks good to me.

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Stephen John Smoogen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

--- Comment #3 from Stephen John Smoogen  ---
I have run rpmlint and there are no errors, but just warnings like

f34-backgrounds.src:34: W: mixed-use-of-spaces-and-tabs (spaces: line 34, tab:
line 8)
f34-backgrounds-base.noarch: W: no-documentation
f34-backgrounds-extras-base.noarch: W: no-documentation
f34-backgrounds-extras-gnome.noarch: W: no-documentation
f34-backgrounds-extras-kde.noarch: W: no-documentation

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Stephen John Smoogen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+

--- Comment #4 from Stephen John Smoogen  ---

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Creative Commons Attribution 4.0
     International License", "*No copyright* Creative Commons CC0 Universal
     1.0 Public Domain Dedication". 27 files have unknown license. Detailed
     output of licensecheck in
     /home/ssmoogen/rpmbuild/sss/1924959-f34-backgrounds/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/wallpapers,
     /usr/share/gnome-background-properties, /usr/share/mate-background-
     properties, /usr/share/xfce4, /usr/share/backgrounds/f34
     smooge feels this should pass because those directories are owned
     by system. 
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/xfce4(f33-backgrounds-xfce, f28-backgrounds-xfce,
     f32-backgrounds-xfce, f30-backgrounds-xfce, f31-backgrounds-xfce,
     f29-backgrounds-xfce), /usr/share/xfce4/backdrops(f31-backgrounds-
     extras-xfce, f32-backgrounds-extras-xfce, f33-backgrounds-extras-xfce,
     f28-backgrounds-extras-xfce, f29-backgrounds-extras-xfce,
     f33-backgrounds-xfce, f30-backgrounds-extras-xfce, f28-backgrounds-
     xfce, f32-backgrounds-xfce, f30-backgrounds-xfce, f31-backgrounds-
     xfce, f29-backgrounds-xfce), /usr/share/mate-background-
     properties(desktop-backgrounds-basic, mate-backgrounds,
     f28-backgrounds-mate, f32-backgrounds-mate, adapta-backgrounds,
     f29-backgrounds-mate, fedorainfinity-backgrounds, f33-backgrounds-
     mate, f30-backgrounds-mate, f31-backgrounds-mate), /usr/share/gnome-
     background-properties(solar-backgrounds, f30-backgrounds-gnome,
     desktop-backgrounds-basic, f32-backgrounds-gnome, f33-backgrounds-
     gnome, neon-backgrounds, f31-backgrounds-gnome, adapta-backgrounds,
     f29-backgrounds-gnome, f28-backgrounds-gnome, fedorainfinity-
     backgrounds, fedora-workstation-backgrounds, gears-backgrounds),
     /usr/share/plasma(f32-backgrounds-kde, kf5-plasma, f25-backgrounds-
     kde, f27-backgrounds-kde, f31-backgrounds-kde, f30-backgrounds-kde,
     f28-backgrounds-kde, f29-backgrounds-kde, f26-backgrounds-kde,
     f33-backgrounds-kde), /usr/share/plasma/desktoptheme(plasma-desktop,
     f32-backgrounds-kde, f27-backgrounds-kde, f25-backgrounds-kde,
     kf5-plasma, f31-backgrounds-kde, f30-backgrounds-kde, f28-backgrounds-
     kde, f29-backgrounds-kde, f26-backgrounds-kde, f33-backgrounds-kde)
     * This is acceptable for this package *
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     f34-backgrounds-base , f34-backgrounds-gnome , f34-backgrounds-kde ,
     f34-backgrounds-mate , f34-backgrounds-xfce , f34-backgrounds-extras-
     base , f34-backgrounds-extras-gnome , f34-backgrounds-extras-mate ,
     f34-backgrounds-extras-kde , f34-backgrounds-extras-xfce
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: f34-backgrounds-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-base-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-gnome-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-kde-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-mate-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-xfce-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-extras-base-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-extras-gnome-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-extras-mate-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-extras-kde-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-extras-xfce-34.0.0-1.fc34.noarch.rpm
          f34-backgrounds-34.0.0-1.fc34.src.rpm
f34-backgrounds.noarch: W: no-documentation
f34-backgrounds-base.noarch: W: no-documentation
f34-backgrounds-gnome.noarch: W: no-documentation
f34-backgrounds-kde.noarch: W: no-documentation
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1024x600.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1024x768.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1152x720.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1152x864.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1200x900.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x1024.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x720.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x768.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x800.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x960.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1366x768.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1440x1080.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1440x900.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1600x1200.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1600x1280.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1680x1050.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1920x1080.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1920x1200.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1920x1280.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1920x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2048x1536.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2160x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2304x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2560x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2560x1600.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2960x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/3000x2000.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/3200x1800.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/3440x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/3840x2160.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/640x480.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/800x480.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/800x600.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-mate.noarch: W: no-documentation
f34-backgrounds-xfce.noarch: W: no-documentation
f34-backgrounds-xfce.noarch: W: dangling-symlink
/usr/share/xfce4/backdrops/f34.png
/usr/share/backgrounds/f34/default/f34-01-day.png
f34-backgrounds-extras-base.noarch: W: no-documentation
f34-backgrounds-extras-gnome.noarch: W: no-documentation
f34-backgrounds-extras-mate.noarch: W: no-documentation
f34-backgrounds-extras-kde.noarch: W: no-documentation
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1024x600.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1024x768.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1152x720.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1152x864.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1200x900.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x1024.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x720.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x768.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x800.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x960.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1366x768.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1440x1080.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1440x900.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1600x1200.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1600x1280.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1680x1050.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1920x1080.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1920x1200.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1920x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2048x1536.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2160x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2304x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2560x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2560x1600.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2960x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/3000x2000.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/3300x1800.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/3440x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/3840x2160.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/640x480.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/800x480.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/800x600.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-xfce.noarch: W: no-documentation
f34-backgrounds-extras-xfce.noarch: W: dangling-symlink
/usr/share/xfce4/backdrops/f34-02-night.png
/usr/share/backgrounds/f34/default/f34-02-night.png
f34-backgrounds-extras-xfce.noarch: W: dangling-relative-symlink
/usr/share/xfce4/backdrops/f34-dark-blue.png
../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-xfce.noarch: W: dangling-symlink
/usr/share/xfce4/backdrops/f34.png
/usr/share/backgrounds/f34/default/f34-01-day.png
f34-backgrounds.src:34: W: mixed-use-of-spaces-and-tabs (spaces: line 34, tab:
line 8)
12 packages and 0 specfiles checked; 0 errors, 81 warnings.

Rpmlint (installed packages)
----------------------------
f34-backgrounds-extras-mate.noarch: W: no-documentation
f34-backgrounds-base.noarch: W: no-documentation
f34-backgrounds-kde.noarch: W: no-documentation
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1024x600.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1024x768.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1152x720.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1152x864.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1200x900.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x1024.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x720.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x768.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x800.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1280x960.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1366x768.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1440x1080.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1440x900.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1600x1200.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1600x1280.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1680x1050.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1920x1080.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1920x1200.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1920x1280.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/1920x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2048x1536.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2160x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2304x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2560x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2560x1600.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/2960x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/3000x2000.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/3200x1800.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/3440x1440.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/3840x2160.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/640x480.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/800x480.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34/contents/images/800x600.png
../../../../backgrounds/f34/default/f34.png
f34-backgrounds-xfce.noarch: W: no-documentation
f34-backgrounds-xfce.noarch: W: dangling-symlink
/usr/share/xfce4/backdrops/f34.png
/usr/share/backgrounds/f34/default/f34-01-day.png
f34-backgrounds-extras-gnome.noarch: W: no-documentation
f34-backgrounds-mate.noarch: W: no-documentation
f34-backgrounds-extras-xfce.noarch: W: no-documentation
f34-backgrounds-extras-xfce.noarch: W: dangling-symlink
/usr/share/xfce4/backdrops/f34-02-night.png
/usr/share/backgrounds/f34/default/f34-02-night.png
f34-backgrounds-extras-xfce.noarch: W: dangling-relative-symlink
/usr/share/xfce4/backdrops/f34-dark-blue.png
../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-xfce.noarch: W: dangling-symlink
/usr/share/xfce4/backdrops/f34.png
/usr/share/backgrounds/f34/default/f34-01-day.png
f34-backgrounds.noarch: W: no-documentation
f34-backgrounds-extras-kde.noarch: W: no-documentation
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1024x600.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1024x768.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1152x720.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1152x864.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1200x900.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x1024.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x720.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x768.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x800.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1280x960.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1366x768.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1440x1080.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1440x900.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1600x1200.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1600x1280.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1680x1050.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1920x1080.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1920x1200.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/1920x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2048x1536.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2160x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2304x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2560x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2560x1600.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/2960x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/3000x2000.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/3300x1800.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/3440x1440.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/3840x2160.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/640x480.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/800x480.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-kde.noarch: W: dangling-relative-symlink
/usr/share/wallpapers/F34_dark-blue/contents/images/800x600.png
../../../../backgrounds/f34/extras/dark-blue.png
f34-backgrounds-extras-base.noarch: W: no-documentation
f34-backgrounds-gnome.noarch: W: no-documentation
11 packages and 0 specfiles checked; 0 errors, 80 warnings.

Source checksums
----------------
https://github.com/fedoradesign/backgrounds/releases/download/v34.0.0/f34-ba...
:
  CHECKSUM(SHA256) this package     :
d401cadf5b8717232b5e7043074100e1e740a470b76ae5571c7014083597dba9
  CHECKSUM(SHA256) upstream package :
d401cadf5b8717232b5e7043074100e1e740a470b76ae5571c7014083597dba9

Requires
--------
f34-backgrounds (rpmlib, GLIBC filtered):
    f34-backgrounds-gnome
    f34-backgrounds-kde
    f34-backgrounds-mate
    f34-backgrounds-xfce

f34-backgrounds-base (rpmlib, GLIBC filtered):

f34-backgrounds-gnome (rpmlib, GLIBC filtered):
    f34-backgrounds-base

f34-backgrounds-kde (rpmlib, GLIBC filtered):
    f34-backgrounds-base
    kde-filesystem

f34-backgrounds-mate (rpmlib, GLIBC filtered):
    f34-backgrounds-base

f34-backgrounds-xfce (rpmlib, GLIBC filtered):
    f34-backgrounds-base
    xfdesktop

f34-backgrounds-extras-base (rpmlib, GLIBC filtered):

f34-backgrounds-extras-gnome (rpmlib, GLIBC filtered):
    f34-backgrounds-extras-base

f34-backgrounds-extras-mate (rpmlib, GLIBC filtered):
    f34-backgrounds-extras-base

f34-backgrounds-extras-kde (rpmlib, GLIBC filtered):
    f34-backgrounds-extras-base

f34-backgrounds-extras-xfce (rpmlib, GLIBC filtered):
    f34-backgrounds-extras-base

Provides
--------
f34-backgrounds:
    f34-backgrounds

f34-backgrounds-base:
    f34-backgrounds-base

f34-backgrounds-gnome:
    f34-backgrounds-gnome

f34-backgrounds-kde:
    f34-backgrounds-kde

f34-backgrounds-mate:
    f34-backgrounds-mate

f34-backgrounds-xfce:
    f34-backgrounds-xfce

f34-backgrounds-extras-base:
    f34-backgrounds-extras-base

f34-backgrounds-extras-gnome:
    f34-backgrounds-extras-gnome

f34-backgrounds-extras-mate:
    f34-backgrounds-extras-mate

f34-backgrounds-extras-kde:
    f34-backgrounds-extras-kde

f34-backgrounds-extras-xfce:
    f34-backgrounds-extras-xfce

Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1924959
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: Haskell, Java, Python, SugarActivity, PHP, fonts, Ocaml,
C/C++, R, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

--- Comment #5 from Luya Tshimbalanga  ---
Thank you for the approved review, Smooge!

(In reply to Lukas Ruzicka from comment #2)
> I built and installed the packages on my Rawhide machine. Is the new
> background a bluish forest lake (or river)? If so, the backgrounds installed
> without issues, but they weren't automatically selected after I rebooted the
> system.

Yes, the blue forest lake is the new background.
> I am not sure whether this is a supposed behaviour, but I sort of expected
> the background to be replaced automatically.

[desktop-backgrounds](https://src.fedoraproject.org/rpms/desktop-backgrounds/blob/rawhide/f/deskto...)
needs an update for the automatic selection after reboot.

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Matthew Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Matthew Miller  ---
@Luya The branch is on Tuesday, and it would be kind of exciting for the new
background to land immediately on the branch when that happens. And when the
F35 background is ready, for it to go right into rawhide.

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Luya Tshimbalanga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |)
                   |                            |needinfo?([e-mail]
                   |                            |)

--- Comment #7 from Luya Tshimbalanga  ---
@[e-mail]

Repo request is already filed. See
https://pagure.io/releng/fedora-scm-requests/issue/32029
Desktop-backgrounds will need an update on Rawhide as I already committed the
changes.

Proven packagers are welcome to import and build package once the request is
approved.

Sent from Samsung Galaxy

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Luya Tshimbalanga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |)                           |
                   |needinfo?([e-mail] |
                   |)                           |

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Stephen John Smoogen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Stephen John Smoogen  ---
Smooge has too many accounts. +1

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

--- Comment #9 from Mohan Boddu  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/f34-backgrounds

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

--- Comment #10 from Luya Tshimbalanga  ---
Can someone take a look why the build failed on
https://koji.fedoraproject.org/koji/taskinfo?taskID=61607683 ?

I am unable to access to my laptop at this time. Thanks

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

--- Comment #11 from Stephen John Smoogen  ---
BuildError: package f34-backgrounds not in list for tag f34-updates-candidate

[Bug 1924959] Review Request: f34-backgrounds - Fedora 34 default desktop background

https://bugzilla.redhat.com/show_bug.cgi?id=1924959

Luya Tshimbalanga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2021-02-08 23:10:08

--- Comment #12 from Luya Tshimbalanga  ---
Weird! desktop-backgrounds successfully built on main branch while
f34-backgrounds failed on rawhide(main) branch.
After a quick fix related to make as a build requirement, f34-backgrounds is
now available before the branching:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-1b2aca643b

Closing this report. Thanks smooge and Mohan.