Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=449707
Summary: Review Request: gambit-c - Gambit-C Scheme programming system Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: michel.sylvan@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://salimma.fedorapeople.org/for_review/lang/gambit-c.spec SRPM URL: http://salimma.fedorapeople.org/for_review/lang/gambit-c-4.2.8-1.fc9.src.rpm Description: Gambit-C includes a Scheme interpreter and a Scheme compiler which can be used to build standalone executables. Because the compiler generates portable C code it is fairly easy to port to any platform with a decent C compiler.
The Gambit-C system conforms to the R4RS, R5RS and IEEE Scheme standards. The full numeric tower is implemented, including: infinite precision integers (bignums), rationals, inexact reals (floating point numbers), and complex numbers.
(based on earlier third-party package by Gerard Milmeister)
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=642058
Note that this is not for the submitted package; I've since split out the HTML and PDF documentations into a -doc subpackage (almost 2 MB)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From tibbs@math.uh.edu 2008-06-06 15:59 EST ------- This builds OK; rpmlint has several devel-file-in-non-devel-package complaints, which can be ignored because this is a compilation system. There are also these: gambit-c-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gambc-v4_2_8/lib/mem.c gambit-c-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gambc-v4_2_8/lib/setup.h which aren't a big deal but trivially fixed with a chmod in %prep if you care.
I'm not sure about the license. ASL 2.0 is certainly correct, but it seems to me that they allow LGPLv2+, not just LGPLv2. Am I missing something? I don't see anywhere in the source that a specific LGPL version is specified, and if you click the link on their web site you go to FSF's LGPLv3 page. Perhaps you could get them to clarify.
There seems to be a test suite present which isn't called. I added %check make check and it runs fine, ending with: ============ ALL TESTS SUCCESSFUL
Note that /usr/bin/six conflicts with the existing (and completely unrelated) six package. Is there any possibility of renaming it?
Did you consider moving the info documentation and the examples to gambit-c-doc as well? The examples, at least, are almost another megabyte, although that's dwarfed by the rest of the package.
* source files match upstream: e07d0031e434fc98a8b3ac136fe2426280cc342b8e3b3a325c7348938d5bae11 gambc-v4_2_8.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has trivial complaints. * final provides and requires are sane: gambit-c-4.2.8-1.fc10.x86_64.rpm gambit-c = 4.2.8-1.fc10 = /bin/sh gcc info libutil.so.1()(64bit) libutil.so.1(GLIBC_2.2.5)(64bit)
gambit-c-doc-4.2.8-1.fc10.x86_64.rpm gambit-c-doc = 4.2.8-1.fc10 = gambit-c = 4.2.8-1.fc10
X %check is not present, but a functional test suite exists. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. O file perms in the -debuginfo package are a bit odd; everything else is OK. * scriptlets OK (install-info). * code, not content. * %docs are not necessary for the proper functioning of the package. * headers present, but OK since this is a compiler. * no pkgconfig files. * static libraries present, but OK since this is a compilation system. * no libtool .la files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From michel.sylvan@gmail.com 2008-06-07 11:24 EST ------- Spec URL: http://salimma.fedorapeople.org/for_review/lang/gambit-c.spec SRPM URL: http://salimma.fedorapeople.org/for_review/lang/gambit-c-4.2.8-2.fc9.src.rpm
Suggestions implemented, thanks. I also removed some of the symlinks that turns out to be superfluous -- only gsi, gsc and six are really needed. six just links to gsi anyway (gsi switches to infix mode if it's called as six, so I've created a wrapper script, gsix, that invokes the six symlink from %{_libdir})
Will check with upstream on the license question.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From michel.sylvan@gmail.com 2008-06-07 21:59 EST ------- FYI, I'm also packaging gambit-termite (https://bugzilla.redhat.com/show_bug.cgi?id=450417), the same Gambit-C with the Termite distributed programming system patched in. I've packaged it to be completely parallel-installable.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs@math.uh.edu 2008-06-10 16:13 EST ------- Hmm, this one didn't build for me: + chmod +x gsix chmod: cannot access `gsix': No such file or directory
Oh, that needs to be: chmod +x $RPM_BUILD_ROOT%{_bindir}/gsix
Otherwise (fixing the above so that it builds), things look good. The test suite is run and passes; the conflict with /usr/bin/six is gone, and the weird permissions are fixed up.
I guess we're just waiting on the license. I don't know if it's something that should hold up this package, so I'll approve it and you can check in when you get an answer. If you don't, it seems clear due to the "any later version" language that LGPLv2+ is correct here.
APPROVED
An odd question, perhaps, but have you considered just having this package generate gambit-termite as well? I guess that might be a weird build process, though.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From michel.sylvan@gmail.com 2008-06-18 12:49 EST ------- That's a thought, that way they can just share documentation.
New Package CVS Request ======================= Package Name: gambit-c Short Description: Gambit-C Scheme programming system Owners: salimma Branches: F-8 F-9 EL-5 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From tibbs@math.uh.edu 2008-06-18 22:52 EST ------- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From updates@fedoraproject.org 2008-07-05 01:29 EST ------- gambit-c-4.2.8-5.fc9 has been submitted as an update for Fedora 9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From updates@fedoraproject.org 2008-07-05 03:12 EST ------- gambit-c-4.2.8-5.fc8 has been submitted as an update for Fedora 8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From mxcarron@maxca.info 2008-07-05 06:15 EST ------- Is there any reason why you don't use --enable-gcc-opts
INSTALL.txt says : "When using the GCC compiler it is recommended to use the --enable-gcc-opts option to further improve the execution speed and compactness of the executables"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
------- Additional Comments From updates@fedoraproject.org 2008-07-06 02:12 EST ------- gambit-c-4.2.8-5.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gambit-c'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-6115
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From michel.sylvan@gmail.com 2008-07-06 12:44 EST ------- *** Bug 450417 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From michel.sylvan@gmail.com 2008-07-14 16:21 EST ------- Maxime:
--enable-gcc-opts is enabled in the version I committed -- I did not turn it on in the version reviewed, and did not update it after the review was approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From updates@fedoraproject.org 2008-07-15 12:03 EST ------- gambit-c-4.2.8-6.fc9 has been submitted as an update for Fedora 9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From updates@fedoraproject.org 2008-07-15 13:13 EST ------- gambit-c-4.2.8-6.fc8.1 has been submitted as an update for Fedora 8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From updates@fedoraproject.org 2008-07-31 21:46 EST ------- gambit-c-4.2.8-6.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |CURRENTRELEASE Fixed In Version| |4.2.8-6.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gambit-c - Gambit-C Scheme programming system
https://bugzilla.redhat.com/show_bug.cgi?id=449707
------- Additional Comments From updates@fedoraproject.org 2008-07-31 21:47 EST ------- gambit-c-4.2.8-6.fc8.1 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla