[Bug 226506] New: Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226506

Summary: Merge Review: ttmkfdir
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: ttmkfdir

http://cvs.fedora.redhat.com/viewcvs/devel/ttmkfdir/
Initial Owner: [e-mail]

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ttmkfdir

https://bugzilla.redhat.com/show_bug.cgi?id=226506

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]          |[e-mail],
                   |                            |[e-mail]

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ttmkfdir

https://bugzilla.redhat.com/show_bug.cgi?id=226506

------- Additional Comments From [e-mail]  2008-05-12 05:44 EST -------
updated spec file
url:
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec

srpm url:
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-27.fc9.src.rpm

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226506

Tony Fu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]    |[e-mail]

--- Comment #2 from Tony Fu   2008-09-09 23:07:14 EDT ---
requested by Jens Petersen (#27995)

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226506

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #3 from Parag AN(पराग)   2008-12-12 03:49:52 EDT ---
will review this. Assigning review to me for now.

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226506

--- Comment #4 from Parag AN(पराग)   2008-12-15 00:38:31 EDT ---
1) Buildroot should be from
http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag

2) defattr usage should be %defattr(-,root,root, -)

3) according to 
http://fedoraproject.org/wiki/PackagingGuidelines#Why_the_.25makeinstall_mac...
use make DESTDIR=$RPM_BUILD_ROOT install

4) Also, in Changelog use %%post instead of %post

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226506

--- Comment #5 from Pravin Satpute   2008-12-15 05:39:05 EDT ---
modified as per comments
updated spec file
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec

updated srpm 
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-28.fc10.src.rpm

rpmlint on srpm gives
ttmkfdir.src: W: no-url-tag

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226506

--- Comment #6 from Pravin Satpute   2008-12-15 06:05:31 EDT ---
updated spec file
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir.spec

updated srpm 
http://pravins.fedorapeople.org/ttmkfdir/ttmkfdir-3.0.9-28.fc10.src.rpm

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226506

--- Comment #7 from Parag AN(पराग)   2008-12-15 06:16:50 EDT ---
package built successfully
http://koji.fedoraproject.org/koji/taskinfo?taskID=999153

rpmlint only complained 
ttmkfdir.src: W: no-url-tag
But I see that there is already comment as per
http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream

Can you build this package in rawhide now? Once its built I will approve
review.

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226506

--- Comment #8 from Pravin Satpute   2008-12-15 06:39:57 EDT ---
Done
built it for rawhide
http://koji.fedoraproject.org/koji/taskinfo?taskID=999184

Thanks for completing merge review of ttmkfdir

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226506

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #9 from Parag AN(पराग)   2008-12-15 08:14:33 EDT ---
Thanks for building package.

APPROVED This Merge-Review.

[Bug 226506] Merge Review: ttmkfdir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226506

Pravin Satpute  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE