Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-openoffice - Python libraries for interacting with OpenOffice.org
https://bugzilla.redhat.com/show_bug.cgi?id=474188
Summary: Review Request: python-openoffice - Python libraries for interacting with OpenOffice.org Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: dan@danny.cz QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedora.danny.cz/tryton/python-openoffice.spec SRPM URL: http://fedora.danny.cz/tryton/python-openoffice-0.1-0.1.20080929svn33.fc11.s...
Description: The library is designed to supports both writing Macros called by OOo) and interacting with OOo from an external Python program (using the UNO bridge).
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=971446
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474188
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |473476
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474188
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review+
--- Comment #1 from Jason Tibbitts tibbs@math.uh.edu 2008-12-06 23:22:32 EDT --- This builds but fails to install for me on rawhide: Error: Missing Dependency: python(abi) = 2.5 is needed by package 1:openoffice.org-pyuno-3.0.1-12.1.fc11.x86_64 (fedora) Error: Missing Dependency: libpython2.5.so.1.0()(64bit) is needed by package 1:openoffice.org-pyuno-3.0.1-12.1.fc11.x86_64 (fedora)
Not this package's fault; the dependencies are still screwed up from the puthon 2.6 upgrade in rawhide. I did an F10 build and it seems to have worked fine.
I have no comprehension of how to test this, so I am only reviewing the packaging.
* source files match upstream. sha256sum: 31eaccab565fe2d7aab79a5a9f8048d6c771af9d897db5d68b2d614946836a38 openoffice-0.1-r33-20080929.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (F10, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: python-openoffice = 0.1-0.1.20080929svn33.fc10 = openoffice.org-pyuno python(abi) = 2.5
* owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474188
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Dan Horák dan@danny.cz 2008-12-07 04:27:26 EDT --- New Package CVS Request ======================= Package Name: python-openoffice Short Description: Python libraries for interacting with OpenOffice.org Owners: sharkcz Branches: F-9 F-10 EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474188
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2008-12-07 19:30:54 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474188
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #4 from Dan Horák dan@danny.cz 2008-12-08 02:29:49 EDT --- Imported and built. Thanks for the review.
package-review@lists.fedoraproject.org