Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
Summary: Review Request: tcl-thread - Thread extension for Tcl Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jwboyer@jdub.homelinux.org QAContact: fedora-package-review@redhat.com
Spec URL: http://jdub.homelinux.org/pub/tcl-thread.spec SRPM URL: http://jdub.homelinux.org/pub/tcl-thread-2.6.5-1.src.rpm Description:
Thread extention for Tcl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |wart@kobold.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
------- Additional Comments From wart@kobold.org 2006-11-02 17:25 EST ------- This does not build properly on x86_64 in mock. It seems that the configure script is written to only look for libgdbm.so in /usr/lib, not /usr/lib64. You might try adding '--with-gdbm=%{_libdir}' to %configure, or modifying the configure script to look for the library in ${libdir}.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
------- Additional Comments From wart@kobold.org 2006-11-02 17:47 EST ------- Created an attachment (id=140195) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=140195&action=vie...) Look for gdbm library in %{_libdir}
This patch modifies the configure script to properly look for the gdbm library in $libdir, instead of only looking in /usr/lib.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
------- Additional Comments From wart@kobold.org 2006-11-02 18:04 EST ------- GOOD ==== * Package and spec named appropriately: The upstream name is the simply 'thread', which is far too generic. Following the examples for python and perl modules, the name tcl-thread is acceptable. * Spec file is legible and in Am. English * Source matches upstream: 3c69b4a891590f23bb79a1fa98d879f7 thread2.6.5.tar.gz * No unnecessary BuildRequires * No locales * No shared libraries in the default linker path; the shared library that is produced is loaded by Tcl via dlopen. * RPM_BUILD_ROOT cleaned where appropriate * Not relocatable * No duplicate %files * File permissions look ok * No need for a -devel subpackage * Not a gui program; no need for a .desktop file * Package loads into Tcl as expected and passes its own test suite. * Consistent use of macros * Does not own any directories that it should not own.
MUSTFIX ======= * License does not match upstream. Should be BSD. * License file 'license.terms' not included. * Add the README and ChangeLog files to %doc
* Does not own all directories that it creates. In %files, change %{_libdir}/thread%{version}/* to %{_libdir}/thread%{version}
* Does not build properly on x86_64 in mock. The attached patch fixes the problem.
* The dependency on gdbm is picked up automatically. You can drop Requires: gdbm.
SHOULDFIX ========= * Missing a %check section for running the unit tests.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
------- Additional Comments From jwboyer@jdub.homelinux.org 2006-11-02 23:20 EST ------- Thanks much for the review. I'll get those items fixed up, including the x86_64 issue, tomorrow. I should have fixed the MUSTFIXes before submitting, sorry about that. That's what I get for copying the initial spec from a different package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
------- Additional Comments From wart@kobold.org 2006-11-02 23:39 EST ------- np. I'm a sucker for Tcl package reviews, and I'm interested to see how well this works with tclhttpd. Is there another review on the way that depends on this package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
------- Additional Comments From jwboyer@jdub.homelinux.org 2006-11-03 06:38 EST ------- (In reply to comment #5)
np. I'm a sucker for Tcl package reviews, and I'm interested to see how well this works with tclhttpd. Is there another review on the way that depends on this package?
Not as of yet. However the gitk author is probably going to use the Thread extention soon so that the main window is still responsive while another thread does the refresh/lookups.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
------- Additional Comments From jwboyer@jdub.homelinux.org 2006-11-03 22:03 EST ------- Ok, all comments should be fixed.
Spec URL: http://jdub.homelinux.org/pub/tcl-thread.spec SRPM URL: http://jdub.homelinux.org/pub/tcl-thread-2.6.5-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From wart@kobold.org 2006-11-04 01:21 EST ------- Looks good.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcl-thread - Thread extension for Tcl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213180
jwboyer@jdub.homelinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla