Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: cfourcc - Change the FOURCC of an MPEG4 or DivX video.
https://bugzilla.redhat.com/show_bug.cgi?id=492019
Summary: Review Request: cfourcc - Change the FOURCC of an MPEG4 or DivX video. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: yanstadel@googlemail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://freeki.de/fedora/cfourcc.spec SRPM URL: http://freeki.de/fedora/cfourcc-0.1.2-1.fc10.src.rpm Description: With cfourcc you could change the FOURCC of an MPEG4 or DIVX video on the command line.
The Problem with this programm is, that it only uses make install (wich includes the build-process) instead of make && make install.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492019
Simon Wesp cassmodiah@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cassmodiah@fedoraproject.or | |g Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492019
Tim Lauridsen tim.lauridsen@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tim.lauridsen@googlemail.co | |m
--- Comment #1 from Tim Lauridsen tim.lauridsen@googlemail.com 2009-03-25 08:18:35 EDT --- i think you shall use 'GPVv2+' as license based on the the header in the source file.
<snip> This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. </snip>
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492019
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@freenet.de
--- Comment #2 from Ralf Corsepius rc040203@freenet.de 2009-03-26 00:13:20 EDT --- (In reply to comment #0) Amazing, how broken even trivial Makefiles can be ;)
MUSTFIX: a) Compilation doesn't acknowledge RPM_OPT_FLAGS. Normally, this can be achieved by overriding the Makefile's CFLAGS: make %{?_smp_mflags} CFLAGS="${RPM_OPT_FLAGS}"
However, provided the brokenness of the Makefile, and the simplicity of this package (one single c-file), I am inclined to recommend not to use the Makefile at all, but to compile the file directly: %{__cc} $RPM_OPT_FLAGS -o cfourcc cfourcc.c
b) When having changed compilation to using $RPM_OPT_FLAGS, the compiling the package trips over bugs inside of the sources.
This breakdown needs patching.
c) rpmlint complains: cfourcc.x86_64: W: summary-ended-with-dot Change the FOURCC of an MPEG4 or DivX video. cfourcc.x86_64: E: description-line-too-long With cfourcc you could change the FOURCC of an MPEG4 or DIVX video on the command line.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492019
--- Comment #3 from Ralf Corsepius rc040203@freenet.de 2009-03-26 00:15:05 EDT --- Created an attachment (id=336750) --> (https://bugzilla.redhat.com/attachment.cgi?id=336750) patch to fix b) from comment #2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492019
--- Comment #4 from Yannik Stadelmaier yanstadel@googlemail.com 2009-03-26 04:41:24 EDT --- Created an attachment (id=336761) --> (https://bugzilla.redhat.com/attachment.cgi?id=336761) cfourcc.spec Version 2
Here is the new cfourcc.spec
I changed the description (just added a line break) and included the patch.
Here you can find the new srpm: http://freeki.de/fedora/cfourcc-0.1.2-2.fc10.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492019
Simon Wesp cassmodiah@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(yanstadel@googlem | |ail.com)
--- Comment #5 from Simon Wesp cassmodiah@fedoraproject.org 2009-09-11 01:41:45 EDT --- afairr, yanstadel isn't active in the fedoraproject
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492019
Simon Wesp cassmodiah@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) Resolution| |NOTABUG Flag|needinfo?(yanstadel@googlem | |ail.com) |
package-review@lists.fedoraproject.org