https://bugzilla.redhat.com/show_bug.cgi?id=2232861
Bug ID: 2232861 Summary: Review Request: jsemver - A Java implementation of the Semantic Versioning Specification Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@flyn.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://www.flyn.org/SRPMS/jsemver.spec SRPM URL: https://www.flyn.org/SRPMS/jsemver-0.9.0-16.fc38.src.rpm Description: A Java implementation of the Semantic Versioning Specification Fedora Account System Username: mikep
This package was retired, and I would like to take ownership of it. The only changes I made were to build against the newer Java ABI and drop the maven-javadoc-plugin dependency.
COPR repository: [copr:copr.fedorainfracloud.org:mikep:lulzbot] name=Copr repo for lulzbot owned by mikep baseurl=https://download.copr.fedorainfracloud.org/results/mikep/lulzbot/fedora-$rel... type=rpm-md skip_if_unavailable=True gpgcheck=1 gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/lulzbot/pubkey.gpg repo_gpgcheck=0 enabled=1 enabled_metadata=1
https://bugzilla.redhat.com/show_bug.cgi?id=2232861
W. Michael Petullo mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from W. Michael Petullo mike@flyn.org --- Spec URL: https://www.flyn.org/SRPMS/jsemver.spec SRPM URL: https://www.flyn.org/SRPMS/jsemver-0.9.0-1.fc38.src.rpm
- Use %autorelease/%autochangelog - Use SPDX
https://bugzilla.redhat.com/show_bug.cgi?id=2232861
Tim Semeijn tim@goat.re changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tim@goat.re
--- Comment #2 from Tim Semeijn tim@goat.re --- This is an unofficial review as I am not in the packager group yet.
Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/java/jsemver See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_duplicate_files
This issue seems a false positive as /usr/share/java/jsemver and /usr/share/maven-poms/jsemver both are folders with the same name but contain different files. This can be ignored.
License file ADDITIONAL_LICENSE_INFO is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
File seems to mention additional licensing requirements regarding an exception to the GPLv2 (GNU Classpath Exception). Please verify how this affects licensing and if acceptable to use mark it as %license under %files.
Product: Fedora Version: rawhide Component: Package Review
W. Michael Petullo mike@flyn.org has canceled Package Review package-review@lists.fedoraproject.org's request for W. Michael Petullo mike@flyn.org's needinfo: Bug 2232861: Review Request: jsemver - A Java implementation of the Semantic Versioning Specification https://bugzilla.redhat.com/show_bug.cgi?id=2232861
package-review@lists.fedoraproject.org