[Bug 487097] New: Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ReviewBoard - web based code review tool

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Summary: Review Request: ReviewBoard - web based code review
                    tool
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://informatiq.org/files/reviewboard.spec
SRPM URL: http://informatiq.org/files/ReviewBoard-1.0alpha4-1.fc10.src.rpm

Description: 
I just packaged ReviewBoard, I'm fairly new in packaging and would appreciate a
review of them
it was announced on the fedora-infrastructure mailing list that it is needed,
so here it is.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #1 from Dan Young   2009-02-24 13:34:55 EDT ---
Examining the output of rpmlint run against your SRPM/RPMs is always a good
place to start.

Are you a Fedora Contributor and member of the packager group, or are you
seeking sponsorship?

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #2 from Dan Young   2009-02-24 16:31:58 EDT ---
Review Board also has django-evolution as a dep.

Here's an initial spec:
http://files.mesd.k12.or.us/~dyoung/reviewboard/django-evolution.spec

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Fabian Affolter   2009-03-08 11:28:37 EDT ---
Can you please open Review request for django-evolution?  This is the one for
ReviewBoard ;-)

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Dave Malcolm   2009-03-17 11:18:59 EDT ---
There's already a separate review for django-evolution, in APPROVED state: see
bug 488103.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Jon Stanley  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Depends on|                            |488103

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Bug 487097 depends on bug 488103, which changed state.

Bug 488103 Summary: Review Request: django-evolution - Schema evolution for Django
https://bugzilla.redhat.com/show_bug.cgi?id=488103

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #5 from Fabian Affolter   2009-04-23 09:35:15 EDT ---
AUTHORS, COPYING, NEWS, and README should be placed in %doc.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |487098

--- Comment #6 from Dave Malcolm   2009-05-07 12:05:38 EDT ---
Adding dependency on the review request you filed for Djblets (bug 487098)
since this specfile has a Requires on Djblets.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #7 from Dave Malcolm   2009-05-07 17:55:40 EDT ---
I've taken Dan's work on top of Ramez's, updated it to the latest release
candidate, and fixed some issues.  I renamed the "Djblets" dependency to
"python-djblets" to reflect the change I proposed in bug 487098.
Hope this is all OK.

Updated specfile is here:
http://people.redhat.com/dmalcolm/python/ReviewBoard.spec

Updated SRPM is here:
http://people.redhat.com/dmalcolm/python/ReviewBoard-1.0-0.4.rc1.src.rpm

Output from rpmlint is clean on the SRPM, and on the built RPM gives the
output:
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/post-lock.tmpl
0644
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/pre-lock.tmpl
0644
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/contrib/tools/post-commit 0644
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/post-unlock.tmpl
0644
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/post-revprop-change.tmpl
0644
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/start-commit.tmpl
0644
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/pre-commit.tmpl
0644
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/contrib/conf/reviewboard.fcgi.in
0644
ReviewBoard.noarch: W: devel-file-in-non-devel-package
/usr/lib/python2.4/site-packages/reviewboard/diffviewer/testdata/new_src/foo.c
ReviewBoard.noarch: E: zero-length
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/db/write-lock
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/post-commit.tmpl
0644
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/pre-unlock.tmpl
0644
ReviewBoard.noarch: E: non-executable-script
/usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/pre-revprop-change.tmpl
0644
ReviewBoard.noarch: W: devel-file-in-non-devel-package
/usr/lib/python2.4/site-packages/reviewboard/diffviewer/testdata/orig_src/foo.c

These appear to all be example files or test data, and thus I don't think
they're real problems.

Caveat: I'm doing this all on a RHEL5 box, rather than specifically Fedora.

How's this looking?  Ramez, do you still want to own this package?  Dan?  I'd
be happy to co-maintain.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #8 from ramez hanna   2009-05-13 04:47:52 EDT ---
(In reply to comment #7)
> How's this looking?  Ramez, do you still want to own this package?  Dan?  I'd
> be happy to co-maintain.

Please join in, i am kinda busy at the moment.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Cristian Ciupitu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Cristian Ciupitu   2009-06-15 08:32:44 EDT ---
Are you sure about the "BuildRequires: python-setuptools-devel" dependency? I
was able to build the RPM without it.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #10 from Cristian Ciupitu   2009-06-24 14:44:24 EDT ---
By the way, Review Board 1.0 was just released
(http://www.review-board.org/news/2009/06/20/review-board-10-released), so
maybe a package for 1.0 should be created.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Jan Klepek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Jan Klepek   2009-09-11 07:20:07 EDT ---
any progress on packaging latest version?

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #12 from Dave Malcolm   2009-09-11 11:28:02 EDT ---
Updated for 1.0.1; specfile is here:
http://people.redhat.com/dmalcolm/python/ReviewBoard.spec

and SRPM here:
http://people.redhat.com/dmalcolm/python/ReviewBoard-1.0.1-1.fc11.src.rpm

I dropped the "BuildRequires: python-setuptools-devel" as suggested in comment
#9

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #13 from Dave Malcolm   2009-10-01 10:13:52 EDT ---
(FWIW, my motivation here is that I'm hoping that Fedora Infrastructure can
deploy an instance of reviewboard; see:
https://fedorahosted.org/fedora-infrastructure/ticket/1196
"Deploy Review Board for use by hosted projects")

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #14 from Stephen Gallagher   2009-10-01 11:04:54 EDT ---
Please re-add the "BuildRequires: python-setuptools-devel" to the spec. I was
unable to build it cleanly in mock without this.

I attempted to build on a fully up-to-date F11 x86_64 box on mock using the
fedora-11-x86_64 target.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #15 from Cristian Ciupitu   2009-10-01 11:38:15 EDT ---
(In reply to comment #14)
> Please re-add the "BuildRequires: python-setuptools-devel" to the spec. I was
> unable to build it cleanly in mock without this.
>
> I attempted to build on a fully up-to-date F11 x86_64 box on mock using the
> fedora-11-x86_64 target.

I'm running an up-to-date Fedora 11 x86_64 too I was able to rebuild
ReviewBoard-1.0.1-1.fc11.src.rpm after removing the python-setuptools-devel
package. What errors are you getting?

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Jeffrey C. Ollie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Jeffrey C. Ollie   2009-10-15 11:51:06 EDT ---
Ping?  Any recent action here?

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #17 from Jeremy Katz   2009-10-16 15:28:22 EDT ---
There seems to be missing dependencies on python-pygments and django-evolution
and a newer python-djblets is needed

But beyond that, it seems to be working in some quick setup and testing.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #18 from Dan Young   2009-10-16 19:57:02 EDT ---
(In reply to comment #15)
> (In reply to comment #14)
> > Please re-add the "BuildRequires: python-setuptools-devel" to the spec. I was
> > unable to build it cleanly in mock without this.
> >
> > I attempted to build on a fully up-to-date F11 x86_64 box on mock using the
> > fedora-11-x86_64 target.
>
> I'm running an up-to-date Fedora 11 x86_64 too I was able to rebuild
> ReviewBoard-1.0.1-1.fc11.src.rpm after removing the python-setuptools-devel
> package. What errors are you getting?

A mock build barfs without a BuildRequires on python-setuptools, specifically:

+ /usr/bin/python setup.py build
Traceback (most recent call last):
  File "setup.py", line 15, in <module>
    from setuptools import setup, find_packages
ImportError: No module named setuptools

I've added "BuildRequires: python-setuptools" to fix the above and "Requires:
python-pygments\nRequires: django-evolution" per jkatz in comment #17:
http://files.mesd.k12.or.us/~dyoung/reviewboard/ReviewBoard.spec
http://files.mesd.k12.or.us/~dyoung/reviewboard/ReviewBoard-1.0.1-2.fc11.src...

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Bug 487097 depends on bug 487098, which changed state.

Bug 487098 Summary: Review Request: python-djblets - A collection of useful classes and functions for Django
https://bugzilla.redhat.com/show_bug.cgi?id=487098

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #19 from Stephen Gallagher   2009-12-21 13:40:57 EDT ---
Created an attachment (id=379673)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=379673)
SRPM for ReviewBoard 1.0.5.1

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #20 from Stephen Gallagher   2009-12-21 13:42:55 EDT ---
Created an attachment (id=379674)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=379674)
Specfile for ReviewBoard 1.0.5.1

I updated Dan Young's specfile from
http://files.mesd.k12.or.us/~dyoung/reviewboard/ReviewBoard.spec to build
ReviewBoard 1.0.5.1, now that python-djblets and Django 1.1.1 are available in
Fedora.

I needed to update to Django 1.1.1, as upstream ReviewBoard requires it for
security fixes.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #21 from Stephen Gallagher   2009-12-22 10:35:57 EDT ---
Created an attachment (id=379845)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=379845)
rpmlint output for 1.0.5.1 RPM

Scratch build successfully performed for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1886173

Scratch build successfully performed for Fedora 12:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1886175

rpmlint output attached.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #22 from Dave Malcolm   2009-12-22 11:19:14 EDT ---
I'll have a go at reviewing this

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #23 from Stephen Gallagher   2009-12-22 11:36:45 EDT ---
For the record, this SRPM also builds successfully against EPEL5 (
http://koji.fedoraproject.org/koji/taskinfo?taskID=1886304 ), though we would
certainly need to build its dependencies as well.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #24 from Dave Malcolm   2009-12-22 12:45:45 EDT ---
This is looking good, with 4 issues that need attention (see below).

As I understand things, as this review was opened by Ramez, he would be the
initial owner as things stand.  However it appears from comment #8 that he may
be rather busy.

I spoke with Stephen today and he's keen to get this into Fedora ASAP.

Stephen: are you happy to maintain this?

Ramez: are you still interested in maintaining this package within Fedora?
Dan: are you interested in (co)maintaining it?

So we may want to complete the "review" part of the review, have Stephen open a
fresh review request, close this one as dup of the new, and "grandfather in"
the work done here.  Does that sound OK?

= Issues needing attention =
(i) installation issue on F-12
Stephen's F12 scratch build doesn't install on my laptop F-12 with updates
enabled, but not updates-testing:
Error: Missing Dependency: Django >= 1.1.1 is needed by package
ReviewBoard-1.0.5.1-1.fc12.noarch (/ReviewBoard-1.0.5.1-1.fc12.noarch)
Error: Missing Dependency: python-djblets >= 0.5-0.1.rc1 is needed by package
ReviewBoard-1.0.5.1-1.fc12.noarch (/ReviewBoard-1.0.5.1-1.fc12.noarch)
- latest version of Django in F-12 updates is Django-1.1-4.fc12
- python-djblets doesn't seem to actually be in fedora-updates for f12 yet

Stephen: do you have this installed and working on a machine?

(ii) Source0: URL is 404; need to be changed to:
http://downloads.reviewboard.org/releases/%%7Bname%7D/1.0/%%7Bname%7D-%%7Bve...
(see http://downloads.reviewboard.org/releases/ReviewBoard/1.0/ ; I notice
there's a 1.1 directory as well FWIW)

(iii) desktop files: the rb-site executable has a PyGTK GUI, so would normally
require us to ship a .desktop file.  However it can only be run when supplied a
directory as a command-line argument, hence it wouldn't be meaningful to create
a .desktop file for it.  So this is OK, but please add a comment about the
exception to the specfile.

(iv) Does the package embed all of the requirements for the various SCM
backends?  (How well does this work with git?)  (not easy to check this without
a working install)

= Notes =
Filesystem layout: upstream have structured this code as a library and
supporting tools that can be used to create (potentially) multiple local
instances of ReviewBoard on a host, each stored in an arbitrary directory on
the filesystem.  All information for a specific instance (e.g. config, logs,
tmp) goes below a particular directory for that instance (rather than e.g.
/etc).  I think it's acceptable for our package to reflect how upstream have
structured this.

= Reviewed items =
- naming: name matches that of upstream tarball
- specfile name is good
- packaging guidelines:
  - N-V-R looks good
  - licensing "MIT" in spec matches that of README and of setup.py
  - spec is legible
  - spec follow python norms
  - changelog: OK
  - tags: OK
  - buildroot path uses 2nd recommendation in guidelines
  - buildroot is cleaned
  - %clean is present and correct
  - buildrequirements: successfully scratch-built in Koji
  - textual documentation present in built RPM below
/usr/share/doc/ReviewBoard-1.0.5.1
  - compiler flags/debuginfo packages/devel packages: N/A
  - pkgconfig: N/A
  - shared libraries: N/A
  - packaging static libraries: N/A
  - dup of system libraries: doesn't seem to
  - rpath: N/A for pure python code
  - config files: see note about FHS above
  - initscripts: N/A
  - macros: OK
  - locale handling: no translations present in upstream source
  - scriptlets: N/A
  - code vs content: OK
  - file and dir ownership: OK
  - users and groups: doesn't have its own user
  - web app: uses /usr/lib/python for its data, which seems reasonable
  - /srv: OK
  - patches: none yet
  - epochs: OK
  - Python-specific guidelines: OK
- license: OK
- specfile is legible
- MD5sum: OK
  - tarball in srpm:
16947ddda7ec9df41f243949ec83a950  ReviewBoard-1.0.5.1.tar.gz
  - tarball from upstream:
16947ddda7ec9df41f243949ec83a950  ReviewBoard-1.0.5.1.tar.gz
- rest of the MUST items covered above
- I've tested an earlier version of the rpm and it functions

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #379674|0                           |1
        is obsolete|                            |
               Flag|                            |review?([e-mail]
                   |                            |)

--- Comment #25 from Stephen Gallagher   2009-12-22 14:19:40 EDT ---
Created an attachment (id=379897)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=379897)
Specfile for ReviewBoard 1.0.5.1

I am willing to co-maintain ReviewBoard (but I do not want to be its exclusive
maintainer).

I don't think there's really a need to go through the trouble of opening a
second review request, but if that's The Way It's Done, sure.

Issues:
(i) Dgango 1.1.1-2 is in updates-testing, python-djblets I installed from this
koji build: http://koji.fedoraproject.org/koji/buildinfo?buildID=147983 (I have
submitted this package for updates-testing in F-12, so it should be present
tomorrow)

(ii) Source location fixed. For the record, the 1.1 branch is their unstable
development branch, and I do not intend at the moment to import that.

(iii) Desktop file comment added.

(iv) The package contains all the files necessary to support git, mercurial,
bazaar, clearcase, cvs, perforce and subversion at least. I am unable to test
the suitability of all of them. I have a test environment working with git
successfully using this RPM.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #26 from Stephen Gallagher   2009-12-22 14:20:51 EDT ---
This specfile built successfully in Koji here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1886848

The SRPM and built noarch RPM is also available there.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #28 from Dave Malcolm   2009-12-22 14:40:27 EDT ---
Thanks; I think several of us want to comaintain this package, so I think that
should be OK.

A minor issue: you didn't update the %changelog in your latest specfile

Other than that, this looks good to go.

ACCEPTED.

Setting "fedora-review" flag

Please fix the %changelog before importing the specfile - thanks!

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #29 from Stephen Gallagher   2009-12-22 15:13:37 EDT ---
New Package CVS Request
=======================
Package Name: ReviewBoard
Short Description: Web-based code review tool
Owners: sgallagh dmalcolm
Branches: F-12
InitialCC:

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #30 from Dan Young   2009-12-22 18:53:33 EDT ---
(In reply to comment #24)
> Dan: are you interested in (co)maintaining it?

Sure, I can co-maintain. I'll request the ACL once ReviewBoard lands in
CVS/pkgdb.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #31 from Dan Young   2009-12-22 19:01:59 EDT ---
(In reply to comment #25)
> (i) Dgango 1.1.1-2 is in updates-testing, python-djblets I installed from this
> koji build: http://koji.fedoraproject.org/koji/buildinfo?buildID=147983 (I have
> submitted this package for updates-testing in F-12, so it should be present
> tomorrow)

I submitted python-djblets in bodhi shortly after building:
https://admin.fedoraproject.org/updates/python-djblets-0.5.6-0.fc12

I assume I just did that too late in the day yesterday for RelEng to sign it
for updates-testing today.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Dennis Gilmore  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #32 from Dennis Gilmore   2009-12-23 14:49:33 EDT ---
CVS Done

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #33 from Stephen Gallagher   2010-01-04 09:23:55 EDT ---
ReviewBoard built in Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1900941

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #34 from Stephen Gallagher   2010-01-04 14:52:07 EDT ---
Package Change Request
======================
Package Name: ReviewBoard
New Branches: EL-5
Owners: sgallagh

ReviewBoard is being considered for inclusion in the Fedora Hosted
infrastructure. We need to branch this package to EL-5 for this support.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #35 from Kevin Fenzi   2010-01-04 15:14:29 EDT ---
cvs done.

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #37 from Fedora Update System  2010-01-15 15:44:06 EST ---
ReviewBoard-1.0.5.1-2.1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/ReviewBoard-1.0.5.1-2.1.el5

[Bug 487097] Review Request: ReviewBoard - web based code review tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487097

--- Comment #38 from Fedora Update System  2010-04-01 17:02:30 EDT ---
ReviewBoard-1.0.5.1-2.1.el5 has been pushed to the Fedora EPEL 5 stable
repository.  If problems still persist, please make note of it in this bug
report.