https://bugzilla.redhat.com/show_bug.cgi?id=2138918
Bug ID: 2138918 Summary: Review Request: rubygem-memoizer - Memoize your methods Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: benson_muite@emailplus.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-memoizer/f... SRPM URL: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-memoizer/f... Description: Memoizer caches the results of your method calls, works well with methods that accept arguments or return nil. It's a simpler and more expicit alternative to ActiveSupport::Memoizable Fedora Account System Username: fed500
Comments: a) Dependency of https://github.com/wconrad/ftpd which would like to package. b) rdoc directory currently not packaged due to embedded fonts and javascript. Can be added later once there is a consistent policy.
https://bugzilla.redhat.com/show_bug.cgi?id=2138918
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mtasaka@fedoraproject.org Flags| |fedora-review? Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2138918
--- Comment #1 from Mamoru TASAKA mtasaka@fedoraproject.org --- Some notes
* Probably unneeded BuildRequires - Please check if "BR: rubygem(rake)" is really needed.
- Also we usually try to remove "BR: rubygem(bundler)", as bundler tries to lock the version of other dependency gems, which we don't want as we are using rpm ecosystem.
It seems that removing "require 'bundler/setup'" from spec/spec_helper.rb is sufficient.
* Documentation - "Rakefile" is something like "Makefile in Ruby" and usually this is not considered as documentation.
- Not a blocker, however I would request "README.md" to be packaged into main package, not in -doc, as README.md is expected to be read by everyone using this rpm.
https://bugzilla.redhat.com/show_bug.cgi?id=2138918
--- Comment #2 from Benson Muite benson_muite@emailplus.org --- Thanks for the review. Removed the Rakefile. Removed "BR: rubygem(bundler)". Removed "BR: rubygem(rake)". Put the README.md in the main package.
spec: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-memoizer/f... srpm: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-memoizer/f...
https://bugzilla.redhat.com/show_bug.cgi?id=2138918
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Mamoru TASAKA mtasaka@fedoraproject.org --- Approving.
* Name, EVR, Summary clean * SourceURL, actual source okay, packaged source matches upstream * License appropriate * BuildRequires clean * (generated) Requires sane * %prep, %build, %install, %check okay * %files okay * build on koji successful * installation successful * basic functionality okay * rpmlint sane
========================================================= This package (rubygem-memoizer) is APPROVED by mtasaka =========================================================
https://bugzilla.redhat.com/show_bug.cgi?id=2138918
--- Comment #4 from Kevin Fenzi kevin@scrye.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-memoizer
https://bugzilla.redhat.com/show_bug.cgi?id=2138918
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-01-09 06:06:24
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com