[Bug 285571] New: Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=285571

Summary: Review Request: seekwatcher - IO visualization with
                    blktrace
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL:
 http://people.redhat.com/esandeen/seekwatcher-rpm/seekwatcher.spec

SRPM URL:
 http://people.redhat.com/esandeen/seekwatcher-rpm/seekwatcher-0.7-1.src.rpm

Description:
Seekwatcher generates graphs from blktrace runs to help visualize IO patterns
and performance. It can plot multiple blktrace runs together, making it easy
to compare the differences between different benchmark runs.

You should install the seekwatcher package if you need to visualize detailed
information about IO patterns.

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2007-09-24 05:55 EST -------
rpmlint on SRPM gave me
seekwatcher.src: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages
don't directly need it, section markers may be overridden in rpm's
configuration to provide additional "under the hood" functionality, such as
injection of automatic -debuginfo subpackages.  Add the section, even if
empty.

Where can I find mencoder?

package installation failed with error: Failed dependencies:
        mencoder is needed by seekwatcher-0.7-1.fc8.noarch

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-09-24 06:12 EST -------
Just confirmed on #fedora-devel and this package cannot make into Fedora because
of missing package dependency mencoder.

If by any chance you can use any alternate to mencoder then we can think this
for inclusion in Fedora.

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-09-24 09:08 EST -------
Thanks for the review; I'll add a %build.

Sorry about mencoder, that was a thinko on my part.  seekwatcher can still make
still graphs, just not movies.  So I think we can get it in with limited
functionality.  I'll see about patching it up to remove the option, or something
along those lines.

-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-09-24 09:21 EST -------
Eric how about either trying to build a modular version and submit the mencoder
dependent part to rpmfusion or maybe submit the whole package to rpmfusion ?

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-09-24 10:48 EST -------
hmm apparently the beta1 theora release has png2theora in theora-tools... pity
F8 doesn't have that release, yet... maybe I can ask for just that to be
included in the current package.  Chris Mason would be willing to use those free
tools rather than the mpg stuff.  I'll take a look.

-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-09-24 13:38 EST -------
(In reply to comment #3)
> Thanks for the review; I'll add a %build.

ok
> Sorry about mencoder, that was a thinko on my part.  seekwatcher can still make
> still graphs, just not movies.  So I think we can get it in with limited
> functionality.  I'll see about patching it up to remove the option, or something
> along those lines.

Will be happy to review this then :)

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-09-24 17:46 EST -------
Well, spent too much time on this today :)  png2theora is already in the
libtheora src.rpm we have, just not installed.  I have it making a "movie" but
something is odd; it looks pretty wrong.

-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-10-15 10:14 EST -------
any progress here?

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-10-15 13:14 EST -------
Nope.  The theora guys are stumped too, but the movie comes out wrong.

The static graph side of things works, though.  It's just the animated movies
that don't have a solution at this point.

-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-11-06 12:05 EST -------
I may just patch out the movie-making part, or maybe better yet make it dynamic
so it's available *if* mencoder or other suitable app is found.

Sorry for the delay on this, it's a low priority for me even though I'd like to
get it in.

--Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-11-21 00:09 EST -------
very latest seekwatcher repo has a patch which simply makes the movie options
"go away" if mencoder is not found.  When chris makes that a point release, I'll
make a new package for review.

Thanks,
-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-11-29 15:49 EST -------
See also bug #401681 : Add filtering flags to png_read_png ... the (now) very
latest seekwatcher can use png2theora, and with the fix in the aforementioned
bug, it works.  So, I'll try to wrap this one up soon.

Thanks,
-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-11-29 23:27 EST -------
Ok.  Sorry for the delay... let's try this:

http://people.redhat.com/esandeen/seekwatcher-rpm/seekwatcher-0.8-1.fc8.src....
http://people.redhat.com/esandeen/seekwatcher-rpm/seekwatcher.spec

Thanks!

-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-11-29 23:43 EST -------
looks missing python-devel
In build.log I got
/usr/lib/rpm/pythondeps.sh: line 8: python: command not found

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-11-30 00:06 EST -------
argh, mock produced the rpm so didn't check the logs.

... fix fix fix ...

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-11-30 00:24 EST -------
Added python to reqs/buildreqs

http://people.redhat.com/esandeen/seekwatcher-rpm/seekwatcher-0.8-2.fc8.src....

No complaints from mock this time.

Thanks,
-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide

------- Additional Comments From [e-mail]  2007-11-30 17:45 EST -------
And keeping up with chris....

http://people.redhat.com/esandeen/seekwatcher-rpm/seekwatcher-0.9-1.fc8.src....

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-11-30 22:15 EST -------
(In reply to comment #17)
> And keeping up with chris....
>
> http://people.redhat.com/esandeen/seekwatcher-rpm/seekwatcher-0.9-1.fc8.src....

with this SRPM I got,

seekwatcher.noarch: I: checking
seekwatcher.noarch: W: incoherent-version-in-changelog 0.9 0.9-1.fc8
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

seekwatcher.src: I: checking
seekwatcher.src: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages
don't directly need it, section markers may be overridden in rpm's
configuration to provide additional "under the hood" functionality, such as
injection of automatic -debuginfo subpackages.  Add the section, even if
empty.

Also,
  make sure to keep timestamps
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d17...

And if you like you can use defattr as
defattr(-,root,root,-)

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-11-30 23:26 EST -------
*sigh* I guess maybe I'm just really really bad at this ;-)

Is that rpmlint output?  Ok, now my build log looks clean and rpmlint too.

Ok... once more with feeling:

http://people.redhat.com/esandeen/seekwatcher-rpm/seekwatcher-0.9-2.fc8.src....

Thanks for puttting up with me :)  Hope I've got it now.

-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-12-01 01:36 EST -------
Thanks for updates.

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-12-01 01:43 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
e4c554577e9298fc70fd162bdc647746  seekwatcher-0.9.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ -devel subpackage does exist.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI App.
APPROVED.

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-12-01 10:46 EST -------
Thanks for the review(s)!

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |

------- Additional Comments From [e-mail]  2007-12-01 12:55 EST -------
Can you add a template here with what branches you want and such?
See: 
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure

Reset the fedora-cvs flag when you are ready.

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-12-01 15:04 EST -------
Sorry 'bout that:

New Package CVS Request
=======================
Package Name: seekwatcher
Short Description: Utility for visualizing block layer IO patterns and performance
Owners: sandeen
Branches: F-8
InitialCC:
Cvsextras Commits: yes

Thanks,
-Eric

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

------- Additional Comments From [e-mail]  2007-12-02 00:28 EST -------
Imported & built... thanks everyone!

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

------- Additional Comments From [e-mail]  2008-04-10 11:11 EST -------
Package Change Request
======================
Package Name: seekwatcher
New Branches: EL-5

[Bug 285571] Review Request: seekwatcher - IO visualization with blktrace

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seekwatcher - IO visualization with blktrace

https://bugzilla.redhat.com/show_bug.cgi?id=285571

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-04-10 13:26 EST -------
cvs done.