Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226252
Summary: Merge Review: perl-DBD-Pg Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: rnorwood@redhat.com
Fedora Merge Review: perl-DBD-Pg
http://cvs.fedora.redhat.com/viewcvs/devel/perl-DBD-Pg/ Initial Owner: rnorwood@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-DBD-Pg
https://bugzilla.redhat.com/show_bug.cgi?id=226252
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From panemade@gmail.com 2007-10-22 06:59 EST ------- 1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 1:5.6.1 2)you may like to use simple disttag as "5%{?dist}" only
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-DBD-Pg
https://bugzilla.redhat.com/show_bug.cgi?id=226252
------- Additional Comments From rnorwood@redhat.com 2007-10-24 23:40 EST ------- 1) fixed. 2) Fixed - I, too, hate dots after the %{?dist} tag. I blame spot.
I also fixed the BR: perl-DBI > 1.38 to be BR: perl(DBI) > 1.38 and changed Patch: to be Patch0:
New version is: perl-DBD-Pg-1.49-6.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-DBD-Pg
https://bugzilla.redhat.com/show_bug.cgi?id=226252
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2007-10-25 00:31 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 76b9d6a2f4cbaefcba23380f83998215 DBD-Pg-1.49.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package perl-DBD-Pg-1.49-6.fc8 -> Provides: Pg.so perl(DBD::Pg) = 1.49 perl(DBD::Pg::DefaultValue) perl(DBD::Pg::db) perl(DBD::Pg::dr) perl(DBD::Pg::st) Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libpq.so.5 perl >= 0:5.006001 perl(:MODULE_COMPAT_5.8.8) perl(DBI) perl(DBI) >= 1.38 perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rtld(GNU_HASH)
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-DBD-Pg
https://bugzilla.redhat.com/show_bug.cgi?id=226252
------- Additional Comments From panemade@gmail.com 2007-11-11 02:04 EST ------- Can we CLOSE this review if package is already built and in rawhide?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-DBD-Pg
https://bugzilla.redhat.com/show_bug.cgi?id=226252
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226252
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com Flag| |fedora-cvs?
--- Comment #5 from Petr Pisar ppisar@redhat.com 2012-03-13 10:19:40 EDT --- Package Change Request ====================== Package Name: perl-DBD-Pg Branches: f15 f16 f17 Owners: InitialCC: perl-sig
Please add perl-sig user with watch* permissions only to all Fedora branches.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226252
--- Comment #6 from Jon Ciesla limburgher@gmail.com 2012-03-13 10:39:43 EDT --- Done.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla