11:37 p.m.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252457
Summary: Review Request: prtconf - SPARC OpenPROM dump utility
Product: Fedora
Version: devel
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: dennis(a)ausil.us
QAContact: extras-qa(a)fedoraproject.org
CC: fedora-package-review@redhat.com,notting(a)redhat.com
Spec URL: http://ausil.us/packages/prtconf.spec
SRPM URL: http://ausil.us/packages/prtconf-1.3-6.al3.src.rpm
Description:
This utility will dump SPARC OpenPROM device tree
in the format similar to Solaris prtconf, that is,
in a nicely readable compact format.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
6:51 p.m.
New subject: [Bug 252457] Review Request: prtconf - SPARC OpenPROM dump utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prtconf - SPARC OpenPROM dump utility
https://bugzilla.redhat.com/show_bug.cgi?id=252457
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tibbs(a)math.uh.edu
------- Additional Comments From tibbs(a)math.uh.edu 2007-11-06 19:51 EST -------
There's a koji sparc instance now, isn't there? Could you point to a scratch
build of this? Otherwise I fear you might be waiting a while for a review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
7:59 p.m.
New subject: [Bug 252457] Review Request: prtconf - SPARC OpenPROM dump utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prtconf - SPARC OpenPROM dump utility
https://bugzilla.redhat.com/show_bug.cgi?id=252457
------- Additional Comments From dennis(a)ausil.us 2007-11-06 20:59 EST -------
http://sparc.koji.fedoraproject.org/koji/taskinfo?taskID=30655
Here you go :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
2:48 p.m.
New subject: [Bug 252457] Review Request: prtconf - SPARC OpenPROM dump utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prtconf - SPARC OpenPROM dump utility
https://bugzilla.redhat.com/show_bug.cgi?id=252457
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|devel |rawhide
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody(a)fedoraproject.org |tibbs(a)math.uh.edu
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From tibbs(a)math.uh.edu 2008-01-18 15:48 EST -------
Completely forgot to make it back to this.
It's kind of tough to do a review on an arch you don't have, but:
prtconf.sparc: W: non-standard-group Utilities/System
Not a problem.
prtconf-debuginfo.sparc: E: empty-debuginfo-package
Nothing at all there. The compiler isn't being called with the proper set of
flags, and CFLAGS is overridden in the Makefile.
prtconf.sparc: W: incoherent-version-in-changelog 1.3-7 1.3-6.al3
Maybe Release: didn't get updated with the last change to the package?
prtconf.sparc: E: wrong-script-end-of-line-encoding
/usr/share/prtconf/examples/ultrabook
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/cp1500
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ultra450
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/e10000#2
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/e3000
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ultra5
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ss1000
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ultra2
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ultra1
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ultraAX
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ss2000
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ultra30
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ss20
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ss4
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ss5
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ss2
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ultra250
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/e5000
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ultrabook
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/je1
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ipx
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/s3gx
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/e10000#1
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ss10
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/e4000
prtconf.sparc: E: script-without-shebang /usr/share/prtconf/examples/ss1000e
I'm not sure what these are about. I'm pretty sure they shouldn't be
executable, and they're probably only useful as documentation. (I'd just drop
the "install examples/*" bit from %install and just stick "%doc
examples" in
the %files list. And the untrabook example might as well have a pass through
sed.
Some other bits:
I'm not sure URL is useful; it just points me at the sunsite main page.
The COPYING file needs to be included as %doc.
I can't install or test this package so here's as much review as I can do:
* source files match upstream:
28a9b9d0a680050e33b5ea54aede0f8fcedd51568cd23cd5f3d225fdb608c112
prtconf-1.3.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
X license text included in upstream tarball but is not in the package..
* latest version is being packaged.
* BuildRequires are proper (none)
X compiler flags are not the recommended ones.
* %clean is present.
* package builds in koji (scratch build provided)
X debuginfo package is not complete.
X rpmlint has valid complaints
* final dependencies are sane.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X file permissions odd (executable examples)
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
6:27 p.m.
New subject: [Bug 252457] Review Request: prtconf - SPARC OpenPROM dump utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prtconf - SPARC OpenPROM dump utility
https://bugzilla.redhat.com/show_bug.cgi?id=252457
------- Additional Comments From dennis(a)ausil.us 2008-01-19 19:27 EST -------
all fixed
SPEC: http://ausil.us/packages/prtconf.spec
SRPM: http://ausil.us/packages/prtconf-1.3-8.al3.src.rpm
scratch build: http://sparc.koji.fedoraproject.org/koji/taskinfo?taskID=35109
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
7:33 p.m.
New subject: [Bug 252457] Review Request: prtconf - SPARC OpenPROM dump utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prtconf - SPARC OpenPROM dump utility
https://bugzilla.redhat.com/show_bug.cgi?id=252457
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs(a)math.uh.edu 2008-01-19 20:33 EST -------
Looks good to me; the only remaining rpmlint complaint is
prtconf.sparc: W: incoherent-version-in-changelog 1.3-8 1.3-8.al3
which is due to rpmlint not comprehending the .al3 dist tag and can be ignored.
The examples have been moved to %doc.
The license file is included in the package.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
8:05 p.m.
New subject: [Bug 252457] Review Request: prtconf - SPARC OpenPROM dump utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prtconf - SPARC OpenPROM dump utility
https://bugzilla.redhat.com/show_bug.cgi?id=252457
dennis(a)ausil.us changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs+
------- Additional Comments From dennis(a)ausil.us 2008-01-19 21:05 EST -------
Package Name: prtconf
Short Description: SPARC OpenPROM dump utility
Owners: ausil pjones spot jima
Branches: devel
InitialCC:
Cvsextras Commits: yes
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
9:15 p.m.
New subject: [Bug 252457] Review Request: prtconf - SPARC OpenPROM dump utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prtconf - SPARC OpenPROM dump utility
https://bugzilla.redhat.com/show_bug.cgi?id=252457
------- Additional Comments From tibbs(a)math.uh.edu 2008-03-03 22:15 EST -------
Any reason not to close this?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
11:13 p.m.
New subject: [Bug 252457] Review Request: prtconf - SPARC OpenPROM dump utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: prtconf - SPARC OpenPROM dump utility
https://bugzilla.redhat.com/show_bug.cgi?id=252457
dennis(a)ausil.us changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |NEXTRELEASE
------- Additional Comments From dennis(a)ausil.us 2008-03-04 00:13 EST -------
its checked in and built time to close
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
5924
days inactive
6125
days old
package-review@lists.fedoraproject.org
8 comments
1 participants
participants (1)
-
Red Hat Bugzilla