[Bug 1607091] New: Review Request: gnome-shell-extension-taskwarrior - Taskwarrior integration for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
Bug ID: 1607091 Summary: Review Request: gnome-shell-extension-taskwarrior - Taskwarrior integration for GNOME Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: thozza@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://thozza.fedorapeople.org/gnome-shell-extension-taskwarrior/gnome-shel... SRPM URL: https://thozza.fedorapeople.org/gnome-shell-extension-taskwarrior/gnome-shel... Description: This GNOME shell extension is enabling access to Taskwarrior from the gnome shell taskbar. Fedora Account System Username: thozza
COPR repo: https://copr.fedorainfracloud.org/coprs/thozza/gnome-shell-extension-taskwar...
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Use a more meaningful name for your archive with:
Source0: %url/archive/v%{version}/%{name}-%{version}.tar.gz
- %setup v%{version}.tar.gz -n gnome-extension-taskwarrior-%{version}
Use %autosetup -n gnome-extension-taskwarrior-%{version}
- %dir %{gnome_extensions_dir}/%{uuid} %{gnome_extensions_dir}/%{uuid}/*
Simply use instead:
%{gnome_extensions_dir}/%{uuid}
- Split the description to stay below 80 characters per line:
gnome-shell-extension-taskwarrior.noarch: E: description-line-too-long C This GNOME shell extension is enabling access to Taskwarrior from the gnome shell taskbar.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (v2 or later)", "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gnome-shell-extension-taskwarrior/review- gnome-shell-extension-taskwarrior/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 471040 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: gnome-shell-extension-taskwarrior-4.0-1.fc28.noarch.rpm gnome-shell-extension-taskwarrior-4.0-1.fc28.src.rpm gnome-shell-extension-taskwarrior.noarch: W: spelling-error %description -l en_US taskbar -> task bar, task-bar, tanbark gnome-shell-extension-taskwarrior.noarch: E: description-line-too-long C This GNOME shell extension is enabling access to Taskwarrior from the gnome shell taskbar. gnome-shell-extension-taskwarrior.src: W: spelling-error %description -l en_US taskbar -> task bar, task-bar, tanbark gnome-shell-extension-taskwarrior.src: E: description-line-too-long C This GNOME shell extension is enabling access to Taskwarrior from the gnome shell taskbar. 2 packages and 0 specfiles checked; 2 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
--- Comment #2 from Tomáš Hozza thozza@redhat.com --- Thanks for review.
(In reply to Robert-André Mauchin from comment #1)
- Use a more meaningful name for your archive with:
Source0: %url/archive/v%{version}/%{name}-%{version}.tar.gz
I was not sure how to fixed this with github. I fixed this to download the archive using the name of the upstream project, not the package, to reduce confusion.
- %setup v%{version}.tar.gz -n gnome-extension-taskwarrior-%{version}
Use %autosetup -n gnome-extension-taskwarrior-%{version}
I changed this, although %setup vs. %autosetup is a thing of maintainer preference.
%dir %{gnome_extensions_dir}/%{uuid} %{gnome_extensions_dir}/%{uuid}/*
Simply use instead:
%{gnome_extensions_dir}/%{uuid}
This is cosmetic change. Yes, SPEC is shorter, but I take the %dir to be more explicit. Nevertheless I changed it.
- Split the description to stay below 80 characters per line:
gnome-shell-extension-taskwarrior.noarch: E: description-line-too-long C This GNOME shell extension is enabling access to Taskwarrior from the gnome shell taskbar.
Done.
I updated SPEC, SRPM and COPR: Spec URL: https://thozza.fedorapeople.org/gnome-shell-extension-taskwarrior/gnome-shel... SRPM URL: https://thozza.fedorapeople.org/gnome-shell-extension-taskwarrior/gnome-shel...
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
--- Comment #4 from Tomáš Hozza thozza@redhat.com --- (In reply to Robert-André Mauchin from comment #3)
Package approved.
Thank you!
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
--- Comment #5 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-taskwarrior
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-taskwarrior-4.0-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4423acdfbb
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-taskwarrior-4.0-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-77f2c17c36
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-taskwarrior-4.0-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4423acdfbb
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-taskwarrior-4.0-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-77f2c17c36
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-08-01 13:41:35
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-taskwarrior-4.0-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1607091
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- gnome-shell-extension-taskwarrior-4.0-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com