Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948359
Bug ID: 948359 Summary: Review Request: python-volatility, a digital artifact extraction framework Product: Fedora Version: 19 Component: Package Review Severity: unspecified Priority: unspecified Assignee: nobody@fedoraproject.org Reporter: alevy@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Category: ---
Spec URL: http://people.freedesktop.org/~alon/volatility-fedpkg/python-volatility.spec SRPM URL: http://people.freedesktop.org/~alon/volatility-fedpkg/python-volatility-2.2-...
Description: The Volatility Framework is a completely open collection of tools, implemented in Python under the GNU General Public License, for the extraction of digital artifacts from volatile memory (RAM) samples. The extraction techniques are performed completely independent of the system being investigated but offer unprecedented visibilty into the runtime state of the system. The framework is intended to introduce people to the techniques and complexities associated with extracting digital artifacts from volatile memory samples and provide a platform for further work into this exciting area of research.
$ rpmlint python-volatility.spec python-volatility.spec: W: invalid-url Source0: http://volatility.googlecode.com/files/volatility-2.2.tar.gz HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
I have no idea why it gives this error, since the file is downloadable with wget.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948359
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@fabian-affolter.ch Summary|Review Request: |Review Request: |python-volatility, a |python-volatility - a |digital artifact extraction |digital artifact extraction |framework |framework
--- Comment #1 from Fabian Affolter mail@fabian-affolter.ch --- Just some quick comments:
- Acc. to the package guidelines, the upstream *.egg stuff needs to be removed.
https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-buil... - '%defattr' is obsolete. https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions - %clean is obsolete. https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean - Using macros will make it easier to maintain the package in the future. - 'Group' is obsolete https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag - License is not GPL. It's GPLv2+ (version 2 of the License, or (at your option) any later version.) - The changelog is empty. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - rpmlint output is more than you added. As you can see there are a couple of hints about errors in your spec file: [fab@laptop011 reviews]$ rpmlint python-volatility-2.2-1.fc19.src.rpm python-volatility.src: W: spelling-error %description -l en_US visibilty -> visibility, risibility python-volatility.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment python-volatility.src: E: no-changelogname-tag python-volatility.src: W: invalid-license GPL python-volatility.src: W: invalid-url Source0: http://volatility.googlecode.com/files/volatility-2.2.tar.gz HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 1 errors, 4 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alevy@redhat.com, | |mario.blaettermann@gmail.co | |m Version|19 |rawhide Flags| |needinfo?(alevy@redhat.com)
--- Comment #2 from Mario Blättermann mario.blaettermann@gmail.com --- python-devel is deprecated, use python2-devel instead: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
The initial cleaning of buildroot in %install and the defattr line in %files are obsolete.
(In reply to Alon Levy from comment #0)
$ rpmlint python-volatility.spec python-volatility.spec: W: invalid-url Source0: http://volatility.googlecode.com/files/volatility-2.2.tar.gz HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
I have no idea why it gives this error, since the file is downloadable with wget.
Don't bother with that, it's a common problem with all Googlecode stuff. Doesn't need to be investigated, provided the file is downloadable with wget or any other tool.
https://bugzilla.redhat.com/show_bug.cgi?id=948359
--- Comment #3 from Mario Blättermann mario.blaettermann@gmail.com --- Any news here...?
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com Flags| |needinfo?(alevy@redhat.com)
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |563471 (FE-SECLAB)
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |cickumqt@gmail.com Flags| |needinfo?(alevy@redhat.com)
--- Comment #4 from Christopher Meng cickumqt@gmail.com --- I will take this package, needinfo again.
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | Flags| |needinfo?(alevy@redhat.com)
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(alevy@redhat.com)
--- Comment #23 from Christopher Meng cickumqt@gmail.com --- 2.3.1 is out.
You haven't build it for rawhide.
ping after a month.
https://bugzilla.redhat.com/show_bug.cgi?id=948359
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- python-volatility-2.3.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-volatility-2.3.1-1.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=948359
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- python-volatility-2.3.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-volatility-2.3.1-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=948359
--- Comment #26 from Alon Levy alevy@redhat.com --- Thanks for the ping, updated to 2.3.1, did updates for f19 & f20, did a build for rawhide.
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |python-volatility
https://bugzilla.redhat.com/show_bug.cgi?id=948359
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- python-volatility-2.3.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-volatility-2.3.1-2.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Steve Grubb sgrubb@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sgrubb@redhat.com
--- Comment #28 from Steve Grubb sgrubb@redhat.com --- Out of curiosity, why is this package not pushed?
# yum install python-volatility No package python-volatility available. Error: Nothing to do
https://bugzilla.redhat.com/show_bug.cgi?id=948359
--- Comment #29 from Christopher Meng cickumqt@gmail.com --- (In reply to Steve Grubb from comment #28)
Out of curiosity, why is this package not pushed?
He must be a RDO staff! LOL
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-volatility-2.3.1-1.f | |c19 Resolution|--- |ERRATA Last Closed| |2014-02-09 22:13:27
--- Comment #30 from Fedora Update System updates@fedoraproject.org --- python-volatility-2.3.1-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-volatility-2.3.1-1.f |python-volatility-2.3.1-2.f |c19 |c20
--- Comment #31 from Fedora Update System updates@fedoraproject.org --- python-volatility-2.3.1-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=948359
Alon Levy alevy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(alevy@redhat.com) |
--- Comment #32 from Alon Levy alevy@redhat.com --- Clearing already answered needinfo.
package-review@lists.fedoraproject.org