https://bugzilla.redhat.com/show_bug.cgi?id=1517451
Bug ID: 1517451 Summary: Review Request: gnome-internet-radio-locator Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: oka@oka.no QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-ra... SRPM URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-ra... Description: Locate Internet Radio Stations Fedora Account System Username: oka
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #1 from Michael Schwendt bugs.michael@gmx.net --- *** Bug 1161834 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #2 from Michael Schwendt bugs.michael@gmx.net --- How does this new program related to "girl", which is shipped by rpmfusion?
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3485 -> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3693
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #3 from Ole Aamot oka@oka.no --- The program gnome-internet-radio-locator replaces it and is based on GTK+ 3.0, GNOME Maps, libchamplain and gst-player.
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
mgansser@alice.de mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mgansser@online.de
--- Comment #4 from mgansser@alice.de mgansser@online.de --- new version 1.0.2 is available.
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
ole@gnome.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ole@gnome.org
--- Comment #5 from ole@gnome.org --- Spec URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-ra... SRPM URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-ra... Description: Locate Internet Radio Stations Fedora Account System Username: oka
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #6 from ole@gnome.org --- I have built RPM packages for testing:
Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spe... SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1...
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #7 from ole@gnome.org --- Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spe... SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1... Description: Locate Internet Radio Stations Fedora Account System Username: oka
I have built RPM packages for fc27 and fc28.
https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locat... https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locat...
https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1... https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1...
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #8 from MartinKG mgansser@online.de --- 1. where is the correct link to the SOURCE file: gnome-internet-radio-locator-1.1.1.tar.xz
2. the Group Tag isn't need any longer, please remove it from the spec file. Group: Applications/Internet
3. Can you use the %{url} macro in Source0 Source: %{url}/%{name}-%{version}.tar.xz
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #9 from ole@gnome.org --- Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spe... SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1... Description: Locate Internet Radio Stations Fedora Account System Username: oka
I have built gnome-internet-radio-locator 1.1.2 for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=26591016
I have built a RPM package for fc28 x86_64 from the SRPM:
https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locat...
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #10 from MartinKG mgansser@online.de --- please correct your spec file again !
rpmlint reports:
rpmlint -i -v gnome-internet-radio-locator.x86_64: W: incoherent-version-in-changelog 1.1.2-2 ['1.1.2-1.fc29', '1.1.2-1']
a better description for the %changelog section would:
%changelog * Fri Apr 27 2018 Ole Aamot ole@gnome.org - 1.1.2-1 - Update to 1.1.2
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #11 from ole@gnome.org --- Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spe... SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1...
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #12 from MartinKG mgansser@online.de --- please remove executing gtk-update-icon-cache in %post/%postu/%postrans to update hicolor theme cache
All those scriptles are no longer needed because in hicolor-icon-theme package has file triggers updating theme cache on any change in single dnf/rpm transaction.
https://pagure.io/packaging-committee/issue/736
remove this part from the spec file:
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi
%posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mgansser@online.de Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #13 from ole@gnome.org --- Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spe... SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1...
Build for rawhide on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=26593257
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #14 from MartinKG mgansser@online.de --- 1. please remove %post from the spec file
2. please change the description in the %changelog section to
%changelog * Fri Apr 27 2018 Ole Aamot ole@gnome.org - 1.1.3-1 - Update to 1.1.3
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #15 from ole@gnome.org --- 1. I have removed %post and built and published 1.1.3-3 for Fedora Core 28.
Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spe... SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1...
2. I prefer to keep the style for %changelog comments since version 0.1.0.
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #16 from MartinKG mgansser@online.de --- (In reply to ole from comment #15)
- I have removed %post and built and published 1.1.3-3 for Fedora Core 28.
Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spe... SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1. 3-3.fc28.src.rpm
good
- I prefer to keep the style for %changelog comments since version 0.1.0.
I do not agree with that.
Your Changelog entries should provide a brief summary of the changes done to the package. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
* Mon May 07 2018 Ole Aamot ole@gnome.org - 1.1.3-3 - gnome-internet-radio-locator 1.1.3 build on Fedora Linux
that are completely useless information, like the name of the program and for which version the program was built.
This is a short and meaningful description:
* Mon May 07 2018 Ole Aamot ole@gnome.org - 1.1.3-3 - Update to 1.1.3
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #17 from ole@gnome.org --- There is no such thing as useless information.
There is no useless information in the ChangeLog entry.
I have written the software, I release the software and I maintain the released version for the Fedora release.
I have built 1.4.0-0 on Fedora Core 28 and my ChangeLog entry describes this.
Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spe...
SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.4...
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #18 from MartinKG mgansser@online.de --- please remove %post from the spec file, it's empty and not needed.
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #19 from Robert-André Mauchin zebob.m@gmail.com --- - Remove %post
- Run %make_build after %configure
- Appdata file should now be installed in /usr/share/metainfo . Patch your install scrip appropriately.
appstream-util validate-relax --nonet %{buildroot}/%{_metainfodir}/%{name}.appdata.xml
%{_metainfodir}/%{name}.appdata.xml
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux@googlemail.co | |m
--- Comment #20 from leigh scott leigh123linux@googlemail.com --- Can you remove the DEBIAN file as I doubt the content is useful for Fedora.
%doc AUTHORS DEBIAN NEWS README TODO ChangeLog
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com