[Bug 198247] New: Review Request: libpng10

List overview All Threads
Download

newer

older

[Bug 290011] New: Review Request:...

[Bug 505360] New: Review Request:...

Red Hat Bugzilla

10 Jul 2006 10 Jul '06

3:40 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

Summary: Review Request: libpng10 Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: paul@city-fan.org QAContact: fedora-package-review@redhat.com

Spec URL: http://www.city-fan.org/~paul/extras/Gnome-1/libpng10.spec SRPM URL: http://www.city-fan.org/~paul/extras/Gnome-1/libpng10-1.0.20-1.src.rpm Description:

http://www.city-fan.org/~paul/extras/Gnome-1/libpng10-1.0.20-1.src.rpm

This package was removed from Core for FC6 and I am submitting it to Extras to support the people that still need it for legacy applications. I pulled the package from Core CVS and then tweaked it for Extras and to suit my own cosmetic preferences. I also updated it to the latest upstream version and updated the configuration patch so that it would apply against the new version. Reviewers may consider using rpmdiff to compare the built packages with the versions in Fedora Core 5.

-- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Show replies by date

Red Hat Bugzilla

10 Jul 10 Jul

3:41 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

paul@city-fan.org changed:

Red Hat Bugzilla

4:22 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu

------- Additional Comments From rdieter@math.unl.edu 2006-07-10 12:13 EST ------- Since -devel has files in %{_libdir}/pkgconfig , to avoid possible unowned dirs, it should: Requires: pkgconfig

Red Hat Bugzilla

4:33 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From paul@city-fan.org 2006-07-10 12:24 EST ------- (In reply to comment #1)

...

Since -devel has files in %{_libdir}/pkgconfig , to avoid possible unowned dirs, it should: Requires: pkgconfig

It already does:

%package devel Group: Development/Libraries Summary: Development tools for version 1.0 of libpng Requires: libpng10 = %{version}-%{release}, zlib-devel, pkgconfig

Red Hat Bugzilla

4:37 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From rdieter@math.unl.edu 2006-07-10 12:28 EST ------- doh, sorry for the noise (I'm used to only looking at one Requires: item per line).

Red Hat Bugzilla

14 Jul 14 Jul

5:57 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

paul@city-fan.org changed:

Red Hat Bugzilla

19 Jul 19 Jul

9:50 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

michael@knox.net.nz changed:

------- Additional Comments From michael@knox.net.nz 2006-07-19 17:41 EST ------- Hi, I will review this one for you.

Review for release 1:

* RPM name is OK * Source libpng-1.0.20.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint of libpng10 looks OK * rpmlint of libpng10-devel looks OK * File list of libpng10 looks OK * File list of libpng10-devel looks OK

Notes:

Looks good. I am happy, consider it APPROVED. Please remember to close the bug report once this has been imported into CVS.

Red Hat Bugzilla

9:56 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

michael@knox.net.nz changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED

Red Hat Bugzilla

20 Jul 20 Jul

3:51 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From paul@city-fan.org 2006-07-20 11:42 EST ------- I need some help with this. It's failing to build on x86_64:

http://buildsys.fedoraproject.org/logs/fedora-development-extras/12809-libpn...

At first I thought it was out-of-order building due to a broken Makefile and the use of %{?_smp_mflags}, but that wasn't it. I now suspect it may be to do with the use of assembly code. The strange thing is that it builds fine on x86_64 RHEL3 (the only x86_64 box I have access to).

It could probably be fixed by using the configure script instead of the old Makefiles, but doing it that way I can't find any way to make it produce shared libraries with an soname (libpng.so.2.1.0.20) that lines up with what's in previous Fedora/Red Hat releases.

Red Hat Bugzilla

21 Jul 21 Jul

1:37 a.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From michael@knox.net.nz 2006-07-20 21:28 EST ------- I have a x86-64 machine at work. I will try and load up FC5 on it and take a look.

Red Hat Bugzilla

6:53 a.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From paul@city-fan.org 2006-07-21 02:44 EST ------- Thanks. I plan to replace my home machine with a 64-bit one next month but I'd like to sort this out sooner :-)

Red Hat Bugzilla

25 Jul 25 Jul

10:16 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From michael@knox.net.nz 2006-07-25 18:07 EST ------- argh... bab memory makes for very interesting errors not relating to libpng10.

Hopefully be able to sort out this hardware by weeks end.

Red Hat Bugzilla

10:40 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From michael@knox.net.nz 2006-07-25 18:31 EST ------- Hey Paul, just curious as to why we don't use the configure script in this package?

I added

./autogen.sh %configure

to the spec and it builds on x86-64 now. Though there are files that are not listed in %files

Red Hat Bugzilla

26 Jul 26 Jul

7:05 a.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From paul@city-fan.org 2006-07-26 02:56 EST ------- I'd love to use the configure script. However, I can't find any way to tweak it to get it to produce the right soname. For instance, the libpng10-1.0.18 package in FC5 has libpng.so.2.1.0.18; it follows that this libpng10-1.0.20 package should have libpng.so.2.1.0.20 for compatibility (which is the main reason for the existence of this package) but I can't get the configure script, or more exactly, libtool, to generate an object with that soname.

I think the configure script output could be useful though, as it should produce the correct set of defines to be used when building the package using the older Makefiles.

Red Hat Bugzilla

1 Aug 1 Aug

4:34 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From paul@city-fan.org 2006-08-01 12:25 EST ------- OK, I've managed to persuade, with the aid of a patch, the configure script to generate the correct soname. Can you give this one a try on rawhide x86_64?

SPEC: http://www.city-fan.org/~paul/extras/Gnome-1/libpng10.spec SRPM: http://www.city-fan.org/~paul/extras/Gnome-1/libpng10-1.0.20-3.src.rpm

Red Hat Bugzilla

10:36 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

------- Additional Comments From michael@knox.net.nz 2006-08-01 18:26 EST ------- Build on x86-64 now. Nice work fixing that.

Red Hat Bugzilla

2 Aug 2 Aug

1:16 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198247

paul@city-fan.org changed:

------- Additional Comments From paul@city-fan.org 2006-08-02 09:07 EST ------- 13589 (libpng10): Build on target fedora-development-extras succeeded. Build logs may be found at http://buildsys.fedoraproject.org/logs/fedora-development-extras/13589-libpn...

Thanks for the review and the help.

Red Hat Bugzilla

8 Jul 8 Jul

4:02 a.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libpng10

https://bugzilla.redhat.com/show_bug.cgi?id=198247

bugzilla@redhat.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

10 May 10 May

12:10 p.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=198247

Paul Howarth paul@city-fan.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #14 from Paul Howarth paul@city-fan.org 2010-05-10 08:10:38 EDT --- Package Change Request ====================== Package Name: libpng10 New Branches: EL-6 Owners: pghmcfc

libpng10 has been dropped from EL-6 (it was present in previous EL releases).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

Red Hat Bugzilla

11 May 11 May

4:33 a.m.

New subject: [Bug 198247] Review Request: libpng10

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=198247

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #15 from Kevin Fenzi kevin@tummy.com 2010-05-11 00:33:41 EDT --- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

5552

Age (days ago)

6953

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla