[Bug 892433] New: Review Request: perl-ParseUtil-Domain - Utility for parsing a domain name into its components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Bug ID: 892433 Summary: Review Request: perl-ParseUtil-Domain - Utility for parsing a domain name into its components Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: bochecha@fedoraproject.org
Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-1.fc18.... Description: A tool for parsing domain names. This module makes use of the data provided by the Public Suffix List (http://publicsuffix.org/list/) to parse tlds.
Fedora Account System Username: bochecha
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Mathieu Bridon bochecha@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |891139, 891152, 891165, | |891873, 892423
--- Comment #1 from Mathieu Bridon bochecha@fedoraproject.org --- This requires a few other packages for which I have submitted reviews: - perl-Net-IDN-Encode: bug 891139 - perl-Regexp-Assemble-Compressed: bug 891152 - perl-Test-Routine: bug 891165 - perl-Net-IDN-Nameprep: bug 891873 - perl-Perl6-Export-Attrs: bug 892423
Setting the "Depends On:" field accordingly.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Bug 892433 depends on bug 891165, which changed state.
Bug 891165 Summary: Review Request: perl-Test-Routine - Composable units of assertion https://bugzilla.redhat.com/show_bug.cgi?id=891165
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Bug 892433 depends on bug 892423, which changed state.
Bug 892423 Summary: Review Request: perl-Perl6-Export-Attrs - Perl 6 'is export(...)' trait as a Perl 5 attribute https://bugzilla.redhat.com/show_bug.cgi?id=892423
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Bug 892433 depends on bug 891139, which changed state.
Bug 891139 Summary: Review Request: perl-Net-IDN-Encode - Internationalizing Domain Names in Applications (IDNA) https://bugzilla.redhat.com/show_bug.cgi?id=891139
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
--- Comment #2 from Mathieu Bridon bochecha@fedoraproject.org --- Here's a new package which fixes the issues that the two Petrs have been asking me to fix in my recent submissions, over and over and over and over and...
Thank you Petr and Petr.
Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Bug 892433 depends on bug 891873, which changed state.
Bug 891873 Summary: Review Request: perl-Net-IDN-Nameprep - Stringprep Profile for Internationalized Domain Names (RFC 3491) https://bugzilla.redhat.com/show_bug.cgi?id=891873
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
--- Comment #3 from Petr Šabata psabata@redhat.com --- (In reply to comment #2)
http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. noarch.rpm
Correct link: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
--- Comment #4 from Petr Šabata psabata@redhat.com --- Missing BRs: perl(base) from various sources perl(lib) from various sources perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3 perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9
I suppose changing "tlds" to "TLDs" in the description would nice.
perl_default_filter is not necessary here.
The rest looks okay to me.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
--- Comment #5 from Mathieu Bridon bochecha@fedoraproject.org --- (In reply to comment #3)
(In reply to comment #2)
http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. noarch.rpm
Correct link: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. src.rpm
Sorry about that.
(In reply to comment #4)
Missing BRs: perl(base) from various sources perl(lib) from various sources perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3 perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9
Thanks, fixed.
I suppose changing "tlds" to "TLDs" in the description would nice.
Agreed, fixed.
perl_default_filter is not necessary here.
But does it cause any trouble?
If not, I'd rather keep it there, so that I don't forget to add it if it eventually becomes necessary in the future.
After all, it is a very good thing to have for many Perl packages...
----
Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-3.fc19....
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Petr Šabata psabata@redhat.com --- (In reply to comment #5)
(In reply to comment #3)
(In reply to comment #2)
http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. noarch.rpm
Correct link: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19. src.rpm
Sorry about that.
No worries.
(In reply to comment #4)
Missing BRs: perl(base) from various sources perl(lib) from various sources perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3 perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9
Thanks, fixed.
Ack.
I suppose changing "tlds" to "TLDs" in the description would nice.
Agreed, fixed.
Ack.
perl_default_filter is not necessary here.
But does it cause any trouble?
Nope, it does not.
If not, I'd rather keep it there, so that I don't forget to add it if it eventually becomes necessary in the future.
After all, it is a very good thing to have for many Perl packages...
Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-3.fc19. src.rpm
Approving.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Mathieu Bridon bochecha@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Mathieu Bridon bochecha@fedoraproject.org --- Thanks for the review Petr!
New Package SCM Request ======================= Package Name: perl-ParseUtil-Domain Short Description: Utility for parsing a domain name into its components Owners: bochecha Branches: devel InitialCC: perl-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433
Mathieu Bridon bochecha@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2013-03-07 01:54:08
--- Comment #9 from Mathieu Bridon bochecha@fedoraproject.org --- Thanks Jon for the Git process.
Package built in Rawhide, closing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla