[Bug 488035] New: Review Request: tigervnc - A TigerVNC remote display system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: tigervnc - A TigerVNC remote display system

https://bugzilla.redhat.com/show_bug.cgi?id=488035

Summary: Review Request: tigervnc - A TigerVNC remote display
                    system
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://atkac.fedorapeople.org/tigervnc.spec
SRPM URL:
http://atkac.fedorapeople.org/tigervnc-0.0.90-0.1.20090302svn3621.fc11.src.r...

[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488035

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
            Summary|Review Request: tigervnc -  |Review Request: tigervnc -
                   |A TigerVNC remote display   |A TigerVNC remote display
                   |system                      |system - rename from
                   |                            |TightVNC
               Flag|                            |fedora-review?

[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488035

--- Comment #1 from Dan Horák   2009-03-03 15:15:20 EDT ---
formal review is here, see the notes below:

OK source files match upstream (no difference between the included archive and
fresh svn checkout):
     7957167797dd10c5f3542dab4aaa25834aab41ec 
tigervnc-0.0.90-20090302svn3621.tar.bz2
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK* correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK* is GUI app, desktop file is present

- rpmlint complains a bit
tigervnc-server-module.x86_64: W: no-documentation
 => OK
tigervnc-server-module.x86_64: W: filename-too-long-for-joliet
tigervnc-server-module-0.0.90-0.1.20090302svn3621.fc11.x86_64.rpm
 => OK
tigervnc-server.x86_64: W: incoherent-init-script-name vncserver
 => OK
tigervnc.src: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line 1)
 => please fix

- there is new version of "icon-cache" scriptlets approved (IIRC), but not yet
moved from Drafts, so keep the current one
- drop "--vendor fedora" when install the desktop file
- you can include unix/README as %doc, it contains some acknowledgments that
would be nice to distribute

[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488035

--- Comment #2 from Adam Tkac   2009-03-03 15:26:21 EDT ---
Updated package:

http://atkac.fedorapeople.org/tigervnc-0.0.90-0.2.20090302svn3621.fc11.src.r...
http://atkac.fedorapeople.org/tigervnc.spec

[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488035

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Dan Horák   2009-03-03 15:29:40 EDT ---
All issues fixed, package is APPROVED.

[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488035

Adam Tkac  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Adam Tkac   2009-03-03 15:31:14 EDT ---
New Package CVS Request
=======================
Package Name: tigervnc
Short Description: A TigerVNC remote display system
Owners: atkac
Branches: devel
InitialCC:

[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488035

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #5 from Kevin Fenzi   2009-03-03 15:40:15 EDT ---
cvs done.

[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488035

Adam Tkac  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488035

Patrice Dumas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Patrice Dumas   2009-03-10 10:07:49 EDT ---
tightvnc (and, incidentaly, vnc/realvnc) should, in my opinion, be properly
orphaned, especially tightvnc that had a release in [Mar 05, 2009] according to
the web site.