[Bug 2331268] New: Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Bug ID: 2331268
           Summary: Review Request: extension-manager - A native way of
                    managing GNOME extensions
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-rawh...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-rawh...
Description: 
The tool supports:
    Browsing and searching extensions from extensions.gnome.org
    Installation and Removal
    Enabling and Disabling
    Updating in-app (GNOME 43+)
    Screenshots & Images
    Ratings & Comments
    Translations (add your language!)

Fedora Account System Username: rrahl0

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[e-mail]
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED

--- Comment #1 from Neal Gompa  ---
Taking this review.

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/mjakeman
                   |                            |/extension-manager

--- Comment #2 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8371529
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #3 from Richard Rahl  ---
Updated spec file:
Spec URL:
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-rawh...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-rawh...

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #4 from Fedora Review Service  ---
Created attachment 2061995
  --> https://bugzilla.redhat.com/attachment.cgi?id=2061995&action=edit
The .spec file difference from Copr build 8371529 to 8374270

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged

--- Comment #5 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8374270
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #7 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8449786
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #8 from Richard Rahl  ---
Updated the spec file to the latest version:
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-rawh...
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-rawh...

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #9 from Richard Rahl  ---
hm, for some reason rawhide doesn't have the new build in it's directory.
here are the 42 versions:
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-42-x...
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-42-x...

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Tadej Janež  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Tadej Janež  ---
Hey, I'm interesting in having Extension Manager in Fedora.

What's the progress with the review?

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #11 from Richard Rahl  ---
hopefully everything is updated for 45,
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-44-x...
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-44-x...

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #12 from Fedora Review Service  ---
Created attachment 2154542
  --> https://bugzilla.redhat.com/attachment.cgi?id=2154542&action=edit
The .spec file difference from Copr build 8449786 to 10866217

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #13 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10866217
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #14 from Neal Gompa  ---
This package has a few errors:
> Source0:        %{url}/archive/v%{version}.tar.gz

This should be "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
> %autosetup

This should be "%autosetup -C"
> %build
> %meson \
>   -Dbacktrace=false
> %meson_build

This should be split into two, like so:

"""
%conf
%meson -Dbacktrace=false

%build
%meson_build
"""

From the template:
> [ ]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/icons/hicolor,
>      /usr/share/icons/hicolor/symbolic/apps,
>      /usr/share/icons/hicolor/scalable/apps,
>      /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor/symbolic

You're missing "Requires: hicolor-icon-theme".

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review+              |fedora-review?

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #15 from Richard Rahl  ---
so updated everything again
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-44-x...
https://download.copr.fedorainfracloud.org/results/rrahl0/fedora/fedora-44-x...

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #16 from Fedora Review Service  ---
Created attachment 2154551
  --> https://bugzilla.redhat.com/attachment.cgi?id=2154551&action=edit
The .spec file difference from Copr build 10866217 to 10866618

[Bug 2331268] Review Request: extension-manager - A native way of managing GNOME extensions

https://bugzilla.redhat.com/show_bug.cgi?id=2331268

--- Comment #17 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10866618
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.