[Bug 2069413] New: Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413

            Bug ID: 2069413
           Summary: Review Request: rust-ciborium-io - Simplified
                    Read/Write traits for no_std usage
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: nobody(a)fedoraproject.org
          Reporter: pbrobinson(a)gmail.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



SPEC: https://pbrobinson.fedorapeople.org/rust-ciborium-io.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-ciborium-io-0.2.0-1.fc36.src.rpm

Description:
Simplified Read/Write traits for no_std usage

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=84851013

FAS: pbrobinson


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413

Peter Robinson <pbrobinson(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |rust-ciborium-io
           Doc Type|---                         |If docs needed, set a value




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413

Peter Robinson <pbrobinson(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2069415





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2069415
[Bug 2069415] Review Request: rust-ciborium-ll - Low-level CBOR codec
primitives
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413

Peter Robinson <pbrobinson(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2069418 (rust-ciborium)





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2069418
[Bug 2069418] Review Request: rust-ciborium - Serde implementation of CBOR
using ciborium-basic
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413

Fabio Valentini <decathorpe(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
                 CC|                            |decathorpe(a)gmail.com
           Assignee|nobody(a)fedoraproject.org    |decathorpe(a)gmail.com



--- Comment #1 from Fabio Valentini <decathorpe(a)gmail.com&gt; ---
This crate does not contain license files.
Both the MIT and Apache-2.0 licenses require redistributed sources to contain a
copy of the license text.

It looks like dcavalca fixed this issue upstream, but there's no release that
has this change yet:
https://github.com/enarx/ciborium/commit/b77f979c35a00f1fc65fb09bcf452e6c...

In the meantime, please include the LICENSE* files from the upstream project as
separate sources in this package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413

Peter Robinson <perobins(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |perobins(a)redhat.com



--- Comment #3 from Peter Robinson <perobins(a)redhat.com&gt; ---
They fixed the license issue upstream:
https://github.com/enarx/ciborium/commit/b77f979c35a00f1fc65fb09bcf452e6c...


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413



--- Comment #4 from Peter Robinson <pbrobinson(a)gmail.com&gt; ---
I'll add the license as a source in the mean time


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413



--- Comment #5 from Peter Robinson <pbrobinson(a)gmail.com&gt; ---
Updated/fixed (not sure how review bumps work with autospec but they're updated
on the original links)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413

Fabio Valentini <decathorpe(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|NEW                         |POST



--- Comment #6 from Fabio Valentini <decathorpe(a)gmail.com&gt; ---
>  not sure how review bumps work with autospec but they're updated
> on the original links 
That's fine with me.

>  Source2:       
> https://github.com/enarx/ciborium/blob/main/ciborium/LICENSE 
This is a link to an HTML page on GitHub you probably meant to use the URL to
the raw file:
Source2:        https://github.com/enarx/ciborium/raw/b77f979/ciborium/LICENSE

Please fix this before importing the package (and you could use Source1 instead
of Source2, since there is no Source1).

You can also drop this (now inaccurate) comment from the .spec file's %files
section:
# FIXME: no license files detected

And please use "%license %{crate_instdir}/LICENSE" instead of "%license
LICENSE".
This will result in the file being included only once in the built RPM files
instead of twice.
That string also matches what will be generated once the published crate will
contain the LICENSE file.

But these are all minor issues that you can fix when importing the package,
otherwise LGTM.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413



--- Comment #7 from Jens Petersen <petersen(a)redhat.com&gt; ---
SCM repo created (cleaned up after backtrace manually)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413

Peter Robinson <pbrobinson(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |RAWHIDE
             Status|POST                        |CLOSED
        Last Closed|                            |2022-05-07 22:08:57



--- Comment #8 from Peter Robinson <pbrobinson(a)gmail.com&gt; ---
Small bits fixed, imported


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413



--- Comment #9 from Fabio Valentini <decathorpe(a)gmail.com&gt; ---
You still imported the GitHub HTML page for the LICENSE instead of the raw
plain text.
Please fix this.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2069413

[Bug 2069413] Review Request: rust-ciborium-io - Simplified Read/Write traits for no_std usage

https://bugzilla.redhat.com/show_bug.cgi?id=2069413



--- Comment #10 from Peter Robinson <pbrobinson(a)gmail.com&gt; ---
Fixed, not exactly sure what went wrong there, it wasn't intentional:
https://src.fedoraproject.org/rpms/rust-ciborium-io/c/6ba148a18bb52f99cf7...


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2069413