https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Bug ID: 1121853 Summary: Review Request: perl-Text-Clip - Clip and extract text in clipboard-like way Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rc040203@freenet.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Text-Clip.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Text-Clip-0.0014-1.fc22.src.r... Description: Text::Clip allows you to mark/slice up a piece of text. String matching (by regular expression, etc.) is used to place marks. The first mark lets you access the text preceding and following the mark. Subsequent marks allow you to slurp up the text "clipped" between the marks. Fedora Account System Username: corsepiu
This package is a dependency of an optional tool being used inside of rt-4.0.x's source tree.
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1121934
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1121934 [Bug 1121934] Review Request: perl-Term-EditorEdit - Edit a document via $EDITOR
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar ppisar@redhat.com --- Standalone spec will be used for this review.
URL and Source0 are usable. Ok. Source archive is original (SHA-256: 6f5b134a96a22ac9f314a996188955f4c631eecae5057e187330b4b1727adb4f). Ok. Summary verified from lib/Text/Clip.pm. Ok. Description verified from lib/Text/Clip.pm. Ok. License verified from lib/Text/Clip.pm, README. Ok. No XS code, noarch BuildArch is Ok. All build-requires are declared. Ok. All test pass. Ok.
$ rpmlint perl-Text-Clip.spec ../SRPMS/perl-Text-Clip-0.0014-1.fc22.src.rpm ../RPMS/noarch/perl-Text-Clip-0.0014-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Text-Clip-0.0014-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Jul 22 15:40 /usr/share/doc/perl-Text-Clip -rw-r--r-- 1 root root 646 Jun 1 2010 /usr/share/doc/perl-Text-Clip/Changes -rw-r--r-- 1 root root 1305 Jun 1 2010 /usr/share/doc/perl-Text-Clip/README -rw-r--r-- 1 root root 2404 Jul 22 15:40 /usr/share/man/man3/Text::Clip.3pm.gz drwxr-xr-x 2 root root 0 Jul 22 15:40 /usr/share/perl5/vendor_perl/Text -rw-r--r-- 1 root root 6772 Jun 1 2010 /usr/share/perl5/vendor_perl/Text/Clip.pm File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Text-Clip-0.0014-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Any::Moose) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Text-Clip-0.0014-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Text::Clip) = 0.0014 1 perl-Text-Clip = 0.0014-1.fc22 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Text-Clip-0.0014-1.fc22.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7177793). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Ralf Corsepius rc040203@freenet.de --- Thanks for the review!
New Package SCM Request ======================= Package Name: perl-Text-Clip Short Description: Clip and extract text in clipboard-like way Upstream URL: http://search.cpan.org/dist/Text-Clip/ Owners: corsepiu Branches: f19 f20 f21 InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- perl-Text-Clip-0.0014-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Text-Clip-0.0014-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- perl-Text-Clip-0.0014-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Text-Clip-0.0014-1.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2014-07-23 02:57:01
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |perl-Text-Clip-0.0014-1.fc1 | |9 Resolution|NEXTRELEASE |ERRATA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-Text-Clip-0.0014-1.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1121853
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-Text-Clip-0.0014-1.fc1 |perl-Text-Clip-0.0014-1.fc2 |9 |0
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- perl-Text-Clip-0.0014-1.fc20 has been pushed to the Fedora 20 stable repository.
package-review@lists.fedoraproject.org