[Bug 2181029] New: Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

Bug ID: 2181029
           Summary: Review Request: rust-userfaultfd-sys - Low-level
                    bindings for userfaultfd functionality on Linux
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://github.com/dm0-/copr-firecracker/raw/fedora/rust-userfaultfd-sys.spe...
SRPM URL:
https://github.com/dm0-/copr-firecracker/raw/fedora/rust-userfaultfd-sys-0.4...
Description: Low-level bindings for userfaultfd functionality on Linux.
Fedora Account System Username: dm0

This is a dependency of the userfaultfd crate.  The spec is automatically
generated, except to add a patch to switch the bindgen version to one available
in Fedora and to disable tests by default (they expect exact matches of old
kernel feature flags and fail).

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://crates.io/crates/us
                   |                            |erfaultfd-sys

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5696269
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2181028

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2181028
[Bug 2181028] Review Request: rust-userfaultfd - Rust bindings for the Linux
userfaultfd functionality

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[e-mail]
              Flags|                            |fedora-review+
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Fabio Valentini  ---
Package looks good to me, just two comments:

1. You can partially automate generating patches for Cargo.toml files with
"rust2rpm -p".

This also ensures that any changes to Cargo.toml that can affect contents of
generated spec files are taken into account correctly (i.e. cargo metadata
that's used for generating the spec file is loaded *after* the patch is
applied).

2. When I previously worked on this package (before it was removed from Fedora
37+), I was able to run most tests:

https://src.fedoraproject.org/rpms/rust-userfaultfd-sys/blob/f36/f/rust-user...

It might be worth investigating if skipping this one test still makes the rest
of the test suite pass.

=====

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (test suite is disabled with
justification)
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

You can now proceed with filing the unretirement request:
https://pagure.io/releng/new_issue (select package_unretirement template in
issue "Types" dropdown)

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

--- Comment #3 from [e-mail] ---
I've updated this package to re-enable tests by default and skip the broken one
and to replace the patch with the automatic format.

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #5 from Fedora Update System  ---
FEDORA-2023-39a28215e1 has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-39a28215e1

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2023-03-27 13:26:49

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

--- Comment #7 from Fabio Valentini  ---
(In reply to fedora.dm0 from comment #3)
> I've updated this package to re-enable tests by default and skip the broken
> one and to replace the patch with the automatic format.

Great, looks good to me. Thanks!

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

--- Comment #8 from Fedora Update System  ---
FEDORA-2023-77e17cf235 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-77e17cf235 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-77e17cf235

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

--- Comment #9 from Fedora Update System  ---
FEDORA-2023-39a28215e1 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-39a28215e1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

--- Comment #10 from Fedora Update System  ---
FEDORA-2023-77e17cf235 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2181029] Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux

https://bugzilla.redhat.com/show_bug.cgi?id=2181029

--- Comment #11 from Fedora Update System  ---
FEDORA-2023-39a28215e1 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.