[Bug 226165] New: Merge Review: mt-st

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226165

Summary: Merge Review: mt-st
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: mt-st

http://cvs.fedora.redhat.com/viewcvs/devel/mt-st/
Initial Owner: [e-mail]

[Bug 226165] Merge Review: mt-st

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mt-st

https://bugzilla.redhat.com/show_bug.cgi?id=226165

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

------- Additional Comments From [e-mail]  2007-09-05 07:02 EST -------
Package Change Request
======================
Package Name: mt-st
Updated Fedora Owners: [e-mail]

[Bug 226165] Merge Review: mt-st

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mt-st

https://bugzilla.redhat.com/show_bug.cgi?id=226165

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 226165] Merge Review: mt-st

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mt-st

https://bugzilla.redhat.com/show_bug.cgi?id=226165

------- Additional Comments From [e-mail]  2007-09-05 07:14 EST -------
Agreed with ownership transition.

[Bug 226165] Merge Review: mt-st

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mt-st

https://bugzilla.redhat.com/show_bug.cgi?id=226165

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |

------- Additional Comments From [e-mail]  2007-09-05 09:10 EST -------
canceling request, it's now ok (via pkgdb)

[Bug 226165] Merge Review: mt-st

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226165

Miroslav Lichvar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

[Bug 226165] Merge Review: mt-st

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226165

Miroslav Lichvar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|                            |fedora-review?

--- Comment #4 from Miroslav Lichvar   2009-12-01 11:55:26 EDT ---
Review follows:

OK source files match upstream:
fdd5f5ec673c9f630a102ceff7612774  mt-st-1.1.tar.gz

OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock.
OK debuginfo package looks complete.
NO rpmlint is silent.
mt-st.x86_64: W: service-default-enabled /etc/rc.d/init.d/stinit
mt-st.x86_64: E: no-status-entry /etc/rc.d/init.d/stinit
mt-st.x86_64: W: no-reload-entry /etc/rc.d/init.d/stinit
mt-st.x86_64: E: subsys-not-used /etc/rc.d/init.d/stinit
mt-st.x86_64: W: incoherent-init-script-name stinit ('mt-st', 'mt-std')

Enabled by default and incoherent name are ok, but the script should be
probably updated to match the Fedora init script guidelines.

OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK scriptlets are sane.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

[Bug 226165] Merge Review: mt-st

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226165

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Dan Horák   2009-12-02 05:46:09 EDT ---
The stinit initscript was recently updated in F-12 and rawhide (see bug 541592
for details) and it doesn't start any daemon, but it does only a one-time
initialization of tape devices, so I think it can live as it is.

[Bug 226165] Merge Review: mt-st

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226165

Miroslav Lichvar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |RAWHIDE
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Miroslav Lichvar   2009-12-02 06:05:55 EDT ---
Ok, thanks. The package is APPROVED.