Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Product: Fedora Extras Version: devel Platform: All URL: http://search.cpan.org/dist/Catalyst-Manual/ OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: fedora-package-review@redhat.com
SRPM URL: http://home.comcast.net/~ckweyl/perl-Catalyst-Manual-5.700701-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Catalyst-Manual.spec
Description: This is the manual to the Catalyst web framework.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |perl-Catalyst-Manual
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |238238 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
------- Additional Comments From rc040203@freenet.de 2007-04-30 04:40 EST ------- Could you explain this?
# this is actually better done in perl-Catalyst-Runtime %exclude %{_mandir}/man3/Catalyst::Manual.3*
It doesn't seem right to me to exclude the documentation of the primary perl-module being within a package (Here: perl(Catalyst::Manual))
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
------- Additional Comments From cweyl@alumni.drew.edu 2007-04-30 11:28 EST ------- Yes -- perl-Catalyst-Runtime actually includes a manpage for Catalyst::Manual, one that is (oddly) more useful than the one included in this package. Given that we'd have a conflict, I chose the one that seemed more useful.
Looking back over the spec, because of this it'd probably make more sense to also require perl(Catalyst).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |panemade@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2007-06-05 07:04 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 70f872c92533a39ca6893871ec4d3223 Catalyst-Manual-5.700701.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/pod-coverage....ok t/pod.............ok All tests successful. Files=2, Tests=20, 1 wallclock secs ( 0.78 cusr + 0.03 csys = 0.81 CPU) + exit 0 + Provides: perl(Catalyst::Manual) = 5.700701 + Requires: perl(:MODULE_COMPAT_5.8.8) APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
------- Additional Comments From cweyl@alumni.drew.edu 2007-06-05 10:56 EST ------- New Package CVS Request ======================= Package Name: perl-Catalyst-Manual Short Description: Catalyst web framework manual Owners: cweyl@alumni.drew.edu Branches: FC-5, FC-6, F-7, devel InitialCC: fedora-perl-devel-list@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From tcallawa@redhat.com 2007-06-05 11:14 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
------- Additional Comments From cweyl@alumni.drew.edu 2007-06-05 11:52 EST ------- Imported and building.
Thanks for the review! :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Manual - Catalyst web framework manual Alias: perl-Catalyst-Manual
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238232
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
package-review@lists.fedoraproject.org