Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: leksah - An IDE for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Summary: Review Request: leksah - An IDE for Haskell Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: high Priority: high Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lakshminaras2002@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com, fedora-haskell-list@redhat.com Estimated Hours: 0.0 Classification: Fedora
SPEC file URL: http://narasim.fedorapeople.org/leksah.spec
SRPM URL: http://narasim.fedorapeople.org/leksah-0.8.0.8-1.fc14.src.rpm
leksah package does not build with ghc-7.0.1. The plan is to have leksah for Fedora 14 (and 13) initially. Once a upstream package that builds with 7.0.1 is available, that will be used for F15 and later.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |664140(leksah-server)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |634048(Haskell-pkg-reviews)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |leksah
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|high |medium Severity|high |medium
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |696982(ghc-strict)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #1 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-06-12 05:01:06 EDT --- Spec file : http://narasim.fedorapeople.org/package_reviews/leksah.spec
SRPM file : http://narasim.fedorapeople.org/package_reviews/leksah-0.10.0.4-1.fc14.src.r...
rpmlint output: leksah.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum The value of this tag appears to be misspelled. Please double-check.
leksah.i686: W: no-manual-page-for-binary leksah Each executable in standard binary directories should have a man page.
ghc-leksah-prof.i686: E: devel-dependency ghc-leksah-devel Your package has a dependency on a devel package but it's not a devel package itself.
ghc-leksah-prof.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
ghc-leksah-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/leksah-0.10.0.4/libHSleksah-0.10.0.4_p.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.
4 packages and 1 specfiles checked; 1 errors, 4 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |petersen@redhat.com Flag| |fedora-review?
Bug 673776 depends on bug 664140, which changed state.
Bug 664140 Summary: Review Request: leksah-server - Package that provides the interface to GHC-API for leksah https://bugzilla.redhat.com/show_bug.cgi?id=664140
What |Old Value |New Value ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA Resolution| |ERRATA Status|ON_QA |CLOSED
--- Comment #2 from Jens Petersen petersen@redhat.com 2011-06-24 00:08:27 EDT --- Minor detail/nitpicking but guess date of latest changlog entry is wrong. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #3 from Jens Petersen petersen@redhat.com 2011-06-24 00:09:16 EDT --- Do you mind updating the packaging to cabal2spec-0.23.2?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #4 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-06-24 00:40:38 EDT ---
Minor detail/nitpicking but guess date of latest changlog entry is wrong. :)
No problems. Thanks for pointing it out. Will update the package to the latest cabal2spec and post the links here.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #5 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-06-26 12:43:40 EDT --- Updated spec file and srpm link
http://narasim.fedorapeople.org/package_reviews/leksah.spec
http://narasim.fedorapeople.org/package_reviews/leksah-0.10.0.4-2.fc15.src.r...
rpmlint output:
rpmlint -i leksah.spec ~/rpmbuild/RPMS/x86_64/leksah-0.10.0.4-2.fc15.x86_64.rpm ~/rpmbuild/RPMS/x86_64/ghc-leksah-0.10.0.4-2.fc15.x86_64.rpm ~/rpmbuild/RPMS/x86_64/ghc-leksah-devel-0.10.0.4-2.fc15.x86_64.rpm ~/rpmbuild/SRPMS/leksah-server-0.10.0.4-2.fc15.src.rpm
leksah.x86_64: W: no-manual-page-for-binary leksah Each executable in standard binary directories should have a man page.
4 packages and 1 specfiles checked; 0 errors, 1 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #6 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-06-26 14:05:55 EDT ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=3162336
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #7 from Jens Petersen petersen@redhat.com 2011-06-27 05:51:21 EDT --- Thanks - I had a quick look over the package and basically looks ok.
I am curious why it BRs ImageMagick?
BTW have you posted the leksah.cabal patch upstream? It would be good to get it integrated I guess.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #8 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-06-27 07:20:05 EDT --- Ok. Thanks
There is a convert program supplied as part of ImageMagick. This is used by the spec to convert leksah.png image to be suitable for an icon in start menu.
Yes, I will send the patch. Just fyi, both leksah and yi fail to build ghc-7.0 because of this issue http://hackage.haskell.org/trac/hackage/ticket/656
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #9 from Jens Petersen petersen@redhat.com 2011-06-27 23:53:59 EDT --- Ok, about the GPL+ license comment: it should go immediately above the License field, not in the changelog. Sorry same applies for ltk and leksah-server - just noticed now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #10 from Jens Petersen petersen@redhat.com 2011-06-27 23:57:40 EDT --- Just a style point, but slightly inconsistent vertical spacing: I recommend either to use single or double newline consistently between sections for readability (exception is %description which a package subsection).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #11 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-06-28 00:10:33 EDT --- Ok, will do the changes and upload the spec.I will push changes for leksah-server into rawhide. For f14 and f15, will withdraw the current update and create a new one. Thanks,
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #12 from Jens Petersen petersen@redhat.com 2011-06-28 00:14:55 EDT --- Also are %help_manual and %mime_file needed?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #13 from Jens Petersen petersen@redhat.com 2011-06-28 00:20:33 EDT --- Created attachment 510192 --> https://bugzilla.redhat.com/attachment.cgi?id=510192 leksah.spec-1.patch
Couple of suggestions:
I think the description doesn't need the url or email address. (the homepage could go to the URL field though one can also get there from hackage so maybe not needed.)
I personally prefer to list just a smaller set of dependencies whose closure includes all the deps you list, but not a blocker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(lakshminaras2002@ | |gmail.com)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(lakshminaras2002@ | |gmail.com) |
--- Comment #14 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-07-02 01:49:40 EDT --- Updated spec file and srpm
http://narasim.fedorapeople.org/package_reviews/leksah.spec
http://narasim.fedorapeople.org/package_reviews/leksah-0.10.0.4-3.fc14.src.r...
Applied patch from previous comment. Also removed leksah_manual and leksah_mime definitions.
Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Bug 673776 depends on bug 696982, which changed state.
Bug 696982 Summary: Review Request: ghc-strict - Haskell library providing strict data types https://bugzilla.redhat.com/show_bug.cgi?id=696982
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ON_QA |CLOSED
--- Comment #15 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-07-12 07:03:41 EDT --- Updated spec file and srpm
http://narasim.fedorapeople.org/package_reviews/leksah.spec
http://narasim.fedorapeople.org/package_reviews/leksah-0.10.0.4-3.fc15.src.r...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #16 from Jens Petersen petersen@redhat.com 2011-07-19 06:31:47 EDT --- I don't think leksah should not require ghc-leksah explicitly. So please drop the Requries unless there is a special reason for it.
Also I am not sure it is a good idea to resize the icon. If no special reason for it I suggest not to. eg gnome-shell uses rather large icons. If scaled down then the quality will fall: I have a patch I can attach for that to save time.
Here is the review:
+:ok, NA: not applicable
MUST Items: [+] MUST: rpmlint output
leksah.x86_64: W: no-manual-page-for-binary leksah
leksah is a GUI application: I don't think a manpage is really necessary.
[+] MUST: Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [+] MUST: Packaging Guidelines. [+] MUST: Licensing Guidelines [+] MUST: License field in the package spec file must match actual license. Source files state GPL [+] MUST: include license files in %doc if available in source [+] MUST: The spec file must be written in American English and be legible. [+] MUST: source md5sum matches upstream release b8f788c34fd7ac9ffb9a0e918e519291 leksah-0.10.0.4.tar.gz [+] MUST: must successfully compile and build into binary rpms on one main arch [+] MUST: if necessary use ExcludeArch for other archs [+] MUST: All build dependencies must be listed in BuildRequires [NA] MUST: use %find_lang macro for .po translations [NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [+] MUST: A package must own all directories that it creates. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissable content. [NA] MUST: Large documentation files should go in a doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [NA] MUST: Static libraries must be in a -static package. [NA] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items: [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: If scriptlets are used, those scriptlets must be sane.
Package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #17 from Jens Petersen petersen@redhat.com 2011-07-20 03:58:32 EDT --- Created attachment 513944 --> https://bugzilla.redhat.com/attachment.cgi?id=513944 leksah.spec-2.patch
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #18 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-07-20 09:17:12 EDT --- Thanks for the review.
Yes. I remember that ghc-leksah, although needed (IMO), was not being picked up automatically. I will check that and update the spec as appropriate.
For the icon part, I will go with your suggestion and not resize.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #19 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-07-20 09:18:07 EDT --- New Package SCM Request ======================= Package Name: leksah Short Description: An IDE for Haskell Owners: narasim Branches: f14 f15 InitialCC: haskell-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #20 from Jon Ciesla limb@jcomserv.net 2011-07-20 09:28:21 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #21 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-07-20 10:31:38 EDT --- ghc-leksah is not required and I removed the Requires.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #22 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-07-20 10:45:25 EDT --- Built for rawhide
http://koji.fedoraproject.org/koji/taskinfo?taskID=3214809
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #23 from Fedora Update System updates@fedoraproject.org 2011-07-20 10:57:12 EDT --- leksah-0.10.0.4-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/leksah-0.10.0.4-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #24 from Fedora Update System updates@fedoraproject.org 2011-07-20 10:57:21 EDT --- leksah-0.10.0.4-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leksah-0.10.0.4-3.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #25 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-07-20 10:58:24 EDT --- Wrong build posted on comment 22 .
Rawhide build @ http://koji.fedoraproject.org/koji/buildinfo?buildID=254319
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #26 from Fedora Update System updates@fedoraproject.org 2011-07-22 15:38:13 EDT --- leksah-0.10.0.4-3.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #27 from Fedora Update System updates@fedoraproject.org 2011-08-01 22:09:06 EDT --- leksah-0.10.0.4-3.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |leksah-0.10.0.4-3.fc15 Resolution| |ERRATA Last Closed| |2011-08-01 22:09:12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
--- Comment #28 from Fedora Update System updates@fedoraproject.org 2011-08-01 22:09:20 EDT --- leksah-0.10.0.4-3.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673776
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|leksah-0.10.0.4-3.fc15 |leksah-0.10.0.4-3.fc14
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla