[Bug 225812] New: Merge Review: gnome-audio

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225812

Summary: Merge Review: gnome-audio
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: gnome-audio

http://cvs.fedora.redhat.com/viewcvs/devel/gnome-audio/
Initial Owner: [e-mail]

[Bug 225812] Merge Review: gnome-audio

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-audio

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225812

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 225812] Merge Review: gnome-audio

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-audio

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225812

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]
                 CC|                            |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-04 12:43 EST -------
Good:
* Source URL is canonical
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All directories are owned by this or other packages
* Builds fine in mock.

Must fix:
* rpmlint error: W: gnome-audio hardcoded-path-in-buildroot-tag
/var/tmp/gnome-audio-%{version}-root

Buildroot must be '%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)'.

Minor things to look at, not blockers:
* Might be nice to move the %files section before the ChangeLog.
* rpmlint error: W: gnome-audio summary-ended-with-dot Sounds for GNOME events.

[Bug 225812] Merge Review: gnome-audio

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-audio

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225812

------- Additional Comments From [e-mail]  2007-02-05 08:21 EST -------
All comments fixed in cvs (2.0.0-4)

[Bug 225812] Merge Review: gnome-audio

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-audio

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225812

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]            |[e-mail]
               Flag|fedora-review-              |fedora-review?

[Bug 225812] Merge Review: gnome-audio

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-audio

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225812

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-12 11:45 EST -------
Changes to spec look good.

+1 APPROVE.

[Bug 225812] Merge Review: gnome-audio

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-audio

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225812

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |CURRENTRELEASE

------- Additional Comments From [e-mail]  2007-08-10 16:41 EST -------
This review is done.