[Bug 1711898] New: Review Request: zeal - Offline documentation browser inspired by Dash

https://bugzilla.redhat.com/show_bug.cgi?id=1711898

Bug ID: 1711898
           Summary: Review Request: zeal - Offline documentation browser
                    inspired by Dash
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

I'd like to maintain retired package Zeal to get it back in Fedora 30 and
rawhide. For more info see rhbz#1701666

Spec URL: https://lbalhar.fedorapeople.org/zeal.spec
SRPM URL: https://lbalhar.fedorapeople.org/zeal-0.6.1-1.fc30.src.rpm
Description: Zeal is a simple offline documentation browser inspired by Dash.
Fedora Account System Username: lbalhar

Scratch builds:
rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=34949682
F30: https://koji.fedoraproject.org/koji/taskinfo?taskID=34949721
F29: https://koji.fedoraproject.org/koji/taskinfo?taskID=34949737

Specfile is from existing dist git repository for Fedora 29.

[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash

https://bugzilla.redhat.com/show_bug.cgi?id=1711898

Lumír Balhar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1701666

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1701666
[Bug 1701666] Zeal not present in Fedora 30 repositories

[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash

https://bugzilla.redhat.com/show_bug.cgi?id=1711898

Vasiliy Glazov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash

https://bugzilla.redhat.com/show_bug.cgi?id=1711898

--- Comment #1 from Vasiliy Glazov  ---
1. Remove BuildRequires:  qt5-qtbase.

2. Change cmake BR to cmake3 and %cmake macro to %cmake3.

3. As project use cmake for build it is better define BR as cmake(). For
example qt5-qtbase-devel provides "cmake(Qt5)" and can be changet to it.
BuildRequires:  cmake(Qt5)
Same for all other BRs that provide "cmake()" feature.

4. Remove DESTDIR=%{buildroot} because macro %make_install already contain it.

5. Change
%{_bindir}/zeal
%{_datadir}/icons/hicolor/*/apps/zeal.png
to
%{_bindir}/%{name}
%{_datadir}/icons/hicolor/*/apps/%{name}.png

This package still not retired. So may be you don't need review request.
Contact main maintainer.

[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash

https://bugzilla.redhat.com/show_bug.cgi?id=1711898

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Miro Hrončok  ---
> This package still not retired.

Unfortunately the package is technically retired and the maintainer doesn't
respond to the problem: bz1701666

[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash

https://bugzilla.redhat.com/show_bug.cgi?id=1711898

--- Comment #3 from Lumír Balhar  ---
Hello, Vasiliy.

Thank you very much for the review. All points solved.

Spec URL: https://lbalhar.fedorapeople.org/zeal.spec
SRPM URL: https://lbalhar.fedorapeople.org/zeal-0.6.1-2.fc30.src.rpm
Patch to see just changes:
https://lbalhar.fedorapeople.org/package-review.patch
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35138895

[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash

https://bugzilla.redhat.com/show_bug.cgi?id=1711898

Vasiliy Glazov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #4 from Vasiliy Glazov  ---
Approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/zeal
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GPL (v3 or later)", "BSD 3-clause
     "New" or "Revised" License GPL (v3 or later)", "*No copyright*
     Creative Commons Attribution Public License (v4.0)", "Creative Commons
     Attribution Public License (v4.0)". 278 files have unknown license.
     Detailed output of licensecheck in
     /home/vascom/1711898-zeal/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in zeal
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: zeal-0.6.1-2.fc31.x86_64.rpm
          zeal-debuginfo-0.6.1-2.fc31.x86_64.rpm
          zeal-debugsource-0.6.1-2.fc31.x86_64.rpm
          zeal-0.6.1-2.fc31.src.rpm
zeal.x86_64: W: no-manual-page-for-binary zeal
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

Rpmlint (debuginfo)
-------------------
Checking: zeal-debuginfo-0.6.1-2.fc31.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "ru_RU.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "ru_RU.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "ru_RU.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
sh: /usr/bin/python: No such file or directory
/usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode
string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751
  s.decode('UTF-8')
zeal-debugsource.x86_64: W: invalid-url URL: https://zealdocs.org/ <urlopen
error [Errno -2] Name or service not known>
zeal.x86_64: W: invalid-url URL: https://zealdocs.org/ <urlopen error [Errno
-2] Name or service not known>
/usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode
string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751
  s.decode('UTF-8')
zeal.x86_64: W: no-manual-page-for-binary zeal
/usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode
string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751
  s.decode('UTF-8')
zeal-debuginfo.x86_64: W: invalid-url URL: https://zealdocs.org/ <urlopen error
[Errno -2] Name or service not known>
/usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode
string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751
  s.decode('UTF-8')
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Source checksums
----------------
https://github.com/zealdocs/zeal/archive/v0.6.1.tar.gz#/zeal-0.6.1.tar.gz :
  CHECKSUM(SHA256) this package     :
095c08f9903071849d5c79878abd48237ce1615f16d324afff1873ab6b5f0026
  CHECKSUM(SHA256) upstream package :
095c08f9903071849d5c79878abd48237ce1615f16d324afff1873ab6b5f0026

Requires
--------
zeal (rpmlib, GLIBC filtered):
    hicolor-icon-theme
    libQt5Concurrent.so.5()(64bit)
    libQt5Concurrent.so.5(Qt_5)(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.12)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5WebKit.so.5()(64bit)
    libQt5WebKitWidgets.so.5()(64bit)
    libQt5WebKitWidgets.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libQt5X11Extras.so.5()(64bit)
    libQt5X11Extras.so.5(Qt_5)(64bit)
    libX11.so.6()(64bit)
    libarchive.so.13()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libsqlite3.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libxcb-keysyms.so.1()(64bit)
    libxcb.so.1()(64bit)
    rtld(GNU_HASH)

zeal-debuginfo (rpmlib, GLIBC filtered):

zeal-debugsource (rpmlib, GLIBC filtered):

Provides
--------
zeal:
    application()
    application(org.zealdocs.Zeal.desktop)
    bundled(libqxt)
    metainfo()
    metainfo(org.zealdocs.Zeal.appdata.xml)
    mimehandler(x-scheme-handler/dash)
    mimehandler(x-scheme-handler/dash-plugin)
    zeal
    zeal(x86-64)

zeal-debuginfo:
    debuginfo(build-id)
    zeal-debuginfo
    zeal-debuginfo(x86-64)

zeal-debugsource:
    zeal-debugsource
    zeal-debugsource(x86-64)

Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09
Command line :/usr/bin/fedora-review -b 1711898
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: Perl, Haskell, fonts, Java, SugarActivity, PHP, Python, R,
Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash

https://bugzilla.redhat.com/show_bug.cgi?id=1711898

Lumír Balhar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2019-06-05 08:52:55

--- Comment #5 from Lumír Balhar  ---
Thank you very much for the review! The package is back in rawhide and also in
an update for F30:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-3d36109433