[Bug 1421058] New: Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Bug ID: 1421058
           Summary: Review Request: deepin-metacity - 2D window manager
                    for Deepin
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://github.com/FZUG/repo/blob/master/rpms/deepin_project/deepin-metacity...

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17617710

Description: 2D window manager for Deepin

Fedora Account System Username: mosquito

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1465889
                   |                            |(DeepinDEPackageReview)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Felix Yan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |1421066

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1421066
[Bug 1421066] Review Request: deepin-wm-switcher - Window manager switcher
for Deepin

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
License should be GPLv2+.

find %{buildroot} -name '*.la' -exec rm -f {} ';'
→ find %{buildroot} -name '*.la' -delete

rpmlint gives a bunch of warnings like:
deepin-metacity.x86_64: W: file-not-in-%lang
/usr/share/locale/am/LC_MESSAGES/deepin-metacity.mo
deepin-metacity.x86_64: W: file-not-in-%lang
/usr/share/locale/ar/LC_MESSAGES/deepin-metacity.mo
It seems you need to call %find_lang. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files.

deepin-metacity.x86_64: W: incoherent-version-in-changelog 3.22.10-1.gite9af397
['3.22.10-1.fc27', '3.22.10-1']

I didn't test it, but it seems to be packaged OK, modulo the nits above.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #2 from [e-mail] ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...

Thanks. I fix it.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #3 from Zamir SUN  ---
(In reply to sensor.wen from comment #2)
> SPEC: 
> https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-
> x86_64/00587015-deepin-metacity/deepin-metacity.spec
> SRPM: 
> https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-
> x86_64/00587015-deepin-metacity/deepin-metacity-3.22.10-1.fc25.src.rpm
>
> Thanks. I fix it.

Please remember to use corresponding beginning of the line like "Spec URL". It
will make review much easier.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1476560

--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
Issues:
=======
- Package does not install properly:
  "nothing provides deepin-desktop-schemas needed by
deepin-metacity-3.22.10-1.fc27.x86_64"

That's actually correct, but we don't have that package yet in rawhide.
I marked that review as blocking this one.

- glib-compile-schemas is run in %postun and %posttrans if package has
  *.gschema.xml files.
  Note: gschema file(s) in deepin-metacity
  See:
  http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema

- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.
[https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usa...]

- Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/GConf,
     /usr/share/GConf/gsettings, /usr/share/gnome-control-
     center/keybindings, /usr/share/gnome/wm-properties, /usr/share/gnome-
     control-center

Add to %files
%dir /usr/share/GConf
%dir /usr/share/GConf/gsettings
and
Requires: control-center-filesystem

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476560
[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin
desktop-wide schemas

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #5 from [e-mail] ---
SPEC: 
https://raw.githubusercontent.com/FZUG/repo/afcfb988017bd8354ec4f60e63c5d692...

Fixed all. Thanks.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Oops, sorry. My comment about glib-compile-schemas was wrong. I trusted
fedora-review without checking the guidelines, but
/usr/bin/glib-compile-schemas should not be called since F24 (#1409315). So
please remove those calls again.

Looks good otherwise, I'll re-review when #1476560 is done.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #7 from [e-mail] ---
Diff: 
https://github.com/FZUG/repo/commit/23c189b5fed5a5899dc0150a00e581722795a2ef

:) Thanks, it's not your not fault.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #8 from [e-mail] ---
Diff: 
https://github.com/FZUG/repo/commit/23c189b5fed5a5899dc0150a00e581722795a2ef

:) Thanks, it's not your fault.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #9 from [e-mail] ---
#1476560 is done. Could you review it? @Zbigniew Jędrzejewski-Szmek

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
I'm looking at
https://github.com/FZUG/repo/blob/e7d45acd1874a9bb0934721f6d2163688e19714e/r....

Hmm, fails to build here:
+ cd deepin-metacity-3.22.10
+ desktop-file-validate
/builddir/build/BUILDROOT/deepin-metacity-3.22.10-1.fc28.x86_64/usr/share/applications/deepin-metacity.desktop
/builddir/build/BUILDROOT/deepin-metacity-3.22.10-1.fc28.x86_64/usr/share/gnome/wm-properties/deepin-metacity-wm.desktop
/builddir/build/BUILDROOT/deepin-metacity-3.22.10-1.fc28.x86_64/usr/share/gnome/wm-properties/deepin-metacity-wm.desktop:
error: file contains group "Window Manager", but groups extending the format
should start with "X-"

??

--

BTW, I fell out out the loop with the deepin reviews. If there's something
other ticket I should look at, I'd appreciate a reminder.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #11 from [e-mail] ---
Thank you for your work. I fixed.

https://koji.fedoraproject.org/koji/taskinfo?taskID=22354205

Currently, only two packages needs review (deepin-wm deepin-wm-switcher). If
your have free time, maybe review them.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #12 from Zbigniew Jędrzejewski-Szmek  ---
+ package name is OK
+ license is acceptable for Fedora (GPLv2+)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ fedora-review finds no issues (except obsolete comment about scriptlets for
schemas which have been replaced by transfiletriggers)
+ BR/ Requires / Provides look correct
+ scriptlets are sane

Package is APPROVED.

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

--- Comment #13 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-metacity

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |deepin-metacity

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058
Bug 1421058 depends on bug 1476560, which changed state.

Bug 1476560 Summary: Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas
https://bugzilla.redhat.com/show_bug.cgi?id=1476560

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |RAWHIDE

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2018-07-22 09:30:46

--- Comment #14 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.